From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHG3R-0003Am-Jn for guix-patches@gnu.org; Tue, 21 Nov 2017 16:26:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eHG3O-0006hU-FX for guix-patches@gnu.org; Tue, 21 Nov 2017 16:26:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:42831) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eHG3O-0006hM-BR for guix-patches@gnu.org; Tue, 21 Nov 2017 16:26:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eHG3O-00057n-2x for guix-patches@gnu.org; Tue, 21 Nov 2017 16:26:02 -0500 Subject: bug#29386: Update taglib to 1.11.1. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Marius Bakke In-Reply-To: References: Date: Tue, 21 Nov 2017 22:25:30 +0100 Message-ID: <8760a3qq7p.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Langlois , 29386-done@debbugs.gnu.org --=-=-= Content-Type: text/plain Pierre Langlois writes: > Hello Guix! > > This is a patch to update taglib. I've had to enable building as a > shared library otherwise gst-plugins-good would fail to link. Also, > `guix lint' warned about the home page redirecting to http://taglib.org > so I thought I'd fix that too. Hello Pierre, Thank you for this patch, and for checking dependent packages! I've applied it after fixing a typo in the commit message (home page). > Finally, I tried to enable the tests by adding "-DBUILD_TESTS" as a > configure flag but they are explicitely disabled if building the shared > library: > ~~~ > if(BUILD_TESTS AND NOT BUILD_SHARED_LIBS) > enable_testing() > add_subdirectory(tests) > endif() > ~~~ > > Oh well, how does this look? OK! Perhaps we could do a separate build just for the tests, but that should be in a standalone patch anyway. Pushed as d1451fa0d0b27a20ef3a1b3fe8d53a995f0c4d85. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAloUmcsACgkQoqBt8qM6 VPq6ewf+Nau1ichQndaS13RkjSwo/GNxf7v4+znQXibzoKhiwdoZW9cRK4aDwbdb qOXGu0OZ4oORSgNWknqs2G2IXjYjUhR2iUwd6LKC3Z5vFAPKNm52jaDY2Ps4ob4B 1xtNfceLWp9SwRFYjNdqo44+foKgJckaDW9/lNarHoXjLorisWU4DUBCzMER6p+4 em7iXFC9a01eIyi2d5sVwmAmw2k0/14zOcqY5v6IlFC8Xu3OVbIPcs3gQ6fbVLgv lXf+qnu2ToBiPO2NTmmVoiT+EHiPtiLZ3WwYHBz0dPNm5sEalNS/hWcqf0XwyN1d WCi6hQdyBKvRd8INajU2wQdseOyHzw== =c2vw -----END PGP SIGNATURE----- --=-=-=--