unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Pierre Langlois <pierre.langlois@gmx.com>
To: 29386@debbugs.gnu.org
Subject: [bug#29386] Update taglib to 1.11.1.
Date: Tue, 21 Nov 2017 21:11:58 +0000	[thread overview]
Message-ID: <cubshd71gm9.fsf@gmx.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

Hello Guix!

This is a patch to update taglib. I've had to enable building as a
shared library otherwise gst-plugins-good would fail to link. Also,
`guix lint' warned about the home page redirecting to http://taglib.org
so I thought I'd fix that too.

Finally, I tried to enable the tests by adding "-DBUILD_TESTS" as a
configure flag but they are explicitely disabled if building the shared
library:
~~~
if(BUILD_TESTS AND NOT BUILD_SHARED_LIBS)
  enable_testing()
  add_subdirectory(tests)
endif()
~~~

Oh well, how does this look?

Thanks!
Pierre


[-- Attachment #2: 0001-gnu-taglib-Update-to-1.11.1-and-fix-home-page.patch --]
[-- Type: text/x-patch, Size: 2091 bytes --]

From 994f090fb285ff7c09a462e87c48e50c3d0e45dc Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Tue, 21 Nov 2017 09:49:35 +0000
Subject: [PATCH] gnu: taglib: Update to 1.11.1 and fix home page.

* gnu/packages/mp3.scm (taglib)[version]: Update to 1.11.1.
[arguments]: Configure with -DBUILD_SHARED_LIBS=ON.
[home-page]: Change to http://taglig.org.
---
 gnu/packages/mp3.scm | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index 1860997e0..fbb924ba5 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2017 Thomas Danckaert <post@thomasdanckaert.be>
+;;; Copyright © 2017 Pierre Langlois <pierre.langlois@gmx.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -151,18 +152,20 @@ a highly stable and efficient implementation.")
 (define-public taglib
   (package
     (name "taglib")
-    (version "1.10")
+    (version "1.11.1")
     (source (origin
               (method url-fetch)
               (uri (string-append "http://taglib.github.io/releases/taglib-"
                                   version ".tar.gz"))
               (sha256
                (base32
-                "1alv6vp72p0x9i9yscmz2a71anjwqy53y9pbcbqxvc1c0i82vhr4"))))
+                "0ssjcdjv4qf9liph5ry1kngam1y7zp8fzr9xv4wzzrma22kabldn"))))
     (build-system cmake-build-system)
-    (arguments '(#:tests? #f))                    ;no 'test' target
+    (arguments
+      '(#:tests? #f ; Tests are not ran with BUILD_SHARED_LIBS on.
+        #:configure-flags (list "-DBUILD_SHARED_LIBS=ON")))
     (inputs `(("zlib" ,zlib)))
-    (home-page "http://developer.kde.org/~wheeler/taglib.html")
+    (home-page "http://taglib.org")
     (synopsis "Library to access audio file meta-data")
     (description
      "TagLib is a C++ library for reading and editing the meta-data of several
-- 
2.15.0


             reply	other threads:[~2017-11-21 21:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-21 21:11 Pierre Langlois [this message]
2017-11-21 21:25 ` bug#29386: Update taglib to 1.11.1 Marius Bakke
2017-11-21 21:29   ` [bug#29386] " Pierre Langlois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cubshd71gm9.fsf@gmx.com \
    --to=pierre.langlois@gmx.com \
    --cc=29386@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).