* [bug#44599] [PATCH] gnu: Add emacs-parsec.
@ 2020-11-12 22:14 Adam Kandur via Guix-patches via
2020-11-14 20:14 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Adam Kandur via Guix-patches via @ 2020-11-12 22:14 UTC (permalink / raw)
To: 44599
[-- Attachment #1: Type: text/plain, Size: 2 bytes --]
[-- Attachment #2: 0001-gnu-Add-emacs-parsec.patch --]
[-- Type: text/x-patch, Size: 1959 bytes --]
From bd90a0760ac850adc3f06e6ef12ef5ca991115f2 Mon Sep 17 00:00:00 2001
From: Adam <rndd@tuta.io>
Date: Fri, 13 Nov 2020 01:12:53 +0300
Subject: [PATCH] gnu: Add emacs-parsec.
* gnu/packages/emacs-xyz.scm (emacs-parsec): New variable.
---
gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2704292..ec3d67b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -23946,6 +23946,31 @@ It supports several input and output formats, all powered by the
same shift-reduce parser function.")
(license license:gpl3+)))
+(define-public emacs-parsec
+ (let ((revision "0")
+ (commit "2cbbbc2254aa7bcaa4fb5e07c8c1bf2f381dba26"))
+ ;; no taged branch
+ (package
+ (name "emacs-parsec")
+ (build-system emacs-build-system)
+ (version (git-version "0.1.3" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/cute-jumper/parsec.el")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1g1s8s45g3kkbi3h7w0pmadmzdswb64mkdvdpg2lihg341kx37gm"))))
+ (home-page "https://github.com/cute-jumper/parsec.el")
+ (synopsis "A parser combinator library for Emacs Lisp, similar to Haskell's Parsec library.")
+ (description "This library, however, contains most of the parser combinators in Text.Parsec.Combinator,
+which should be enough in most use cases. Of course more combinators can be added if necessary!
+Most of the parser combinators have the same behavior as their Haskell counterparts.
+@code{parsec} also comes with a simple error handling mechanism so that it can display an error message showing how the parser fails.")
+ (license license:gpl3))))
+
(define-public emacs-hide-mode-line
(package
(name "emacs-hide-mode-line")
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [bug#44599] [PATCH] gnu: Add emacs-parsec.
2020-11-12 22:14 [bug#44599] [PATCH] gnu: Add emacs-parsec Adam Kandur via Guix-patches via
@ 2020-11-14 20:14 ` Nicolas Goaziou
2020-11-15 9:02 ` Adam Kandur via Guix-patches via
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2020-11-14 20:14 UTC (permalink / raw)
To: 44599; +Cc: rndd
Hello,
Adam Kandur via Guix-patches via <guix-patches@gnu.org> writes:
> Subject: [PATCH] gnu: Add emacs-parsec.
Thank you. Some comments follow.
> +(define-public emacs-parsec
> + (let ((revision "0")
> + (commit "2cbbbc2254aa7bcaa4fb5e07c8c1bf2f381dba26"))
> + ;; no taged branch
Usually, the comment is above the `let', because you expect it to
comment what is located below.
Also, this comment is not true. There are tags, the last one being
"0.1.3". If you think we need the latest commit, you can write that the
last release is too old instead.
> + (package
> + (name "emacs-parsec")
> + (build-system emacs-build-system)
This is an unusual place for `build-system'. You may want to move it
below the `source' part.
> + (version (git-version "0.1.3" revision commit))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/cute-jumper/parsec.el")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "1g1s8s45g3kkbi3h7w0pmadmzdswb64mkdvdpg2lihg341kx37gm"))))
The indentation looks a bit off.
> + (home-page "https://github.com/cute-jumper/parsec.el")
> + (synopsis "A parser combinator library for Emacs Lisp, similar to Haskell's Parsec library.")
Synopsis cannot start with "A", and should not end with a full stop. You
may want to run "guix lint" on this.
The synopsis could be: "Parser combinator library for Emacs Lisp"
> + (description "This library, however, contains most of the parser combinators in Text.Parsec.Combinator,
> +which should be enough in most use cases. Of course more combinators can be added if necessary!
> +Most of the parser combinators have the same behavior as their Haskell counterparts.
> +@code{parsec} also comes with a simple error handling mechanism so that it can display an error message showing how the parser fails.")
The description seems to depend on the synopsis, but it should be
stand-alone. What about:
Parsec is a parser combinator library for Emacs Lisp, similar to
Haskell's Parsec library. It contains most of the parser
combinators in Text.Parsec.Combinator, and more combinators can be
added if necessary! Most of the parser combinators have the same
behavior as their Haskell counterparts. Parsec also comes with
a simple error handling mechanism so that it can display an error
message showing how the parser fails.
Mind the two spaces after sentences!
> + (license license:gpl3))))
License is actually gpl3+.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread* [bug#44599] [PATCH] gnu: Add emacs-parsec.
2020-11-14 20:14 ` Nicolas Goaziou
@ 2020-11-15 9:02 ` Adam Kandur via Guix-patches via
2020-11-15 21:26 ` bug#44599: " Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Adam Kandur via Guix-patches via @ 2020-11-15 9:02 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 44599
From 6293a6b4789d4e8b799511b901783ec83017d1d7 Mon Sep 17 00:00:00 2001
From: Adam <rndd@tuta.io>
Date: Sun, 15 Nov 2020 12:00:23 +0300
Subject: [PATCH] gnu: Add emacs-parsec.
* gnu/packages/emacs-xyz.scm (emacs-parsec): New variable.
---
gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f44a8bc..9229505 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15009,6 +15009,30 @@ and @code{erc-send-modify-hook} to download and show images.")
(description "This package provides a list manipulation library for Emacs.")
(license license:gpl3+)))
+(define-public emacs-parsec
+ ;; last release is too old
+ (let ((revision "0")
+ (commit "2cbbbc2254aa7bcaa4fb5e07c8c1bf2f381dba26"))
+ (package
+ (name "emacs-parsec")
+ (version (git-version "0.1.3" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/cute-jumper/parsec.el")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1g1s8s45g3kkbi3h7w0pmadmzdswb64mkdvdpg2lihg341kx37gm"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/cute-jumper/parsec.el")
+ (synopsis "Parser combinator library for Emacs Lisp")
+ (description "Parsec is a parser combinator library for Emacs Lisp, similar to Haskell's Parsec library. It contains most of the parser
+combinators in Text.Parsec.Combinator, and more combinators can be added if necessary! Most of the parser combinators have the same
+behavior as their Haskell counterparts. Parsec also comes with a simple error handling mechanism so that it can display an error message showing how the parser fails.")
+ (license license:gpl3+))))
+
(define-public emacs-move-text
(package
(name "emacs-move-text")
--
2.28.0
hope, this is right
Nov 14, 2020, 20:14 by mail@nicolasgoaziou.fr:
> Hello,
>
> Adam Kandur via Guix-patches via <guix-patches@gnu.org> writes:
>
>> Subject: [PATCH] gnu: Add emacs-parsec.
>>
>
> Thank you. Some comments follow.
>
>> +(define-public emacs-parsec
>> + (let ((revision "0")
>> + (commit "2cbbbc2254aa7bcaa4fb5e07c8c1bf2f381dba26"))
>> + ;; no taged branch
>>
>
> Usually, the comment is above the `let', because you expect it to
> comment what is located below.
>
> Also, this comment is not true. There are tags, the last one being
> "0.1.3". If you think we need the latest commit, you can write that the
> last release is too old instead.
>
>> + (package
>> + (name "emacs-parsec")
>> + (build-system emacs-build-system)
>>
>
> This is an unusual place for `build-system'. You may want to move it
> below the `source' part.
>
>> + (version (git-version "0.1.3" revision commit))
>> + (source
>> + (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://github.com/cute-jumper/parsec.el")
>> + (commit commit)))
>> + (file-name (git-file-name name version))
>> + (sha256
>> + (base32 "1g1s8s45g3kkbi3h7w0pmadmzdswb64mkdvdpg2lihg341kx37gm"))))
>>
>
> The indentation looks a bit off.
>
>> + (home-page "https://github.com/cute-jumper/parsec.el")
>> + (synopsis "A parser combinator library for Emacs Lisp, similar to Haskell's Parsec library.")
>>
>
> Synopsis cannot start with "A", and should not end with a full stop. You
> may want to run "guix lint" on this.
>
> The synopsis could be: "Parser combinator library for Emacs Lisp"
>
>> + (description "This library, however, contains most of the parser combinators in Text.Parsec.Combinator,
>> +which should be enough in most use cases. Of course more combinators can be added if necessary!
>> +Most of the parser combinators have the same behavior as their Haskell counterparts.
>> +@code{parsec} also comes with a simple error handling mechanism so that it can display an error message showing how the parser fails.")
>>
>
> The description seems to depend on the synopsis, but it should be
> stand-alone. What about:
>
> Parsec is a parser combinator library for Emacs Lisp, similar to
> Haskell's Parsec library. It contains most of the parser
> combinators in Text.Parsec.Combinator, and more combinators can be
> added if necessary! Most of the parser combinators have the same
> behavior as their Haskell counterparts. Parsec also comes with
> a simple error handling mechanism so that it can display an error
> message showing how the parser fails.
>
> Mind the two spaces after sentences!
>
>> + (license license:gpl3))))
>>
>
> License is actually gpl3+.
>
> Could you send an updated patch?
>
> Regards,
> --
> Nicolas Goaziou
>
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-15 21:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 22:14 [bug#44599] [PATCH] gnu: Add emacs-parsec Adam Kandur via Guix-patches via
2020-11-14 20:14 ` Nicolas Goaziou
2020-11-15 9:02 ` Adam Kandur via Guix-patches via
2020-11-15 21:26 ` bug#44599: " Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).