From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2P1ZOdHusF9NDAAA0tVLHw (envelope-from ) for ; Sun, 15 Nov 2020 09:03:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WIY8NdHusF/IXwAAB5/wlQ (envelope-from ) for ; Sun, 15 Nov 2020 09:03:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 90A6E940466 for ; Sun, 15 Nov 2020 09:03:12 +0000 (UTC) Received: from localhost ([::1]:38424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keDwD-0001wB-Le for larch@yhetil.org; Sun, 15 Nov 2020 04:03:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keDw6-0001vq-55 for guix-patches@gnu.org; Sun, 15 Nov 2020 04:03:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40928) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1keDw5-0004v2-Rd for guix-patches@gnu.org; Sun, 15 Nov 2020 04:03:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1keDw5-0002Tl-Ot for guix-patches@gnu.org; Sun, 15 Nov 2020 04:03:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44599] [PATCH] gnu: Add emacs-parsec. Resent-From: Adam Kandur Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 Nov 2020 09:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44599 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 44599@debbugs.gnu.org Received: via spool by 44599-submit@debbugs.gnu.org id=B44599.16054309499490 (code B ref 44599); Sun, 15 Nov 2020 09:03:01 +0000 Received: (at 44599) by debbugs.gnu.org; 15 Nov 2020 09:02:29 +0000 Received: from localhost ([127.0.0.1]:52474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keDvZ-0002T0-66 for submit@debbugs.gnu.org; Sun, 15 Nov 2020 04:02:29 -0500 Received: from w4.tutanota.de ([81.3.6.165]:57748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keDvQ-0002SV-TX for 44599@debbugs.gnu.org; Sun, 15 Nov 2020 04:02:27 -0500 Received: from w3.tutanota.de (unknown [192.168.1.164]) by w4.tutanota.de (Postfix) with ESMTP id 6016D106015F; Sun, 15 Nov 2020 09:02:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1605430934; s=s1; d=tuta.io; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=BP+YGzqzz/Q06bdZp6zU6kSNxJUDUKN3FkvZDb4FkfM=; b=gKIDtxnbdbVhZ2O46J1I5Vp3BF6IpQqQrOAZIOjx9kjXmfc9x6wZSeKhAZCSqMCG ww4YxjnVdiHaH7hk4J29sbnJUGKYfnb5C4EIQGQLIKvzLPaGuIG6unrTkujr2EbKUvT D8QO3JCOH8ohmTtI9j5V6jOlH7eiBed9oSsZ/2xV1m9bAbwC/dN9Gty52gvw/XzYQoW UUKFAyGTuDapcONCMOT/lVPteo/CJVgljmuIcNE/+LaurxOMaWYY7PGnfGvAdz3Mu/l /ahJ70K7jl3Tdddn2M7IT0QGWKA3FWUgXA1U6Bhkgm7TS0jhFSREhxMv/twbOQ1FuXk 7avTNDQgGg== Date: Sun, 15 Nov 2020 10:02:14 +0100 (CET) Message-ID: In-Reply-To: <87361bofv9.fsf@nicolasgoaziou.fr> References: <87361bofv9.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Adam Kandur , Adam Kandur via Guix-patches From: Adam Kandur via Guix-patches via X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=tuta.io header.s=s1 header.b=gKIDtxnb; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: wmbqK69pUP9R >From 6293a6b4789d4e8b799511b901783ec83017d1d7 Mon Sep 17 00:00:00 2001 From: Adam Date: Sun, 15 Nov 2020 12:00:23 +0300 Subject: [PATCH] gnu: Add emacs-parsec. * gnu/packages/emacs-xyz.scm (emacs-parsec): New variable. --- =C2=A0gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++ =C2=A01 file changed, 24 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index f44a8bc..9229505 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -15009,6 +15009,30 @@ and @code{erc-send-modify-hook} to download and sh= ow images.") =C2=A0=C2=A0=C2=A0=C2=A0 (description "This package provides a list manipul= ation library for Emacs.") =C2=A0=C2=A0=C2=A0=C2=A0 (license license:gpl3+))) =C2=A0 +(define-public emacs-parsec +=C2=A0 ;; last release is too old +=C2=A0 (let ((revision "0") +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (commit "2cbbbc2254aa7bcaa4fb5e= 07c8c1bf2f381dba26")) +=C2=A0=C2=A0=C2=A0 (package +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (name "emacs-parsec") +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (version (git-version "0.1.3" revision comm= it)) +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (source +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (origin +=C2=A0=C2=A0=C2=A0 =C2=A0(method git-fetch) +=C2=A0=C2=A0=C2=A0 =C2=A0(uri (git-reference +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (url "https://gith= ub.com/cute-jumper/parsec.el") +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (commit commit))) +=C2=A0=C2=A0=C2=A0 =C2=A0(file-name (git-file-name name version)) +=C2=A0=C2=A0=C2=A0 =C2=A0(sha256 +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (base32 "1g1s8s45g3= kkbi3h7w0pmadmzdswb64mkdvdpg2lihg341kx37gm")))) +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (build-system emacs-build-system) +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (home-page "https://github.com/cute-jumper/= parsec.el") +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (synopsis "Parser combinator library for Em= acs Lisp") +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (description "Parsec is a parser combinator= library for Emacs Lisp, similar to Haskell's Parsec library.=C2=A0 It cont= ains most of the parser +combinators in Text.Parsec.Combinator, and more combinators can be added i= f necessary!=C2=A0 Most of the parser combinators have the same +behavior as their Haskell counterparts.=C2=A0 Parsec also comes with a sim= ple error handling mechanism so that it can display an error message showin= g how the parser fails.") +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (license license:gpl3+)))) + =C2=A0(define-public emacs-move-text =C2=A0=C2=A0 (package =C2=A0=C2=A0=C2=A0=C2=A0 (name "emacs-move-text") --=20 2.28.0 hope, this is right Nov 14, 2020, 20:14 by mail@nicolasgoaziou.fr: > Hello, > > Adam Kandur via Guix-patches via writes: > >> Subject: [PATCH] gnu: Add emacs-parsec. >> > > Thank you. Some comments follow. > >> +(define-public emacs-parsec >> + (let ((revision "0") >> + (commit "2cbbbc2254aa7bcaa4fb5e07c8c1bf2f381dba26")) >> + ;; no taged branch >> > > Usually, the comment is above the `let', because you expect it to > comment what is located below. > > Also, this comment is not true. There are tags, the last one being > "0.1.3". If you think we need the latest commit, you can write that the > last release is too old instead. > >> + (package >> + (name "emacs-parsec") >> + (build-system emacs-build-system) >> > > This is an unusual place for `build-system'. You may want to move it > below the `source' part. > >> + (version (git-version "0.1.3" revision commit)) >> + (source >> + (origin >> +=09 (method git-fetch) >> +=09 (uri (git-reference >> +=09 (url "https://github.com/cute-jumper/parsec.el") >> +=09 (commit commit))) >> +=09 (file-name (git-file-name name version)) >> +=09 (sha256 >> + (base32 "1g1s8s45g3kkbi3h7w0pmadmzdswb64mkdvdpg2lihg341kx37gm= ")))) >> > > The indentation looks a bit off. > >> + (home-page "https://github.com/cute-jumper/parsec.el") >> + (synopsis "A parser combinator library for Emacs Lisp, similar to= Haskell's Parsec library.") >> > > Synopsis cannot start with "A", and should not end with a full stop. You > may want to run "guix lint" on this. > > The synopsis could be: "Parser combinator library for Emacs Lisp" > >> + (description "This library, however, contains most of the parser = combinators in Text.Parsec.Combinator,=20 >> +which should be enough in most use cases. Of course more combinators ca= n be added if necessary!=20 >> +Most of the parser combinators have the same behavior as their Haskell = counterparts.=20 >> +@code{parsec} also comes with a simple error handling mechanism so that= it can display an error message showing how the parser fails.") >> > > The description seems to depend on the synopsis, but it should be > stand-alone. What about: > > Parsec is a parser combinator library for Emacs Lisp, similar to > Haskell's Parsec library. It contains most of the parser > combinators in Text.Parsec.Combinator, and more combinators can be > added if necessary! Most of the parser combinators have the same > behavior as their Haskell counterparts. Parsec also comes with > a simple error handling mechanism so that it can display an error > message showing how the parser fails. > > Mind the two spaces after sentences! > >> + (license license:gpl3)))) >> > > License is actually gpl3+. > > Could you send an updated patch? > > Regards, > --=20 > Nicolas Goaziou >