From: Adam Kandur via Guix-patches via <guix-patches@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 44599@debbugs.gnu.org
Subject: [bug#44599] [PATCH] gnu: Add emacs-parsec.
Date: Sun, 15 Nov 2020 10:02:14 +0100 (CET) [thread overview]
Message-ID: <MMA7z8A--3-2@tuta.io> (raw)
In-Reply-To: <87361bofv9.fsf@nicolasgoaziou.fr>
From 6293a6b4789d4e8b799511b901783ec83017d1d7 Mon Sep 17 00:00:00 2001
From: Adam <rndd@tuta.io>
Date: Sun, 15 Nov 2020 12:00:23 +0300
Subject: [PATCH] gnu: Add emacs-parsec.
* gnu/packages/emacs-xyz.scm (emacs-parsec): New variable.
---
gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f44a8bc..9229505 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15009,6 +15009,30 @@ and @code{erc-send-modify-hook} to download and show images.")
(description "This package provides a list manipulation library for Emacs.")
(license license:gpl3+)))
+(define-public emacs-parsec
+ ;; last release is too old
+ (let ((revision "0")
+ (commit "2cbbbc2254aa7bcaa4fb5e07c8c1bf2f381dba26"))
+ (package
+ (name "emacs-parsec")
+ (version (git-version "0.1.3" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/cute-jumper/parsec.el")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1g1s8s45g3kkbi3h7w0pmadmzdswb64mkdvdpg2lihg341kx37gm"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/cute-jumper/parsec.el")
+ (synopsis "Parser combinator library for Emacs Lisp")
+ (description "Parsec is a parser combinator library for Emacs Lisp, similar to Haskell's Parsec library. It contains most of the parser
+combinators in Text.Parsec.Combinator, and more combinators can be added if necessary! Most of the parser combinators have the same
+behavior as their Haskell counterparts. Parsec also comes with a simple error handling mechanism so that it can display an error message showing how the parser fails.")
+ (license license:gpl3+))))
+
(define-public emacs-move-text
(package
(name "emacs-move-text")
--
2.28.0
hope, this is right
Nov 14, 2020, 20:14 by mail@nicolasgoaziou.fr:
> Hello,
>
> Adam Kandur via Guix-patches via <guix-patches@gnu.org> writes:
>
>> Subject: [PATCH] gnu: Add emacs-parsec.
>>
>
> Thank you. Some comments follow.
>
>> +(define-public emacs-parsec
>> + (let ((revision "0")
>> + (commit "2cbbbc2254aa7bcaa4fb5e07c8c1bf2f381dba26"))
>> + ;; no taged branch
>>
>
> Usually, the comment is above the `let', because you expect it to
> comment what is located below.
>
> Also, this comment is not true. There are tags, the last one being
> "0.1.3". If you think we need the latest commit, you can write that the
> last release is too old instead.
>
>> + (package
>> + (name "emacs-parsec")
>> + (build-system emacs-build-system)
>>
>
> This is an unusual place for `build-system'. You may want to move it
> below the `source' part.
>
>> + (version (git-version "0.1.3" revision commit))
>> + (source
>> + (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://github.com/cute-jumper/parsec.el")
>> + (commit commit)))
>> + (file-name (git-file-name name version))
>> + (sha256
>> + (base32 "1g1s8s45g3kkbi3h7w0pmadmzdswb64mkdvdpg2lihg341kx37gm"))))
>>
>
> The indentation looks a bit off.
>
>> + (home-page "https://github.com/cute-jumper/parsec.el")
>> + (synopsis "A parser combinator library for Emacs Lisp, similar to Haskell's Parsec library.")
>>
>
> Synopsis cannot start with "A", and should not end with a full stop. You
> may want to run "guix lint" on this.
>
> The synopsis could be: "Parser combinator library for Emacs Lisp"
>
>> + (description "This library, however, contains most of the parser combinators in Text.Parsec.Combinator,
>> +which should be enough in most use cases. Of course more combinators can be added if necessary!
>> +Most of the parser combinators have the same behavior as their Haskell counterparts.
>> +@code{parsec} also comes with a simple error handling mechanism so that it can display an error message showing how the parser fails.")
>>
>
> The description seems to depend on the synopsis, but it should be
> stand-alone. What about:
>
> Parsec is a parser combinator library for Emacs Lisp, similar to
> Haskell's Parsec library. It contains most of the parser
> combinators in Text.Parsec.Combinator, and more combinators can be
> added if necessary! Most of the parser combinators have the same
> behavior as their Haskell counterparts. Parsec also comes with
> a simple error handling mechanism so that it can display an error
> message showing how the parser fails.
>
> Mind the two spaces after sentences!
>
>> + (license license:gpl3))))
>>
>
> License is actually gpl3+.
>
> Could you send an updated patch?
>
> Regards,
> --
> Nicolas Goaziou
>
next prev parent reply other threads:[~2020-11-15 9:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 22:14 [bug#44599] [PATCH] gnu: Add emacs-parsec Adam Kandur via Guix-patches via
2020-11-14 20:14 ` Nicolas Goaziou
2020-11-15 9:02 ` Adam Kandur via Guix-patches via [this message]
2020-11-15 21:26 ` bug#44599: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MMA7z8A--3-2@tuta.io \
--to=guix-patches@gnu.org \
--cc=44599@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
--cc=rndd@tuta.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).