From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qPMuF9E6sF9seAAA0tVLHw (envelope-from ) for ; Sat, 14 Nov 2020 20:15:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eNv4EtE6sF9dZQAAbx9fmQ (envelope-from ) for ; Sat, 14 Nov 2020 20:15:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D5F849403A9 for ; Sat, 14 Nov 2020 20:15:12 +0000 (UTC) Received: from localhost ([::1]:47818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ke1x0-0007QJ-Tu for larch@yhetil.org; Sat, 14 Nov 2020 15:15:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ke1ws-0007PM-Tb for guix-patches@gnu.org; Sat, 14 Nov 2020 15:15:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40549) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ke1ws-0007TX-LF for guix-patches@gnu.org; Sat, 14 Nov 2020 15:15:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ke1ws-0002Qb-Eu for guix-patches@gnu.org; Sat, 14 Nov 2020 15:15:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44599] [PATCH] gnu: Add emacs-parsec. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Nov 2020 20:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44599 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 44599@debbugs.gnu.org Cc: rndd@tuta.io X-Debbugs-Original-To: Adam Kandur via Guix-patches via X-Debbugs-Original-Cc: 44599@debbugs.gnu.org, Adam Kandur Received: via spool by submit@debbugs.gnu.org id=B.16053848859296 (code B ref -1); Sat, 14 Nov 2020 20:15:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Nov 2020 20:14:45 +0000 Received: from localhost ([127.0.0.1]:52095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ke1wb-0002Pn-61 for submit@debbugs.gnu.org; Sat, 14 Nov 2020 15:14:45 -0500 Received: from lists.gnu.org ([209.51.188.17]:36566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ke1wa-0002Pe-40 for submit@debbugs.gnu.org; Sat, 14 Nov 2020 15:14:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ke1wZ-0007NM-W7 for guix-patches@gnu.org; Sat, 14 Nov 2020 15:14:44 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:45473) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ke1wX-0007RS-NS for guix-patches@gnu.org; Sat, 14 Nov 2020 15:14:43 -0500 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 4EE78200004; Sat, 14 Nov 2020 20:14:35 +0000 (UTC) From: Nicolas Goaziou References: Date: Sat, 14 Nov 2020 21:14:34 +0100 In-Reply-To: (Adam Kandur via Guix-patches via's message of "Thu, 12 Nov 2020 23:14:49 +0100 (CET)") Message-ID: <87361bofv9.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.178.232; envelope-from=mail@nicolasgoaziou.fr; helo=relay12.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/14 15:14:37 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.6 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: hBo7VQPtTCHi Hello, Adam Kandur via Guix-patches via writes: > Subject: [PATCH] gnu: Add emacs-parsec. Thank you. Some comments follow. > +(define-public emacs-parsec > + (let ((revision "0") > + (commit "2cbbbc2254aa7bcaa4fb5e07c8c1bf2f381dba26")) > + ;; no taged branch Usually, the comment is above the `let', because you expect it to comment what is located below. Also, this comment is not true. There are tags, the last one being "0.1.3". If you think we need the latest commit, you can write that the last release is too old instead. > + (package > + (name "emacs-parsec") > + (build-system emacs-build-system) This is an unusual place for `build-system'. You may want to move it below the `source' part. > + (version (git-version "0.1.3" revision commit)) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/cute-jumper/parsec.el") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "1g1s8s45g3kkbi3h7w0pmadmzdswb64mkdvdpg2lihg341kx37gm")))) The indentation looks a bit off. > + (home-page "https://github.com/cute-jumper/parsec.el") > + (synopsis "A parser combinator library for Emacs Lisp, similar to Haskell's Parsec library.") Synopsis cannot start with "A", and should not end with a full stop. You may want to run "guix lint" on this. The synopsis could be: "Parser combinator library for Emacs Lisp" > + (description "This library, however, contains most of the parser combinators in Text.Parsec.Combinator, > +which should be enough in most use cases. Of course more combinators can be added if necessary! > +Most of the parser combinators have the same behavior as their Haskell counterparts. > +@code{parsec} also comes with a simple error handling mechanism so that it can display an error message showing how the parser fails.") The description seems to depend on the synopsis, but it should be stand-alone. What about: Parsec is a parser combinator library for Emacs Lisp, similar to Haskell's Parsec library. It contains most of the parser combinators in Text.Parsec.Combinator, and more combinators can be added if necessary! Most of the parser combinators have the same behavior as their Haskell counterparts. Parsec also comes with a simple error handling mechanism so that it can display an error message showing how the parser fails. Mind the two spaces after sentences! > + (license license:gpl3)))) License is actually gpl3+. Could you send an updated patch? Regards, -- Nicolas Goaziou