unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#56111] [PATCH] gnu: playerctl: update to 2.4.1.
@ 2022-06-20 17:05 Jose G Perez Taveras
  2022-06-21 11:29 ` Christopher Baines
  0 siblings, 1 reply; 5+ messages in thread
From: Jose G Perez Taveras @ 2022-06-20 17:05 UTC (permalink / raw)
  To: 56111; +Cc: Jose G Perez Taveras

Hello,

Here is an update to playerctl to 2.4.1 and fixed dependencies.
It uses `dbus-launch' to start a new daemon.

This is my first time sending a patch, I would be very happy if you
could point me out to anything I should know.

Thank you,
josegpt

---
 gnu/packages/music.scm | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 60cb176320..86a1d64ff9 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -48,6 +48,7 @@
 ;;; Copyright © 2022 Remco van 't Veer <remco@remworks.net>
 ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;; Copyright © 2022 Wamm K. D. <jaft.r@outlook.com>
+;;; Copyright © 2022 Jose G Perez Taveras <josegpt27@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5562,7 +5563,7 @@ (define-public pragha
 (define-public playerctl
   (package
     (name "playerctl")
-    (version "2.2.1")
+    (version "2.4.1")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -5571,14 +5572,15 @@ (define-public playerctl
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "17hi33sw3663qz5v54bqqil31sgkrlxkb2l5bgqk87pac6x2wnbz"))))
+                "0ij065blj3h5v6iivvpmgh1095vicj1nc7hp1nhlhpqagd98l89s"))))
     (build-system meson-build-system)
     (arguments
-     `(#:configure-flags '("-Dintrospection=false" "-Dgtk-doc=false")))
-    (inputs (list python-pygobject))
+     `(#:configure-flags '("-Dgtk-doc=false")))
     (native-inputs
      `(("glib:bin" ,glib "bin")
-       ("pkg-config" ,pkg-config)))
+       ("pkg-config" ,pkg-config)
+       ("gobject-introspection" ,gobject-introspection)))
+    (propagated-inputs (list dbus))
     (synopsis "Control MPRIS-supporting media player applications")
     (description
      "Playerctl is a command-line utility and library for controlling media
-- 
2.36.1





^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#56111] [PATCH] gnu: playerctl: update to 2.4.1.
  2022-06-20 17:05 [bug#56111] [PATCH] gnu: playerctl: update to 2.4.1 Jose G Perez Taveras
@ 2022-06-21 11:29 ` Christopher Baines
  2022-06-21 14:02   ` Jose G Perez Taveras
  0 siblings, 1 reply; 5+ messages in thread
From: Christopher Baines @ 2022-06-21 11:29 UTC (permalink / raw)
  To: Jose G Perez Taveras; +Cc: 56111

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]


Jose G Perez Taveras <josegpt27@gmail.com> writes:

> Hello,
>
> Here is an update to playerctl to 2.4.1 and fixed dependencies.
> It uses `dbus-launch' to start a new daemon.
>
> This is my first time sending a patch, I would be very happy if you
> could point me out to anything I should know.

Hi Jose,

Thanks for the patch.

> +    (propagated-inputs (list dbus))

The addition of dbus as a propagated input was the only thing that stood
out to me.

If playerctl does call out to dbus-launch, then patching the source to
refer to the specific /gnu/store/...-dbus/.../dbus-launch binary would
be the nicest approach, since that would avoid propagating dbus.

Is it necessary to propagate the dbus package, and if so, what doesn't
work if you don't?

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#56111] [PATCH] gnu: playerctl: update to 2.4.1.
  2022-06-21 11:29 ` Christopher Baines
@ 2022-06-21 14:02   ` Jose G Perez Taveras
  2022-06-28 13:19     ` Jose G Perez Taveras
  0 siblings, 1 reply; 5+ messages in thread
From: Jose G Perez Taveras @ 2022-06-21 14:02 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 56111

Christopher Baines <mail@cbaines.net> writes:

> [[PGP Signed Part:Undecided]]
>
> Jose G Perez Taveras <josegpt27@gmail.com> writes:
>
>> Hello,
>>
>> Here is an update to playerctl to 2.4.1 and fixed dependencies.
>> It uses `dbus-launch' to start a new daemon.
>>
>> This is my first time sending a patch, I would be very happy if you
>> could point me out to anything I should know.
>
> Hi Jose,
>
> Thanks for the patch.
>
>> +    (propagated-inputs (list dbus))
>
> The addition of dbus as a propagated input was the only thing that stood
> out to me.
>
> If playerctl does call out to dbus-launch, then patching the source to
> refer to the specific /gnu/store/...-dbus/.../dbus-launch binary would
> be the nicest approach, since that would avoid propagating dbus.
>
> Is it necessary to propagate the dbus package, and if so, what doesn't
> work if you don't?
>
> Thanks,
>
> Chris
>
> [[End of PGP Signed Part]]

Hello Christopher,

I kept on testing the patch. As you mentioned, propagating dbus is not
necessary for the package to work correctly.

Thank you for the feedback.

Best,
josegpt

Here's an updated version of the patch.

---
 gnu/packages/music.scm | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 60cb176320..2d0d582e6c 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -48,6 +48,7 @@
 ;;; Copyright © 2022 Remco van 't Veer <remco@remworks.net>
 ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;; Copyright © 2022 Wamm K. D. <jaft.r@outlook.com>
+;;; Copyright © 2022 Jose G Perez Taveras <josegpt27@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5562,7 +5563,7 @@ (define-public pragha
 (define-public playerctl
   (package
     (name "playerctl")
-    (version "2.2.1")
+    (version "2.4.1")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -5571,14 +5572,14 @@ (define-public playerctl
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "17hi33sw3663qz5v54bqqil31sgkrlxkb2l5bgqk87pac6x2wnbz"))))
+                "0ij065blj3h5v6iivvpmgh1095vicj1nc7hp1nhlhpqagd98l89s"))))
     (build-system meson-build-system)
     (arguments
-     `(#:configure-flags '("-Dintrospection=false" "-Dgtk-doc=false")))
-    (inputs (list python-pygobject))
+     `(#:configure-flags '("-Dgtk-doc=false")))
     (native-inputs
      `(("glib:bin" ,glib "bin")
-       ("pkg-config" ,pkg-config)))
+       ("pkg-config" ,pkg-config)
+       ("gobject-introspection" ,gobject-introspection)))
     (synopsis "Control MPRIS-supporting media player applications")
     (description
      "Playerctl is a command-line utility and library for controlling media

base-commit: d13ffd1580ec2253b6e05fb6300c3629aee893e3
-- 
2.36.1




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#56111] [PATCH] gnu: playerctl: update to 2.4.1.
  2022-06-21 14:02   ` Jose G Perez Taveras
@ 2022-06-28 13:19     ` Jose G Perez Taveras
  2022-06-28 22:03       ` bug#56111: " Christopher Baines
  0 siblings, 1 reply; 5+ messages in thread
From: Jose G Perez Taveras @ 2022-06-28 13:19 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 56111

Hello,

I would like to know if there are any updates in regards to this patch?

-- 
Best,

josegpt

Jose G Perez Taveras <josegpt27@gmail.com> writes:

> Christopher Baines <mail@cbaines.net> writes:
>
>> [[PGP Signed Part:Undecided]]
>>
>> Jose G Perez Taveras <josegpt27@gmail.com> writes:
>>
>>> Hello,
>>>
>>> Here is an update to playerctl to 2.4.1 and fixed dependencies.
>>> It uses `dbus-launch' to start a new daemon.
>>>
>>> This is my first time sending a patch, I would be very happy if you
>>> could point me out to anything I should know.
>>
>> Hi Jose,
>>
>> Thanks for the patch.
>>
>>> +    (propagated-inputs (list dbus))
>>
>> The addition of dbus as a propagated input was the only thing that stood
>> out to me.
>>
>> If playerctl does call out to dbus-launch, then patching the source to
>> refer to the specific /gnu/store/...-dbus/.../dbus-launch binary would
>> be the nicest approach, since that would avoid propagating dbus.
>>
>> Is it necessary to propagate the dbus package, and if so, what doesn't
>> work if you don't?
>>
>> Thanks,
>>
>> Chris
>>
>> [[End of PGP Signed Part]]
>
> Hello Christopher,
>
> I kept on testing the patch. As you mentioned, propagating dbus is not
> necessary for the package to work correctly.
>
> Thank you for the feedback.
>
> Best,
> josegpt
>
> Here's an updated version of the patch.
>
> ---
>  gnu/packages/music.scm | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 60cb176320..2d0d582e6c 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -48,6 +48,7 @@
>  ;;; Copyright © 2022 Remco van 't Veer <remco@remworks.net>
>  ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
>  ;;; Copyright © 2022 Wamm K. D. <jaft.r@outlook.com>
> +;;; Copyright © 2022 Jose G Perez Taveras <josegpt27@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -5562,7 +5563,7 @@ (define-public pragha
>  (define-public playerctl
>    (package
>      (name "playerctl")
> -    (version "2.2.1")
> +    (version "2.4.1")
>      (source (origin
>                (method git-fetch)
>                (uri (git-reference
> @@ -5571,14 +5572,14 @@ (define-public playerctl
>                (file-name (git-file-name name version))
>                (sha256
>                 (base32
> -                "17hi33sw3663qz5v54bqqil31sgkrlxkb2l5bgqk87pac6x2wnbz"))))
> +                "0ij065blj3h5v6iivvpmgh1095vicj1nc7hp1nhlhpqagd98l89s"))))
>      (build-system meson-build-system)
>      (arguments
> -     `(#:configure-flags '("-Dintrospection=false" "-Dgtk-doc=false")))
> -    (inputs (list python-pygobject))
> +     `(#:configure-flags '("-Dgtk-doc=false")))
>      (native-inputs
>       `(("glib:bin" ,glib "bin")
> -       ("pkg-config" ,pkg-config)))
> +       ("pkg-config" ,pkg-config)
> +       ("gobject-introspection" ,gobject-introspection)))
>      (synopsis "Control MPRIS-supporting media player applications")
>      (description
>       "Playerctl is a command-line utility and library for controlling media
>
> base-commit: d13ffd1580ec2253b6e05fb6300c3629aee893e3
> -- 
> 2.36.1




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#56111: [PATCH] gnu: playerctl: update to 2.4.1.
  2022-06-28 13:19     ` Jose G Perez Taveras
@ 2022-06-28 22:03       ` Christopher Baines
  0 siblings, 0 replies; 5+ messages in thread
From: Christopher Baines @ 2022-06-28 22:03 UTC (permalink / raw)
  To: Jose G Perez Taveras; +Cc: 56111-done

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]


Jose G Perez Taveras <josegpt27@gmail.com> writes:

> Hello,
>
> I would like to know if there are any updates in regards to this patch?

I've gone ahead and pushed the updated patch as
aa565e7a10a3d8690a4296f8edf12abaa3c215c5.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-06-28 22:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-20 17:05 [bug#56111] [PATCH] gnu: playerctl: update to 2.4.1 Jose G Perez Taveras
2022-06-21 11:29 ` Christopher Baines
2022-06-21 14:02   ` Jose G Perez Taveras
2022-06-28 13:19     ` Jose G Perez Taveras
2022-06-28 22:03       ` bug#56111: " Christopher Baines

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).