From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UGWpHlessWI2JAAAbAwnHQ (envelope-from ) for ; Tue, 21 Jun 2022 13:32:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id UJugHlessWLx0gAA9RJhRA (envelope-from ) for ; Tue, 21 Jun 2022 13:32:39 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 129BDA98D for ; Tue, 21 Jun 2022 13:32:39 +0200 (CEST) Received: from localhost ([::1]:40342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3c7Z-0002Gy-SF for larch@yhetil.org; Tue, 21 Jun 2022 07:32:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3c70-0002GD-RV for guix-patches@gnu.org; Tue, 21 Jun 2022 07:32:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37133) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3c70-0008CT-JP for guix-patches@gnu.org; Tue, 21 Jun 2022 07:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o3c70-0007i3-G0 for guix-patches@gnu.org; Tue, 21 Jun 2022 07:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56111] [PATCH] gnu: playerctl: update to 2.4.1. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Jun 2022 11:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56111 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jose G Perez Taveras Cc: 56111@debbugs.gnu.org X-Debbugs-Original-Cc: 56111@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by 56111-submit@debbugs.gnu.org id=B56111.165581111529267 (code B ref 56111); Tue, 21 Jun 2022 11:32:02 +0000 Received: (at 56111) by debbugs.gnu.org; 21 Jun 2022 11:31:55 +0000 Received: from localhost ([127.0.0.1]:59259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3c6t-0007bj-0k for submit@debbugs.gnu.org; Tue, 21 Jun 2022 07:31:55 -0400 Received: from mira.cbaines.net ([212.71.252.8]:41318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3c6r-0007Zl-1t for 56111@debbugs.gnu.org; Tue, 21 Jun 2022 07:31:53 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 06FD027BBE9; Tue, 21 Jun 2022 12:31:52 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 2cfa5746; Tue, 21 Jun 2022 11:31:51 +0000 (UTC) References: <20220620170517.18322-1-josegpt27@gmail.com> User-agent: mu4e 1.6.10; emacs 28.1 From: Christopher Baines Date: Tue, 21 Jun 2022 12:29:19 +0100 In-reply-to: <20220620170517.18322-1-josegpt27@gmail.com> Message-ID: <87v8su1cd4.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655811159; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=gOYyh50QYDZ/1Ru9I/tEbUssE5drJGR5NfZ/dZ3vZe0=; b=iLy2/JCtSR8MvWvZ6mOU8i3+xVo1S7YdezPu30SXrwNPcxZJIypmm91hBo5D4ScueyPH0k LgtZIXSot3G/EsE7Gl6GMCobv52CHegyi13qJmbpdIIzT+gNBzE6ViynmnREJdn0W6F5Z5 ghQhMQFNY9CLEAQA6O3C5eBWm3yyTi3R20DC4qcR8egpEBUAGMhy+IQHFgEswCCIy0JLae cCb7jEY3Sgz6I2r+vZ96+sfOLu0nSQSSxzf902dFVoQQcZxAusaldmmSCM/5zD2HFDxTZt 5PGZ9U4U0G4SUN9CQnKXp50kA3XuH8jfSbVPwfJOlwLzVV9JfJulXolUk2Uc7g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655811159; a=rsa-sha256; cv=none; b=IVhu9daVI9+ZDCtJlCu7db6uI86hhVClqFGgusu3sTChW/FpJnvO4n+c0qX7zH7pJyX4ii Rh6qBybTc6+uAAiK6UtXrRMMu/6fWm6VBD2ZVmDkPxZvx8JcTTKfBLFVVnsEihde1KZYNn 2RL/C3zORCc4SL6sGIoq1KLWK26ZfpsXJMOK06mpuyI7pLsEKtcHSClLJGyLDQ2bclUeBf OxLUgjjAM44Y+rsqkohw2GzPQewhpkZA4Pvillm07uIDnLKj3C4b5INMbZoc9AJGf+ExJA TqRqXfdmIC9bRQ7Gs1wlfJwvkVrWbSGvei5Wct+oinzbqPxsglVGRi2LsnhuKQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.07 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 129BDA98D X-Spam-Score: -6.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: bO0LpltEWi6b --=-=-= Content-Type: text/plain Jose G Perez Taveras writes: > Hello, > > Here is an update to playerctl to 2.4.1 and fixed dependencies. > It uses `dbus-launch' to start a new daemon. > > This is my first time sending a patch, I would be very happy if you > could point me out to anything I should know. Hi Jose, Thanks for the patch. > + (propagated-inputs (list dbus)) The addition of dbus as a propagated input was the only thing that stood out to me. If playerctl does call out to dbus-launch, then patching the source to refer to the specific /gnu/store/...-dbus/.../dbus-launch binary would be the nicest approach, since that would avoid propagating dbus. Is it necessary to propagate the dbus package, and if so, what doesn't work if you don't? Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmKxrCdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xeo4xAAl744k19cl/7DYycLOQ5O5fPbGb5duDU7 LksXyKyFHQ8BtJpVOLd1nk0Bkfi56mHgMUdMl5ruhuzlAtvr+/zakiP1Bky5URvo 9+zdDI5XNyDd9Ty9d69x+0bv6HjvResVQ5ETG1wABPjgZOg84Mhcd5209fPhkXKK je7loIfyMbF1wElcUi7JkhSkJYZaaG+zSL3e46G6yc1WTHbg0Qwt0WqliFBkM1rz XEuzBCsLZxi8njlHp88F2QKLVvnyy2NQFpcIY6rSVpEwtPQ8AmOyBsZjhP4gabDz A7SBzAUMiY6AX/ktuzwqdVkRe7ZvmC+iZg86vUwr0peqzteyjgYTNHF1qTnCI+SV +UCRGsglS8dtR5zo4O9x50K92VVql9706/7ScCp89P5nsxiQDxCnZ/qsvTbFm3eH bMBBCZmZeLXqbCmnXt/9QU5RsLZfBEjzLLriCLhgrss0ToKPBI0g9zesEE4ZozmV d65uLM3Cq/arhVpE2+hDKspssfqFc9T7eWFQLpEqEujggeQpMi5GAOlQ4XxXlOgh Egw4w3Sh092QxLW//kpnegA0FK6/DLwOjKATvpJi7WZhgtCxOEzfjE7gzEr3JdHv Xh1ye+7DM78n+AWw5eeRXzFDyz0Qq7i1k/88qiKJCYg+/1JXlyK1eOtCNnAT/mzm n61CtttXTN4= =jVoT -----END PGP SIGNATURE----- --=-=-=--