unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Jose G Perez Taveras <josegpt27@gmail.com>
Cc: 56111@debbugs.gnu.org
Subject: [bug#56111] [PATCH] gnu: playerctl: update to 2.4.1.
Date: Tue, 21 Jun 2022 12:29:19 +0100	[thread overview]
Message-ID: <87v8su1cd4.fsf@cbaines.net> (raw)
In-Reply-To: <20220620170517.18322-1-josegpt27@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]


Jose G Perez Taveras <josegpt27@gmail.com> writes:

> Hello,
>
> Here is an update to playerctl to 2.4.1 and fixed dependencies.
> It uses `dbus-launch' to start a new daemon.
>
> This is my first time sending a patch, I would be very happy if you
> could point me out to anything I should know.

Hi Jose,

Thanks for the patch.

> +    (propagated-inputs (list dbus))

The addition of dbus as a propagated input was the only thing that stood
out to me.

If playerctl does call out to dbus-launch, then patching the source to
refer to the specific /gnu/store/...-dbus/.../dbus-launch binary would
be the nicest approach, since that would avoid propagating dbus.

Is it necessary to propagate the dbus package, and if so, what doesn't
work if you don't?

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

  reply	other threads:[~2022-06-21 11:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20 17:05 [bug#56111] [PATCH] gnu: playerctl: update to 2.4.1 Jose G Perez Taveras
2022-06-21 11:29 ` Christopher Baines [this message]
2022-06-21 14:02   ` Jose G Perez Taveras
2022-06-28 13:19     ` Jose G Perez Taveras
2022-06-28 22:03       ` bug#56111: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8su1cd4.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=56111@debbugs.gnu.org \
    --cc=josegpt27@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).