From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UAUjNw8Du2KqYQAAbAwnHQ (envelope-from ) for ; Tue, 28 Jun 2022 15:33:04 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 8EUMNg8Du2LlXwEAG6o9tA (envelope-from ) for ; Tue, 28 Jun 2022 15:33:03 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 756BF2BDB4 for ; Tue, 28 Jun 2022 15:33:03 +0200 (CEST) Received: from localhost ([::1]:46478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6BKw-0005CW-DC for larch@yhetil.org; Tue, 28 Jun 2022 09:33:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6B8O-0002UE-5r for guix-patches@gnu.org; Tue, 28 Jun 2022 09:20:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60386) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6B8N-0001O2-1e for guix-patches@gnu.org; Tue, 28 Jun 2022 09:20:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o6B8M-000643-NV for guix-patches@gnu.org; Tue, 28 Jun 2022 09:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56111] [PATCH] gnu: playerctl: update to 2.4.1. Resent-From: Jose G Perez Taveras Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Jun 2022 13:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56111 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 56111@debbugs.gnu.org X-Debbugs-Original-Cc: 56111@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by 56111-submit@debbugs.gnu.org id=B56111.165642239823290 (code B ref 56111); Tue, 28 Jun 2022 13:20:02 +0000 Received: (at 56111) by debbugs.gnu.org; 28 Jun 2022 13:19:58 +0000 Received: from localhost ([127.0.0.1]:54282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6B8I-00063T-EK for submit@debbugs.gnu.org; Tue, 28 Jun 2022 09:19:58 -0400 Received: from mail-qv1-f53.google.com ([209.85.219.53]:40743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o6B8F-000638-8g for 56111@debbugs.gnu.org; Tue, 28 Jun 2022 09:19:56 -0400 Received: by mail-qv1-f53.google.com with SMTP id cu16so19872104qvb.7 for <56111@debbugs.gnu.org>; Tue, 28 Jun 2022 06:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=IfBepAwipgdxdVwfo2rouhapsqTDKo2hpqAqmnlqUQY=; b=asl1qxxMEbkxaZKCBFx6poa3ArKIWqOV+1B2z/bkBPhsMcjJuLCoN+FX9mHdKEwFHA kQ15b8EoqN3IgqGKhU3mvjJm3v2EJvu8uAIxSlG5l2qxjKlOoORI/4yGksOLm5qT8VGM lEJVcC2rV//je2J30zgwD/yuXOyMtz9y19ovUnLWNC1hIyOHVdeFGSoCyZBkWqzc1VqD aqwPZuUYaY8wbdHmKfFAnb8CfO70cEE4IqdOOlMAVp7DX3+T4jEv2kErnTmiphtCeEzY BAkruhDLQ1NSjdmuz6VZFmqJ10I2579GJaRmn/RwgezZm/V24XunGCPcFLKsc5M7jcG9 a4AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=IfBepAwipgdxdVwfo2rouhapsqTDKo2hpqAqmnlqUQY=; b=vS/AwrqyQ256vlp0pTX2wJiipESaIqRhgwGWUY8bmQhfB4fVH9gnMCvJje3IuPYqjQ 4Oj+ajfdia7j/ZAe3vLXoh8I5rNoWczwjbE1cb2FM8Lr9UtgPBqsd/n05y3RbWjU1nk7 fT0SgH/vmEbTyWpipqYOaV5Z83/ftLiC6xiQnqpCd2ViC2Uu14V+51Qvp5yqc0OnCHCO JB/eOtNPmrZpFm27dSLGj8lt4PYYAx1wgYiVdQXQp3tdgcN2OXTHeYudYz2Q8E6hiS9I /c4pfoDtxaBc4UZcNWS7Cfi6p7J8CjFNB49+XdHYQ2NC8F8I5LrPcwxzkr2Smp/KLoUv dtwA== X-Gm-Message-State: AJIora+Ak5kehiDFduJvsE736sNzjreroh2ROMCMXahZ23jWVkJWJ208 t88GgYNQbo3ICsNRGrlBUP4= X-Google-Smtp-Source: AGRyM1stz3yjpeK8u3QL469jLBzHkqyTAIr1tkJgqU9JiR97ZZcmkS/LZ6iRqmNcaIQAC0DvqhP9DA== X-Received: by 2002:ac8:7d49:0:b0:304:e4ce:3345 with SMTP id h9-20020ac87d49000000b00304e4ce3345mr13002468qtb.508.1656422389583; Tue, 28 Jun 2022 06:19:49 -0700 (PDT) Received: from lizard-priest (pool-72-76-213-26.nwrknj.fios.verizon.net. [72.76.213.26]) by smtp.gmail.com with ESMTPSA id j12-20020ac874cc000000b00304e29c9a6asm8603887qtr.91.2022.06.28.06.19.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 06:19:49 -0700 (PDT) From: Jose G Perez Taveras In-Reply-To: <87h74ep06p.fsf@gmail.com> References: <20220620170517.18322-1-josegpt27@gmail.com> <87v8su1cd4.fsf@cbaines.net> <87h74ep06p.fsf@gmail.com> Date: Tue, 28 Jun 2022 09:19:41 -0400 Message-ID: <878rphsz6a.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656423183; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=IfBepAwipgdxdVwfo2rouhapsqTDKo2hpqAqmnlqUQY=; b=hQry9Jsryc+1+vciy1sK/soB/xHIkScqYaeEO4Ra3E/Im68+oXWqEkXOzPMcMrbRZtF0Mk tU8DUvij2hpPZTHrywc+TkFrUf/HCeXm2pTqKbqNocGQz/kCXjikeD0dNOXAIFaRaYOVDl xCAn0ndxM68WWXY2ag0WI5wM2elsd2CNawh6ySqkP9yhgTrn8+iiN0mwYFw1M9MT0l8wX/ 9VGU4ZSehiFGaHs2htUm5kNOwaERGGG4H+LiAa0T1M/oOdhrg+ZGnuUTgOtZHpYoRlp/6q xD6VE+jVZ3rL/4p+avcrG665VYE3dp/TeygEs9BDxeFqePBgIQy1ttRAup/45g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656423183; a=rsa-sha256; cv=none; b=d/+q1V4H94Dmni2Cr7W+oEsX6pdGvL9X2neSbgonAT9lPazHnjbhXq31fWY/tbKP5cOMDf AoV+jSnFS3oT+QQxbESClxBLjwHpCIrHMRwY+Zz2sohITjCjpKHHPZS0+gMYy6/Em7zx3N Gu2BvVoAUUGFNKbSGiUuf32ABXhB713fiWkdlLBx1aS0hrQrvsxTIRlkt3fnW0wnY26+Dc 2GuRtkuhEap7SuRLy5UKFGuAaEjRXvaelvzk1lrp5hMgjd6ob+IP1hBWw2n6ZFCyJIvHqw 7yXNRd4LkZ9iRvtUFbIz6cnxyobBBmr+wrWK/l7rVVcsVcZCTx8A2T8/eqEunA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=asl1qxxM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.55 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=asl1qxxM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 756BF2BDB4 X-Spam-Score: 5.55 X-Migadu-Scanner: scn0.migadu.com X-TUID: KX3dZbiXOTpx Hello, I would like to know if there are any updates in regards to this patch? --=20 Best, josegpt Jose G Perez Taveras writes: > Christopher Baines writes: > >> [[PGP Signed Part:Undecided]] >> >> Jose G Perez Taveras writes: >> >>> Hello, >>> >>> Here is an update to playerctl to 2.4.1 and fixed dependencies. >>> It uses `dbus-launch' to start a new daemon. >>> >>> This is my first time sending a patch, I would be very happy if you >>> could point me out to anything I should know. >> >> Hi Jose, >> >> Thanks for the patch. >> >>> + (propagated-inputs (list dbus)) >> >> The addition of dbus as a propagated input was the only thing that stood >> out to me. >> >> If playerctl does call out to dbus-launch, then patching the source to >> refer to the specific /gnu/store/...-dbus/.../dbus-launch binary would >> be the nicest approach, since that would avoid propagating dbus. >> >> Is it necessary to propagate the dbus package, and if so, what doesn't >> work if you don't? >> >> Thanks, >> >> Chris >> >> [[End of PGP Signed Part]] > > Hello Christopher, > > I kept on testing the patch. As you mentioned, propagating dbus is not > necessary for the package to work correctly. > > Thank you for the feedback. > > Best, > josegpt > > Here's an updated version of the patch. > > --- > gnu/packages/music.scm | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm > index 60cb176320..2d0d582e6c 100644 > --- a/gnu/packages/music.scm > +++ b/gnu/packages/music.scm > @@ -48,6 +48,7 @@ > ;;; Copyright =C2=A9 2022 Remco van 't Veer > ;;; Copyright =C2=A9 2022 Maxim Cournoyer > ;;; Copyright =C2=A9 2022 Wamm K. D. > +;;; Copyright =C2=A9 2022 Jose G Perez Taveras > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -5562,7 +5563,7 @@ (define-public pragha > (define-public playerctl > (package > (name "playerctl") > - (version "2.2.1") > + (version "2.4.1") > (source (origin > (method git-fetch) > (uri (git-reference > @@ -5571,14 +5572,14 @@ (define-public playerctl > (file-name (git-file-name name version)) > (sha256 > (base32 > - "17hi33sw3663qz5v54bqqil31sgkrlxkb2l5bgqk87pac6x2wnbz"))= )) > + "0ij065blj3h5v6iivvpmgh1095vicj1nc7hp1nhlhpqagd98l89s"))= )) > (build-system meson-build-system) > (arguments > - `(#:configure-flags '("-Dintrospection=3Dfalse" "-Dgtk-doc=3Dfalse"= ))) > - (inputs (list python-pygobject)) > + `(#:configure-flags '("-Dgtk-doc=3Dfalse"))) > (native-inputs > `(("glib:bin" ,glib "bin") > - ("pkg-config" ,pkg-config))) > + ("pkg-config" ,pkg-config) > + ("gobject-introspection" ,gobject-introspection))) > (synopsis "Control MPRIS-supporting media player applications") > (description > "Playerctl is a command-line utility and library for controlling me= dia > > base-commit: d13ffd1580ec2253b6e05fb6300c3629aee893e3 > --=20 > 2.36.1