unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Stefan <stefan-guix@vodafonemail.de>
Cc: 45225@debbugs.gnu.org
Subject: [bug#45225] [PATCH] gnu: grub: Fix unicode font loading when booting over TFTP.
Date: Mon, 21 Dec 2020 15:50:45 +0100	[thread overview]
Message-ID: <87blen6wmy.fsf@gnu.org> (raw)
In-Reply-To: <5BC2CE26-5F2D-4250-A9E5-D04BB85DD942@vodafonemail.de> (Stefan's message of "Sat, 19 Dec 2020 21:29:58 +0100")

Hi Stefan,

Stefan <stefan-guix@vodafonemail.de> skribis:

> This patch got pushed and later reverted, as it is causing issues, because /gnu/store…-grub…/share/grub/unicode.pf2 is sometimes not visible when building the grub.cfg file.

Yeah, I wanted to send you a heads-up and then I forgot, apologies!

In general, my suggestion when fiddling with these things is to at least
run:

  make check-system TESTS=basic

This one builds and runs quickly and catches the most obvious issues, as
in this case.

Then, when fiddling with the bootloader, file systems, and that kind of
stuff, it’s a good idea to run an installation test, as in:

  make check-system TESTS=installed-os

This is more expensive to build (it first has to build ‘guix’, then an
ISO image, and then run the installation), but it’s a good idea when
low-level things are modified.  See:

  https://guix.gnu.org/manual/en/html_node/Running-the-Test-Suite.html

I’m not sure I understand what this change meant to fix though.  What
was the initial problem that led to the addition of this
‘canonicalize-path’ call?

Thanks,
Ludo’.




  reply	other threads:[~2020-12-21 15:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-13 17:25 [bug#45225] [PATCH] gnu: grub: Fix unicode font loading when booting over TFTP Stefan
2020-12-14 22:35 ` bug#45225: " Danny Milosavljevic
2020-12-19 20:29 ` [bug#45225] " Stefan
2020-12-21 14:50   ` Ludovic Courtès [this message]
2020-12-21 17:03     ` Stefan
2020-12-22 13:38       ` Ludovic Courtès
2020-12-22 15:21         ` Stefan
2021-01-17 15:51           ` Danny Milosavljevic
2021-01-17 15:57             ` Stefan
2020-12-28 11:24         ` [bug#45225] [PATCH] gnu: grub: Use installed unicode font, fix " Stefan
2021-01-07 16:37           ` Stefan
2021-01-17 14:13             ` Stefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blen6wmy.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=45225@debbugs.gnu.org \
    --cc=stefan-guix@vodafonemail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).