From: Stefan <stefan-guix@vodafonemail.de>
To: 45225@debbugs.gnu.org, dannym@scratchpost.org
Subject: [bug#45225] [PATCH] gnu: grub: Fix unicode font loading when booting over TFTP.
Date: Sun, 13 Dec 2020 18:25:24 +0100 [thread overview]
Message-ID: <C6806B63-5919-41C9-B80D-6F6827061598@vodafonemail.de> (raw)
* gnu/bootloader/grub.scm (font-file): Using (canonicalize-path), as symlinks
from a bootloader profile do not work on a tftp server when network booting.
---
gnu/bootloader/grub.scm | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm
index af7b7561ff..3177452dfb 100644
--- a/gnu/bootloader/grub.scm
+++ b/gnu/bootloader/grub.scm
@@ -191,9 +191,18 @@ fi~%"
(define font-file
(let* ((bootloader (bootloader-configuration-bootloader config))
(grub (bootloader-package bootloader)))
- (normalize-file (file-append grub "/share/grub/unicode.pf2")
- store-mount-point
- store-directory-prefix)))
+ ;; The bootloader-package may be a profile with only symlinks.
+ ;; If network booting, then a symlink to the font may not work on the
+ ;; server side. Therefore we canonicalize the file name of the font.
+ ;; TODO: The font gets installed by (install-grub-efi-netboot) and
+ ;; (install-grub-efi). The installed font could be referred to as
+ ;; "unicode". But it is currently unclear if (install-grub-disk-image)
+ ;; and (install-grub) both install the font as well.
+ ;; Actually this should be preferred.
+ #~(canonicalize-path
+ #+(normalize-file (file-append grub "/share/grub/unicode.pf2")
+ store-mount-point
+ store-directory-prefix))))
(define image
(normalize-file (grub-background-image config)
--
2.29.2
next reply other threads:[~2020-12-13 17:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-13 17:25 Stefan [this message]
2020-12-14 22:35 ` bug#45225: [PATCH] gnu: grub: Fix unicode font loading when booting over TFTP Danny Milosavljevic
2020-12-19 20:29 ` [bug#45225] " Stefan
2020-12-21 14:50 ` Ludovic Courtès
2020-12-21 17:03 ` Stefan
2020-12-22 13:38 ` Ludovic Courtès
2020-12-22 15:21 ` Stefan
2021-01-17 15:51 ` Danny Milosavljevic
2021-01-17 15:57 ` Stefan
2020-12-28 11:24 ` [bug#45225] [PATCH] gnu: grub: Use installed unicode font, fix " Stefan
2021-01-07 16:37 ` Stefan
2021-01-17 14:13 ` Stefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C6806B63-5919-41C9-B80D-6F6827061598@vodafonemail.de \
--to=stefan-guix@vodafonemail.de \
--cc=45225@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).