unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Stefan <stefan-guix@vodafonemail.de>
Cc: 45225-done@debbugs.gnu.org
Subject: bug#45225: [PATCH] gnu: grub: Fix unicode font loading when booting over TFTP.
Date: Mon, 14 Dec 2020 23:35:10 +0100	[thread overview]
Message-ID: <20201214233510.40725a4d@scratchpost.org> (raw)
In-Reply-To: <C6806B63-5919-41C9-B80D-6F6827061598@vodafonemail.de>

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

Hi Stefan,

your patch file arrived mangled in my mailbox.

On Sun, 13 Dec 2020 18:25:24 +0100
Stefan <stefan-guix@vodafonemail.de> wrote:

>diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm
>index af7b7561ff..3177452dfb 100644
>--- a/gnu/bootloader/grub.scm
>+++ b/gnu/bootloader/grub.scm
>@@ -191,9 +191,18 @@ fi~%"
>  (define font-file

For example, the original source file had here two spaces before the "define".
But the Patch format needs one control character in front.

In this case (for the Context mark), the control character should also be a
space.
That means there should be three spaces there.  But there are two spaces there.

It goes on similarly in the entire patch file.

I've fixed it up manually and pushed to guix master--but you might want
to look into why this happens in general before something important gets
mangled.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-12-14 22:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-13 17:25 [bug#45225] [PATCH] gnu: grub: Fix unicode font loading when booting over TFTP Stefan
2020-12-14 22:35 ` Danny Milosavljevic [this message]
2020-12-19 20:29 ` Stefan
2020-12-21 14:50   ` Ludovic Courtès
2020-12-21 17:03     ` Stefan
2020-12-22 13:38       ` Ludovic Courtès
2020-12-22 15:21         ` Stefan
2021-01-17 15:51           ` Danny Milosavljevic
2021-01-17 15:57             ` Stefan
2020-12-28 11:24         ` [bug#45225] [PATCH] gnu: grub: Use installed unicode font, fix " Stefan
2021-01-07 16:37           ` Stefan
2021-01-17 14:13             ` Stefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201214233510.40725a4d@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=45225-done@debbugs.gnu.org \
    --cc=stefan-guix@vodafonemail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).