unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Stefan <stefan-guix@vodafonemail.de>
Cc: 45225@debbugs.gnu.org
Subject: [bug#45225] [PATCH] gnu: grub: Fix unicode font loading when booting over TFTP.
Date: Sun, 17 Jan 2021 16:51:34 +0100	[thread overview]
Message-ID: <20210117165134.59a27e3f@scratchpost.org> (raw)
In-Reply-To: <7BDB1D37-7B0A-41FD-876A-61B60E4DF159@vodafonemail.de>

[-- Attachment #1: Type: text/plain, Size: 1644 bytes --]

Hi Stefan,

On Tue, 22 Dec 2020 16:21:40 +0100
Stefan <stefan-guix@vodafonemail.de> wrote:

> I’m sorry for my nagging, but I’d really like to understand, why the grub package is not always visible in /gnu/store/ when building the grub.cfg file, although it is referred to by a file-append gexp.

I just want to say that I'm not ignoring the question--I honesty don't know.

In any case, until we do know, I've applied your patch
https://issues.guix.gnu.org/issue/45225#7  to guix master as commit
b57056a9fd83c61efb5343853948a798da6e975e--after all, the font was in /boot
for regular Guix Systems anyway, so I don't see a downside loading it from
/boot--especially since it's part of the bootloader anyway, which does not
have different generations for itself.  Also, the code is simpler now.

I also want to note that all 4 hunks in that patch had failed to apply with
git am.  I implore you to please download the patch files from
https://issues.guix.gnu.org/issue/45225#7 using the little blue download arrow
are the top right corner and try to "git am" them yourself.  It won't work
because the spaces in your patch files are mangled.

If it's that way because git send-email doesn't work, I have a block like the
following in ~/.gitconfig--and my patches arrive unmangled that way:

[sendemail]
        from = Example User <user@example.com>
        smtpEncryption = tls
        smtpServer = xxx
        smtpUser = xxx
        smtpPass = xxx
        smtpServerPort = 587

Then you can use

  git format-patch -1 -o ../outgoing-topic1
  git send-email ../outgoing-topic1/0001*

and it will work.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-01-17 15:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-13 17:25 [bug#45225] [PATCH] gnu: grub: Fix unicode font loading when booting over TFTP Stefan
2020-12-14 22:35 ` bug#45225: " Danny Milosavljevic
2020-12-19 20:29 ` [bug#45225] " Stefan
2020-12-21 14:50   ` Ludovic Courtès
2020-12-21 17:03     ` Stefan
2020-12-22 13:38       ` Ludovic Courtès
2020-12-22 15:21         ` Stefan
2021-01-17 15:51           ` Danny Milosavljevic [this message]
2021-01-17 15:57             ` Stefan
2020-12-28 11:24         ` [bug#45225] [PATCH] gnu: grub: Use installed unicode font, fix " Stefan
2021-01-07 16:37           ` Stefan
2021-01-17 14:13             ` Stefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210117165134.59a27e3f@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=45225@debbugs.gnu.org \
    --cc=stefan-guix@vodafonemail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).