From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QPb7Jyy/4F+aFQAA0tVLHw (envelope-from ) for ; Mon, 21 Dec 2020 15:28:44 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WMDIIyy/4F9DRgAAbx9fmQ (envelope-from ) for ; Mon, 21 Dec 2020 15:28:44 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D88C79403A2 for ; Mon, 21 Dec 2020 15:28:43 +0000 (UTC) Received: from localhost ([::1]:39358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krN74-0003Gh-Qe for larch@yhetil.org; Mon, 21 Dec 2020 10:28:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krMWc-0002gU-LB for guix-patches@gnu.org; Mon, 21 Dec 2020 09:51:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35092) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1krMWc-0001T6-6R for guix-patches@gnu.org; Mon, 21 Dec 2020 09:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1krMWc-0002Wu-3s for guix-patches@gnu.org; Mon, 21 Dec 2020 09:51:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45225] [PATCH] gnu: grub: Fix unicode font loading when booting over TFTP. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 21 Dec 2020 14:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45225 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Stefan Received: via spool by 45225-submit@debbugs.gnu.org id=B45225.16085622599707 (code B ref 45225); Mon, 21 Dec 2020 14:51:02 +0000 Received: (at 45225) by debbugs.gnu.org; 21 Dec 2020 14:50:59 +0000 Received: from localhost ([127.0.0.1]:46638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krMWZ-0002WU-Iu for submit@debbugs.gnu.org; Mon, 21 Dec 2020 09:50:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krMWX-0002Vz-D9 for 45225@debbugs.gnu.org; Mon, 21 Dec 2020 09:50:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38678) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krMWQ-0001QO-9v; Mon, 21 Dec 2020 09:50:50 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36948 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1krMWO-00075F-A6; Mon, 21 Dec 2020 09:50:49 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <5BC2CE26-5F2D-4250-A9E5-D04BB85DD942@vodafonemail.de> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 1 =?UTF-8?Q?Niv=C3=B4se?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 21 Dec 2020 15:50:45 +0100 In-Reply-To: <5BC2CE26-5F2D-4250-A9E5-D04BB85DD942@vodafonemail.de> (Stefan's message of "Sat, 19 Dec 2020 21:29:58 +0100") Message-ID: <87blen6wmy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45225@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.82 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D88C79403A2 X-Spam-Score: -2.82 X-Migadu-Scanner: scn1.migadu.com X-TUID: ipUX0alzikGL Hi Stefan, Stefan skribis: > This patch got pushed and later reverted, as it is causing issues, becaus= e /gnu/store=E2=80=A6-grub=E2=80=A6/share/grub/unicode.pf2 is sometimes not= visible when building the grub.cfg file. Yeah, I wanted to send you a heads-up and then I forgot, apologies! In general, my suggestion when fiddling with these things is to at least run: make check-system TESTS=3Dbasic This one builds and runs quickly and catches the most obvious issues, as in this case. Then, when fiddling with the bootloader, file systems, and that kind of stuff, it=E2=80=99s a good idea to run an installation test, as in: make check-system TESTS=3Dinstalled-os This is more expensive to build (it first has to build =E2=80=98guix=E2=80= =99, then an ISO image, and then run the installation), but it=E2=80=99s a good idea when low-level things are modified. See: https://guix.gnu.org/manual/en/html_node/Running-the-Test-Suite.html I=E2=80=99m not sure I understand what this change meant to fix though. Wh= at was the initial problem that led to the addition of this =E2=80=98canonicalize-path=E2=80=99 call? Thanks, Ludo=E2=80=99.