[bug#38842] [PATCH] Update rtl-sdr and add redsea

[bug#38842] [PATCH] Update rtl-sdr and add redsea

[Evan Straw]

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

Greetings, Guix developers!

The following series of patches will:
1. Update rtl-sdr to 0.6.0.
2. Add liquid-dsp (dependency for redsea)
3. Add redsea.

This message is simply a cover letter to start a thread on debbugs, the
messages containing the actual patches will follow shortly.

Happy GNU Year!
-- Evan Straw
evan.straw99@gmail.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#38842] [PATCH 1/3] gnu: rtl-sdr: Update to 0.6.0.

[Evan Straw]

[-- Attachment #1.1: [PATCH 1/3] gnu: rtl-sdr: Update to 0.6.0. --]
[-- Type: text/x-patch, Size: 1578 bytes --]

From 37610c74bf48b0005b002415bf04d425e5509e36 Mon Sep 17 00:00:00 2001
From: Evan Straw <evan.straw99@gmail.com>
Date: Tue, 31 Dec 2019 14:21:52 -0800
Subject: [PATCH 1/3] gnu: rtl-sdr: Update to 0.6.0.

* gnu/packages/ham-radio.scm (rtl-sdr): Update to 0.6.0.
---
 gnu/packages/ham-radio.scm | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/ham-radio.scm b/gnu/packages/ham-radio.scm
index 9f0adca940..e82865f2f5 100644
--- a/gnu/packages/ham-radio.scm
+++ b/gnu/packages/ham-radio.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2017, 2018, 2019 Arun Isaac <arunisaac@systemreboot.net>
+;;; Copyright © 2019 Evan Straw <evan.straw99@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -36,15 +37,17 @@
 (define-public rtl-sdr
   (package
     (name "rtl-sdr")
-    (version "0.5.3")
+    (version "0.6.0")
     (source
      (origin
-       (method url-fetch)
-       (uri (string-append "https://cgit.osmocom.org/rtl-sdr/snapshot/rtl-sdr-"
-                           version ".tar.xz"))
+       (method git-fetch)
+       (uri (git-reference
+		  (url "git://git.osmocom.org/rtl-sdr.git")
+		  (commit version)))
+       (file-name (git-file-name name version))
        (sha256
         (base32
-         "08awca3v28sa4lxym4r81pzf0la0j86wbmpyhv3xd53an9gkpjy9"))))
+         "0lmvsnb4xw4hmz6zs0z5ilsah5hjz29g1s0050n59fllskqr3b8k"))))
     (build-system cmake-build-system)
     (inputs
      `(("libusb" ,libusb)))
-- 
2.20.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#38842] [PATCH 1/3] gnu: rtl-sdr: Update to 0.6.0.

[Ricardo Wurmus]

Evan Straw <evan.straw99@gmail.com> writes:

> From 37610c74bf48b0005b002415bf04d425e5509e36 Mon Sep 17 00:00:00 2001
> From: Evan Straw <evan.straw99@gmail.com>
> Date: Tue, 31 Dec 2019 14:21:52 -0800
> Subject: [PATCH 1/3] gnu: rtl-sdr: Update to 0.6.0.
>
> * gnu/packages/ham-radio.scm (rtl-sdr): Update to 0.6.0.

Thank you, I’ve pushed this to the master branch.

-- 
Ricardo

[bug#38842] [PATCH 2/3] gnu: Add liquid-dsp.

[Evan Straw]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1: [PATCH 2/3] gnu: Add liquid-dsp. --]
[-- Type: text/x-patch, Size: 2562 bytes --]

From 71f377a45bfc830ff207cd56fa2d8fe0225a6874 Mon Sep 17 00:00:00 2001
From: Evan Straw <evan.straw99@gmail.com>
Date: Tue, 31 Dec 2019 15:31:58 -0800
Subject: [PATCH 2/3] gnu: Add liquid-dsp.

* gnu/packages/ham-radio.scm (liquid-dsp): New variable.
---
 gnu/packages/ham-radio.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/ham-radio.scm b/gnu/packages/ham-radio.scm
index e82865f2f5..f327ea22da 100644
--- a/gnu/packages/ham-radio.scm
+++ b/gnu/packages/ham-radio.scm
@@ -22,6 +22,8 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix git-download)
+  #:use-module (gnu packages autotools)
+  #:use-module (gnu packages base)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages image)
   #:use-module (gnu packages libusb)
@@ -127,3 +129,34 @@ satellites, the POES NOAA weather satellite series.  These transmissions are
 on a frequency of 137 MHz.  They can be received using an inexpensive antenna
 and a dedicated receiver.")
     (license license:gpl2+)))
+
+(define-public liquid-dsp
+  (let ((commit "f11733208e3d0da928a0dc2111cdb2b0c4817cef")
+        (revision "2")
+        (version "1.3.2"))
+    (package
+      (name "liquid-dsp")
+      (version (git-version version revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/jgaeddert/liquid-dsp")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "06f8akc88xi6kaa6fx73pfb9fs7x6y7jjwb4vwkzsvsxj20jshki"))))
+      (build-system gnu-build-system)
+      (native-inputs `(("autoconf" ,autoconf)))
+      (home-page "https://liquidsdr.org")
+      (synopsis "Digital signal processing library for software-defined radios")
+      (description "liquid-dsp is a free and open-source digital signal
+processing (DSP) library designed specifically for software-defined radios on
+embedded platforms. The aim is to provide a lightweight DSP library that does
+not rely on a myriad of external dependencies or proprietary and otherwise
+cumbersome frameworks. All signal processing elements are designed to be
+flexible, scalable, and dynamic, including filters, filter design,
+oscillators, modems, synchronizers, complex mathematical operations, and much
+more.")
+      (license license:expat))))
+
-- 
2.20.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#38842] [PATCH 2/3] gnu: Add liquid-dsp.

[Ricardo Wurmus]

Hi Evan,

> From 71f377a45bfc830ff207cd56fa2d8fe0225a6874 Mon Sep 17 00:00:00 2001
> From: Evan Straw <evan.straw99@gmail.com>
> Date: Tue, 31 Dec 2019 15:31:58 -0800
> Subject: [PATCH 2/3] gnu: Add liquid-dsp.
>
> * gnu/packages/ham-radio.scm (liquid-dsp): New variable.

> +(define-public liquid-dsp
> +  (let ((commit "f11733208e3d0da928a0dc2111cdb2b0c4817cef")
> +        (revision "2")
> +        (version "1.3.2"))

Why this commit and not just the latest release 1.3.2?

> +      (description "liquid-dsp is a free and open-source digital signal
> +processing (DSP) library designed specifically for software-defined radios on
> +embedded platforms. The aim is to provide a lightweight DSP library that does
> +not rely on a myriad of external dependencies or proprietary and otherwise
> +cumbersome frameworks. All signal processing elements are designed to be
> +flexible, scalable, and dynamic, including filters, filter design,
> +oscillators, modems, synchronizers, complex mathematical operations, and much
> +more.")

Please remove “free and open-source” — all software in Guix is free
software, so we don’t need to state it.  Please also use double spacing
after each sentence.

--
Ricardo

[bug#38842] [PATCH 2/3] gnu: Add liquid-dsp.

[Evan Straw]

[-- Attachment #1: Type: text/plain, Size: 1805 bytes --]

> Hi Evan,
>
>> From 71f377a45bfc830ff207cd56fa2d8fe0225a6874 Mon Sep 17 00:00:00 2001
>> From: Evan Straw <evan.straw99@gmail.com>
>> Date: Tue, 31 Dec 2019 15:31:58 -0800
>> Subject: [PATCH 2/3] gnu: Add liquid-dsp.
>>
>> * gnu/packages/ham-radio.scm (liquid-dsp): New variable.
>
>> +(define-public liquid-dsp
>> +  (let ((commit "f11733208e3d0da928a0dc2111cdb2b0c4817cef")
>> +        (revision "2")
>> +        (version "1.3.2"))
>
> Why this commit and not just the latest release 1.3.2?

It has been a while since liquid-dsp has had a release, so I was
concerned that the software would be out of date and just chose the
latest commit from their git repository. In hindsight there probably
isn't much cause for concern though so I will change it to just the
latest release.

>
>> +      (description "liquid-dsp is a free and open-source digital signal
>> +processing (DSP) library designed specifically for software-defined radios on
>> +embedded platforms. The aim is to provide a lightweight DSP library that does
>> +not rely on a myriad of external dependencies or proprietary and otherwise
>> +cumbersome frameworks. All signal processing elements are designed to be
>> +flexible, scalable, and dynamic, including filters, filter design,
>> +oscillators, modems, synchronizers, complex mathematical operations, and much
>> +more.")
>
> Please remove “free and open-source” — all software in Guix is free
> software, so we don’t need to state it.  Please also use double spacing
> after each sentence.
>

This description was basically just taken from the project's GitHub
page. My apologies, should have checked over it more. I'll change that
too.

Thanks for pointing these things out. I'll send a revision through shortly.

-- Evan Straw

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#38842] [PATCH 3/3] gnu: Add redsea.

[Evan Straw]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1: [PATCH 3/3] gnu: Add redsea. --]
[-- Type: text/x-patch, Size: 2904 bytes --]

From f19dfe6652727f074b0aa335b43c52bb482116b2 Mon Sep 17 00:00:00 2001
From: Evan Straw <evan.straw99@gmail.com>
Date: Tue, 31 Dec 2019 19:04:37 -0800
Subject: [PATCH 3/3] gnu: Add redsea.

* gnu/packages/ham-radio.scm (redsea): New variable.
---
 gnu/packages/ham-radio.scm | 43 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/ham-radio.scm b/gnu/packages/ham-radio.scm
index f327ea22da..5c1e17ac47 100644
--- a/gnu/packages/ham-radio.scm
+++ b/gnu/packages/ham-radio.scm
@@ -20,6 +20,7 @@
 (define-module (gnu packages ham-radio)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
+  #:use-module (guix utils)
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (gnu packages autotools)
@@ -160,3 +161,45 @@ oscillators, modems, synchronizers, complex mathematical operations, and much
 more.")
       (license license:expat))))
 
+(define-public redsea
+  (package
+    (name "redsea")
+    (version "0.18")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/windytan/redsea")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1y96g0ra2krjb2kypm8s5gdfia45yci4f36klsvyzg8d53v5cwhn"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         ;; The configure.ac file does not explicitly link against libiconv
+         ;; except on Mac OS, causing the build to fail. This phase comments
+         ;; out the original AC_SUBST macro (located inside a conditional) and
+         ;; adds an explicit use of it underneath, so that libiconv is always
+         ;; linked against.
+         (add-after 'unpack 'patch-libiconv
+           (lambda _
+             (substitute* "configure.ac"
+               (("^ +AC_SUBST")
+                "# AC_SUBST")
+               (("esac")
+                "esac\nAC_SUBST([ICONV], [\"-liconv\"])")))))))
+    (inputs `(("libiconv" ,libiconv)
+              ("libsndfile" ,libsndfile)
+              ("liquid-dsp" ,liquid-dsp)))
+    (native-inputs `(("autoconf" ,autoconf)
+                     ("automake" ,automake)))
+    (home-page "https://github.com/windytan/redsea")
+    (synopsis "A lightweight RDS to JSON decoder")
+    (description "redsea is a lightweight command-line FM-RDS decoder for
+GNU/Linux. Redsea can be used with any RTL-SDR USB radio stick with the rtl_fm
+tool, or any other SDR via csdr, for example. It can also decode raw ASCII
+bitstream, the hex format used by RDS Spy, and audio files containing
+multiplex signals (MPX).")
+    (license license:expat)))
-- 
2.20.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#38842] [PATCH 3/3] gnu: Add redsea.

[Ricardo Wurmus]

Hi Evan,

> From f19dfe6652727f074b0aa335b43c52bb482116b2 Mon Sep 17 00:00:00 2001
> From: Evan Straw <evan.straw99@gmail.com>
> Date: Tue, 31 Dec 2019 19:04:37 -0800
> Subject: [PATCH 3/3] gnu: Add redsea.
>
> * gnu/packages/ham-radio.scm (redsea): New variable.
> ---
>  gnu/packages/ham-radio.scm | 43 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>
> diff --git a/gnu/packages/ham-radio.scm b/gnu/packages/ham-radio.scm
> index f327ea22da..5c1e17ac47 100644
> --- a/gnu/packages/ham-radio.scm
> +++ b/gnu/packages/ham-radio.scm
> @@ -20,6 +20,7 @@
>  (define-module (gnu packages ham-radio)
>    #:use-module ((guix licenses) #:prefix license:)
>    #:use-module (guix packages)
> +  #:use-module (guix utils)

Why is this needed?

> +(define-public redsea
> +  (package
> +    (name "redsea")
> +    (version "0.18")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/windytan/redsea")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1y96g0ra2krjb2kypm8s5gdfia45yci4f36klsvyzg8d53v5cwhn"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         ;; The configure.ac file does not explicitly link against libiconv
> +         ;; except on Mac OS, causing the build to fail. This phase comments
> +         ;; out the original AC_SUBST macro (located inside a conditional) and
> +         ;; adds an explicit use of it underneath, so that libiconv is always
> +         ;; linked against.
> +         (add-after 'unpack 'patch-libiconv
> +           (lambda _
> +             (substitute* "configure.ac"
> +               (("^ +AC_SUBST")
> +                "# AC_SUBST")
> +               (("esac")
> +                "esac\nAC_SUBST([ICONV], [\"-liconv\"])")))))))

Please end all phases on #t (or #true).

> +    (inputs `(("libiconv" ,libiconv)
> +              ("libsndfile" ,libsndfile)
> +              ("liquid-dsp" ,liquid-dsp)))
> +    (native-inputs `(("autoconf" ,autoconf)
> +                     ("automake" ,automake)))

I suggest putting the lists on a new line.

> +    (home-page "https://github.com/windytan/redsea")
> +    (synopsis "A lightweight RDS to JSON decoder")

Please remove the leading “A”.  (guix lint should complain about this.)

> +    (description "redsea is a lightweight command-line FM-RDS decoder for
> +GNU/Linux. Redsea can be used with any RTL-SDR USB radio stick with the rtl_fm
> +tool, or any other SDR via csdr, for example. It can also decode raw ASCII
> +bitstream, the hex format used by RDS Spy, and audio files containing
> +multiplex signals (MPX).")

Please remove “for GNU/Linux”.  Please use double spacing.  Could you
please use @dfn{} to define a few of these abbreviations?  The first use
of SDR could be “@dfn{software defined radio} (SDR)” etc.

I would do this for you, but as this depends on liquid-dsp, which needs
some clarifications, could you please also send an updated patch for
this package?

Thank you!

--
Ricardo

[bug#38842] [PATCH v2 2/3] gnu: Add liquid-dsp.

[Evan Straw]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1: [PATCH 2/3] gnu: Add liquid-dsp. --]
[-- Type: text/x-patch, Size: 2355 bytes --]

From 47b2d2efa80fc1c1acc78e183d210a538c7fed8e Mon Sep 17 00:00:00 2001
From: Evan Straw <evan.straw99@gmail.com>
Date: Tue, 31 Dec 2019 15:31:58 -0800
Subject: [PATCH 2/3] gnu: Add liquid-dsp.

* gnu/packages/ham-radio.scm (liquid-dsp): New variable.
---
 gnu/packages/ham-radio.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/ham-radio.scm b/gnu/packages/ham-radio.scm
index e82865f2f5..95a1e5c6c6 100644
--- a/gnu/packages/ham-radio.scm
+++ b/gnu/packages/ham-radio.scm
@@ -22,6 +22,8 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix git-download)
+  #:use-module (gnu packages autotools)
+  #:use-module (gnu packages base)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages image)
   #:use-module (gnu packages libusb)
@@ -127,3 +129,30 @@ satellites, the POES NOAA weather satellite series.  These transmissions are
 on a frequency of 137 MHz.  They can be received using an inexpensive antenna
 and a dedicated receiver.")
     (license license:gpl2+)))
+
+(define-public liquid-dsp
+  (package
+    (name "liquid-dsp")
+    (version "1.3.2")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/jgaeddert/liquid-dsp")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "06f8akc88xi6kaa6fx73pfb9fs7x6y7jjwb4vwkzsvsxj20jshki"))))
+    (build-system gnu-build-system)
+    (native-inputs `(("autoconf" ,autoconf)))
+    (home-page "https://liquidsdr.org")
+    (synopsis "Digital signal processing library for software-defined radios")
+    (description "liquid-dsp is a digital signal processing (DSP) library
+designed specifically for software-defined radios on embedded platforms.  The
+aim is to provide a lightweight DSP library that does not rely on a myriad of
+external dependencies or proprietary and otherwise cumbersome frameworks.  All
+signal processing elements are designed to be flexible, scalable, and dynamic,
+including filters, filter design, oscillators, modems, synchronizers, complex
+mathematical operations, and much more.")
+    (license license:expat)))
+
-- 
2.20.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#38842] [PATCH v3 2/3] gnu: Add liquid-dsp.

[Evan Straw]

[-- Attachment #1.1: Type: text/plain, Size: 234 bytes --]


Apologies for sending yet another revision to this patch.

It seems I was a bit too hasty and forgot to update the hashes. The git
tags also have "v" prepended to the version numbers, so this revision
catches that as well.

-- Evan


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: [PATCH 2/3] gnu: Add liquid-dsp. --]
[-- Type: text/x-patch, Size: 2375 bytes --]

From cf60d325dcc6b31f0c040c947e1e882cdaea585c Mon Sep 17 00:00:00 2001
From: Evan Straw <evan.straw99@gmail.com>
Date: Tue, 31 Dec 2019 15:31:58 -0800
Subject: [PATCH 2/3] gnu: Add liquid-dsp.

* gnu/packages/ham-radio.scm (liquid-dsp): New variable.
---
 gnu/packages/ham-radio.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/ham-radio.scm b/gnu/packages/ham-radio.scm
index e82865f2f5..bd6badd0f7 100644
--- a/gnu/packages/ham-radio.scm
+++ b/gnu/packages/ham-radio.scm
@@ -22,6 +22,8 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix git-download)
+  #:use-module (gnu packages autotools)
+  #:use-module (gnu packages base)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages image)
   #:use-module (gnu packages libusb)
@@ -127,3 +129,30 @@ satellites, the POES NOAA weather satellite series.  These transmissions are
 on a frequency of 137 MHz.  They can be received using an inexpensive antenna
 and a dedicated receiver.")
     (license license:gpl2+)))
+
+(define-public liquid-dsp
+  (package
+    (name "liquid-dsp")
+    (version "1.3.2")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/jgaeddert/liquid-dsp")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1n6dbg13q8ga5qhg1yiszwly4jj0rxqr6f1xwm9waaly5z493xsd"))))
+    (build-system gnu-build-system)
+    (native-inputs `(("autoconf" ,autoconf)))
+    (home-page "https://liquidsdr.org")
+    (synopsis "Digital signal processing library for software-defined radios")
+    (description "liquid-dsp is a digital signal processing (DSP) library
+designed specifically for software-defined radios on embedded platforms.  The
+aim is to provide a lightweight DSP library that does not rely on a myriad of
+external dependencies or proprietary and otherwise cumbersome frameworks.  All
+signal processing elements are designed to be flexible, scalable, and dynamic,
+including filters, filter design, oscillators, modems, synchronizers, complex
+mathematical operations, and much more.")
+    (license license:expat)))
+
-- 
2.20.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#38842] [PATCH v2 3/3] gnu: Add redsea.

[Evan Straw]

[-- Attachment #1.1: Type: text/plain, Size: 116 bytes --]


This revision should address the issues with the patch for adding
Redsea.

Thanks for pointing these out.

--Evan


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: [PATCH 3/3] gnu: Add redsea. --]
[-- Type: text/x-patch, Size: 2702 bytes --]

From ada62b2a6497b557bb5ca3e27c72f1a16d8b401a Mon Sep 17 00:00:00 2001
From: Evan Straw <evan.straw99@gmail.com>
Date: Tue, 31 Dec 2019 19:04:37 -0800
Subject: [PATCH 3/3] gnu: Add redsea.

* gnu/packages/ham-radio.scm (redsea): New variable.
---
 gnu/packages/ham-radio.scm | 45 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/ham-radio.scm b/gnu/packages/ham-radio.scm
index bd6badd0f7..3aa89cd84c 100644
--- a/gnu/packages/ham-radio.scm
+++ b/gnu/packages/ham-radio.scm
@@ -156,3 +156,48 @@ including filters, filter design, oscillators, modems, synchronizers, complex
 mathematical operations, and much more.")
     (license license:expat)))
 
+(define-public redsea
+  (package
+    (name "redsea")
+    (version "0.18")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/windytan/redsea")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1y96g0ra2krjb2kypm8s5gdfia45yci4f36klsvyzg8d53v5cwhn"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         ;; The configure.ac file does not explicitly link against libiconv
+         ;; except on Mac OS, causing the build to fail. This phase comments
+         ;; out the original AC_SUBST macro (located inside a conditional) and
+         ;; adds an explicit use of it underneath, so that libiconv is always
+         ;; linked against.
+         (add-after 'unpack 'patch-libiconv
+           (lambda _
+             (substitute* "configure.ac"
+               (("^ +AC_SUBST")
+                "# AC_SUBST")
+               (("esac")
+                "esac\nAC_SUBST([ICONV], [\"-liconv\"])"))
+             #t)))))
+    (inputs
+     `(("libiconv" ,libiconv)
+       ("libsndfile" ,libsndfile)
+       ("liquid-dsp" ,liquid-dsp)))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)))
+    (home-page "https://github.com/windytan/redsea")
+    (synopsis "Lightweight RDS to JSON decoder")
+    (description "redsea is a lightweight command-line @dfn{FM Radio Data
+System} (FM-RDS) decoder.  Redsea can be used with any RTL-SDR USB radio stick
+with the rtl_fm tool, or any other @dfn{software-defined radio} (SDR) via
+csdr, for example.  It can also decode raw ASCII bitstream, the hex format
+used by RDS Spy, and audio files containing @dfn{multiplex} signals (MPX).")
+    (license license:expat)))
-- 
2.20.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#38842] [PATCH v2 3/3] gnu: Add redsea.

[Evan Straw]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

Hi,

Since some changes have been made, like the inclusion of liquid-dsp from another
contributor (see 38865) I've made a new patch series (see 39150) that should
include only relevant changes. I felt a new patch series was more appropriate
since the content of the patches has changed somewhat and it isn't just a plain
revision to the patches already in this thread.

This bug can be closed if need be.

Thanks,
-- Evan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

bug#38842: [PATCH] Update rtl-sdr and add redsea

[Jonathan Brielmaier]

Resubmitted at http://issues.guix.gnu.org/issue/39150 and already
applied to master.
Closing.