[bug#38842] [PATCH 2/3] gnu: Add liquid-dsp.

[Evan Straw <evan.straw99@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1805 bytes --]

> Hi Evan,
>
>> From 71f377a45bfc830ff207cd56fa2d8fe0225a6874 Mon Sep 17 00:00:00 2001
>> From: Evan Straw <evan.straw99@gmail.com>
>> Date: Tue, 31 Dec 2019 15:31:58 -0800
>> Subject: [PATCH 2/3] gnu: Add liquid-dsp.
>>
>> * gnu/packages/ham-radio.scm (liquid-dsp): New variable.
>
>> +(define-public liquid-dsp
>> +  (let ((commit "f11733208e3d0da928a0dc2111cdb2b0c4817cef")
>> +        (revision "2")
>> +        (version "1.3.2"))
>
> Why this commit and not just the latest release 1.3.2?

It has been a while since liquid-dsp has had a release, so I was
concerned that the software would be out of date and just chose the
latest commit from their git repository. In hindsight there probably
isn't much cause for concern though so I will change it to just the
latest release.

>
>> +      (description "liquid-dsp is a free and open-source digital signal
>> +processing (DSP) library designed specifically for software-defined radios on
>> +embedded platforms. The aim is to provide a lightweight DSP library that does
>> +not rely on a myriad of external dependencies or proprietary and otherwise
>> +cumbersome frameworks. All signal processing elements are designed to be
>> +flexible, scalable, and dynamic, including filters, filter design,
>> +oscillators, modems, synchronizers, complex mathematical operations, and much
>> +more.")
>
> Please remove “free and open-source” — all software in Guix is free
> software, so we don’t need to state it.  Please also use double spacing
> after each sentence.
>

This description was basically just taken from the project's GitHub
page. My apologies, should have checked over it more. I'll change that
too.

Thanks for pointing these things out. I'll send a revision through shortly.

-- Evan Straw

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]