From: Ricardo Wurmus <rekado@elephly.net>
To: Evan Straw <evan.straw99@gmail.com>
Cc: 38842@debbugs.gnu.org
Subject: [bug#38842] [PATCH 3/3] gnu: Add redsea.
Date: Wed, 01 Jan 2020 23:11:46 +0100 [thread overview]
Message-ID: <87png2n7x9.fsf@elephly.net> (raw)
In-Reply-To: <871rsjhneb.fsf@gmail.com>
Hi Evan,
> From f19dfe6652727f074b0aa335b43c52bb482116b2 Mon Sep 17 00:00:00 2001
> From: Evan Straw <evan.straw99@gmail.com>
> Date: Tue, 31 Dec 2019 19:04:37 -0800
> Subject: [PATCH 3/3] gnu: Add redsea.
>
> * gnu/packages/ham-radio.scm (redsea): New variable.
> ---
> gnu/packages/ham-radio.scm | 43 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/gnu/packages/ham-radio.scm b/gnu/packages/ham-radio.scm
> index f327ea22da..5c1e17ac47 100644
> --- a/gnu/packages/ham-radio.scm
> +++ b/gnu/packages/ham-radio.scm
> @@ -20,6 +20,7 @@
> (define-module (gnu packages ham-radio)
> #:use-module ((guix licenses) #:prefix license:)
> #:use-module (guix packages)
> + #:use-module (guix utils)
Why is this needed?
> +(define-public redsea
> + (package
> + (name "redsea")
> + (version "0.18")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/windytan/redsea")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1y96g0ra2krjb2kypm8s5gdfia45yci4f36klsvyzg8d53v5cwhn"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + ;; The configure.ac file does not explicitly link against libiconv
> + ;; except on Mac OS, causing the build to fail. This phase comments
> + ;; out the original AC_SUBST macro (located inside a conditional) and
> + ;; adds an explicit use of it underneath, so that libiconv is always
> + ;; linked against.
> + (add-after 'unpack 'patch-libiconv
> + (lambda _
> + (substitute* "configure.ac"
> + (("^ +AC_SUBST")
> + "# AC_SUBST")
> + (("esac")
> + "esac\nAC_SUBST([ICONV], [\"-liconv\"])")))))))
Please end all phases on #t (or #true).
> + (inputs `(("libiconv" ,libiconv)
> + ("libsndfile" ,libsndfile)
> + ("liquid-dsp" ,liquid-dsp)))
> + (native-inputs `(("autoconf" ,autoconf)
> + ("automake" ,automake)))
I suggest putting the lists on a new line.
> + (home-page "https://github.com/windytan/redsea")
> + (synopsis "A lightweight RDS to JSON decoder")
Please remove the leading “A”. (guix lint should complain about this.)
> + (description "redsea is a lightweight command-line FM-RDS decoder for
> +GNU/Linux. Redsea can be used with any RTL-SDR USB radio stick with the rtl_fm
> +tool, or any other SDR via csdr, for example. It can also decode raw ASCII
> +bitstream, the hex format used by RDS Spy, and audio files containing
> +multiplex signals (MPX).")
Please remove “for GNU/Linux”. Please use double spacing. Could you
please use @dfn{} to define a few of these abbreviations? The first use
of SDR could be “@dfn{software defined radio} (SDR)” etc.
I would do this for you, but as this depends on liquid-dsp, which needs
some clarifications, could you please also send an updated patch for
this package?
Thank you!
--
Ricardo
next prev parent reply other threads:[~2020-01-01 22:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-01 3:14 [bug#38842] [PATCH] Update rtl-sdr and add redsea Evan Straw
2020-01-01 3:20 ` [bug#38842] [PATCH 1/3] gnu: rtl-sdr: Update to 0.6.0 Evan Straw
2020-01-01 22:03 ` Ricardo Wurmus
2020-01-01 3:21 ` [bug#38842] [PATCH 2/3] gnu: Add liquid-dsp Evan Straw
2020-01-01 22:06 ` Ricardo Wurmus
2020-01-01 22:27 ` Evan Straw
2020-01-01 3:21 ` [bug#38842] [PATCH 3/3] gnu: Add redsea Evan Straw
2020-01-01 22:11 ` Ricardo Wurmus [this message]
2020-01-01 22:54 ` [bug#38842] [PATCH v2 2/3] gnu: Add liquid-dsp Evan Straw
2020-01-01 23:08 ` [bug#38842] [PATCH v3 " Evan Straw
2020-01-01 23:24 ` [bug#38842] [PATCH v2 3/3] gnu: Add redsea Evan Straw
2020-01-16 7:34 ` Evan Straw
2020-03-12 12:12 ` bug#38842: [PATCH] Update rtl-sdr and add redsea Jonathan Brielmaier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87png2n7x9.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=38842@debbugs.gnu.org \
--cc=evan.straw99@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).