From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:45138)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1imm8t-0002e4-Gq
 for guix-patches@gnu.org; Wed, 01 Jan 2020 17:07:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1imm8s-0005Yf-Fg
 for guix-patches@gnu.org; Wed, 01 Jan 2020 17:07:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:59945)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1imm8s-0005Ya-CX
 for guix-patches@gnu.org; Wed, 01 Jan 2020 17:07:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1imm8s-0002GS-7w
 for guix-patches@gnu.org; Wed, 01 Jan 2020 17:07:02 -0500
Subject: [bug#38842] [PATCH 2/3] gnu: Add liquid-dsp.
Resent-Message-ID: <handler.38842.B38842.15779163898665@debbugs.gnu.org>
References: <87a777hnrb.fsf@gmail.com> <874kxfhnez.fsf@gmail.com>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <874kxfhnez.fsf@gmail.com>
Date: Wed, 01 Jan 2020 23:06:20 +0100
Message-ID: <87r20in86b.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Evan Straw <evan.straw99@gmail.com>
Cc: 38842@debbugs.gnu.org


Hi Evan,

> From 71f377a45bfc830ff207cd56fa2d8fe0225a6874 Mon Sep 17 00:00:00 2001
> From: Evan Straw <evan.straw99@gmail.com>
> Date: Tue, 31 Dec 2019 15:31:58 -0800
> Subject: [PATCH 2/3] gnu: Add liquid-dsp.
>
> * gnu/packages/ham-radio.scm (liquid-dsp): New variable.

> +(define-public liquid-dsp
> +  (let ((commit "f11733208e3d0da928a0dc2111cdb2b0c4817cef")
> +        (revision "2")
> +        (version "1.3.2"))

Why this commit and not just the latest release 1.3.2?

> +      (description "liquid-dsp is a free and open-source digital signal
> +processing (DSP) library designed specifically for software-defined radi=
os on
> +embedded platforms. The aim is to provide a lightweight DSP library that=
 does
> +not rely on a myriad of external dependencies or proprietary and otherwi=
se
> +cumbersome frameworks. All signal processing elements are designed to be
> +flexible, scalable, and dynamic, including filters, filter design,
> +oscillators, modems, synchronizers, complex mathematical operations, and=
 much
> +more.")

Please remove =E2=80=9Cfree and open-source=E2=80=9D =E2=80=94 all software=
 in Guix is free
software, so we don=E2=80=99t need to state it.  Please also use double spa=
cing
after each sentence.

--
Ricardo