* [bug#40756] gnu: Add ktsuss.
@ 2020-04-21 23:26 Raghav Gururajan
2020-04-23 8:17 ` Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Raghav Gururajan @ 2020-04-21 23:26 UTC (permalink / raw)
To: 40756
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: ktsuss.patch --]
[-- Type: text/x-patch, Size: 2902 bytes --]
From 9fff550b6719e9d52ba4e500360240d7adc76538 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Tue, 21 Apr 2020 19:17:35 -0400
Subject: [PATCH 4/4] gnu: Add ktsuss.
* gnu/packages/admin.scm (ktsuss): New variable.
---
gnu/packages/admin.scm | 51 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index bf5aa9d890..6744624067 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -52,6 +52,7 @@
(define-module (gnu packages admin)
#:use-module (guix build-system cmake)
#:use-module (guix build-system emacs)
+ #:use-module (guix build-system glib-or-gtk)
#:use-module (guix build-system gnu)
#:use-module (guix build-system meson)
#:use-module (guix build-system perl)
@@ -64,6 +65,7 @@
#:use-module (guix utils)
#:use-module (gnu packages)
#:use-module (gnu packages algebra)
+ #:use-module (gnu packages autogen)
#:use-module (gnu packages autotools)
#:use-module (gnu packages base)
#:use-module (gnu packages bash)
@@ -128,6 +130,55 @@
#:use-module (gnu packages xml)
#:use-module (gnu packages xorg))
+(define-public ktsuss
+ (package
+ (name "ktsuss")
+ (version "2.1")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/nomius/ktsuss.git")
+ (commit version)))
+ (sha256
+ (base32 "0q9931f9hp47v1n8scli4bdg2rkjpf5jf8v7jj2gdn83aia1r2hz"))
+ (file-name (git-file-name name version))))
+ (build-system glib-or-gtk-build-system)
+ (arguments
+ `(#:configure-flags
+ (list
+ "--enable-sudo=yes")
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'patch
+ (lambda _
+ (substitute* "configure.ac"
+ (("sudopath=`which sudo 2>/dev/null`")
+ (string-append "sudopath="
+ (string-append (assoc-ref %build-inputs "sudo")
+ "/bin/sudo"))))
+ #t)))))
+ (native-inputs
+ `(("autoconf" ,autoconf)
+ ("autogen" ,autogen)
+ ("automake" ,automake)
+ ("libtool" ,libtool)
+ ("pkg-config" ,pkg-config)))
+ (inputs
+ `(("glib" ,glib)
+ ("gtk+" ,gtk+-2)
+ ("sudo" ,sudo)))
+ (synopsis "Graphical front-end for Su")
+ (description "Ktsuss stands for 'keep the su simple, stupid', and as the
+name says, is a graphical version (frontend) of su written in C and GTK+ 2. The
+idea of the project is to remain simple and bug free.")
+ (home-page "https://github.com/nomius/ktsuss")
+ (license
+ (list
+ (license:non-copyleft "file://COPYING")
+ (license:non-copyleft "file://LICENSE")))))
+
(define-public aide
(package
(name "aide")
--
2.26.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#40756] gnu: Add ktsuss.
2020-04-21 23:26 [bug#40756] gnu: Add ktsuss Raghav Gururajan
@ 2020-04-23 8:17 ` Nicolas Goaziou
2020-04-24 19:21 ` Raghav Gururajan
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2020-04-23 8:17 UTC (permalink / raw)
To: Raghav Gururajan; +Cc: 40756
Hello,
Raghav Gururajan <raghavgururajan@disroot.org> writes:
> Subject: [PATCH 4/4] gnu: Add ktsuss.
Thank you!
It looks mostly good. I have some comments, tho.
> + (modify-phases %standard-phases
> + (add-after 'unpack 'patch
Could you provide a more insightful name for the new phase? :)
> + (lambda _
> + (substitute* "configure.ac"
> + (("sudopath=`which sudo 2>/dev/null`")
> + (string-append "sudopath="
> + (string-append (assoc-ref %build-inputs "sudo")
> + "/bin/sudo"))))
Please use (lambda* (#:key inputs #:allow-other-keys) ...) and `inputs'
instead of the magical %build-inputs.
> + (synopsis "Graphical front-end for Su")
I would write:
Graphical front end for @command{su}
> + (description "Ktsuss stands for 'keep the su simple, stupid', and as the
> +name says, is a graphical version (frontend) of su written in C and GTK+ 2. The
> +idea of the project is to remain simple and bug free.")
What about :
(description
"Ktsuss stands for ``Keep the @command{su} simple, stupid''.
It is a graphical version of @command{su} written in C and GTK+ 2,
with simplicity in mind.")
> + (license
> + (list
> + (license:non-copyleft "file://COPYING")
> + (license:non-copyleft "file://LICENSE")))))
It looks like the license is `bsd-3'. Do you have any reason to think
otherwise ?
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#40756] gnu: Add ktsuss.
2020-04-23 8:17 ` Nicolas Goaziou
@ 2020-04-24 19:21 ` Raghav Gururajan
2020-04-24 19:23 ` [bug#40756] gnu: Add ktsuss. (v3) Raghav Gururajan
0 siblings, 1 reply; 5+ messages in thread
From: Raghav Gururajan @ 2020-04-24 19:21 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 40756
Hi Nicolas!
> > Subject: [PATCH 4/4] gnu: Add ktsuss.
>
> Thank you!
>
> It looks mostly good. I have some comments, tho.
>
> > + (modify-phases %standard-phases
> > + (add-after 'unpack 'patch
>
> Could you provide a more insightful name for the new phase? :)
>
> > + (lambda _
> > + (substitute* "configure.ac"
> > + (("sudopath=`which sudo 2>/dev/null`")
> > + (string-append "sudopath="
> > + (string-append (assoc-ref %build-inputs
> > "sudo")
> > + "/bin/sudo"))))
>
> Please use (lambda* (#:key inputs #:allow-other-keys) ...) and `inputs'
> instead of the magical %build-inputs.
>
> > + (synopsis "Graphical front-end for Su")
>
> I would write:
>
> Graphical front end for @command{su}
>
> > + (description "Ktsuss stands for 'keep the su simple, stupid', and as
> > the +name says, is a graphical version (frontend) of su written in C and
> > GTK+ 2. The +idea of the project is to remain simple and bug free.")
>
> What about :
>
> (description
> "Ktsuss stands for ``Keep the @command{su} simple, stupid''.
> It is a graphical version of @command{su} written in C and GTK+ 2,
> with simplicity in mind.")
>
> > + (license
> > + (list
> > + (license:non-copyleft "file://COPYING")
> > + (license:non-copyleft "file://LICENSE")))))
>
> It looks like the license is `bsd-3'. Do you have any reason to think
> otherwise ?
>
> Could you send an updated patch?
Thank you for the feedback. Please find the updated patch attached with this
email.
Regards,
RG.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#40756] gnu: Add ktsuss. (v3)
2020-04-24 19:21 ` Raghav Gururajan
@ 2020-04-24 19:23 ` Raghav Gururajan
2020-04-24 20:12 ` bug#40756: " Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Raghav Gururajan @ 2020-04-24 19:23 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 40756
[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]
On Fri, 24 Apr 2020 15:21:31 -0400
Raghav Gururajan <raghavgururajan@disroot.org> wrote:
> Hi Nicolas!
>
> > > Subject: [PATCH 4/4] gnu: Add ktsuss.
> >
> > Thank you!
> >
> > It looks mostly good. I have some comments, tho.
> >
> > > + (modify-phases %standard-phases
> > > + (add-after 'unpack 'patch
> >
> > Could you provide a more insightful name for the new phase? :)
> >
> > > + (lambda _
> > > + (substitute* "configure.ac"
> > > + (("sudopath=`which sudo 2>/dev/null`")
> > > + (string-append "sudopath="
> > > + (string-append (assoc-ref %build-inputs
> > > "sudo")
> > > + "/bin/sudo"))))
> >
> > Please use (lambda* (#:key inputs #:allow-other-keys) ...) and `inputs'
> > instead of the magical %build-inputs.
> >
> > > + (synopsis "Graphical front-end for Su")
> >
> > I would write:
> >
> > Graphical front end for @command{su}
> >
> > > + (description "Ktsuss stands for 'keep the su simple, stupid', and as
> > > the +name says, is a graphical version (frontend) of su written in C and
> > > GTK+ 2. The +idea of the project is to remain simple and bug free.")
> >
> > What about :
> >
> > (description
> > "Ktsuss stands for ``Keep the @command{su} simple, stupid''.
> > It is a graphical version of @command{su} written in C and GTK+ 2,
> > with simplicity in mind.")
> >
> > > + (license
> > > + (list
> > > + (license:non-copyleft "file://COPYING")
> > > + (license:non-copyleft "file://LICENSE")))))
> >
> > It looks like the license is `bsd-3'. Do you have any reason to think
> > otherwise ?
> >
> > Could you send an updated patch?
>
> Thank you for the feedback. Please find the updated patch attached with this
> email.
>
> Regards,
> RG.
[-- Attachment #2: 0001-gnu-Add-ktsuss.patch --]
[-- Type: text/x-patch, Size: 2872 bytes --]
From 4a54ba65fbb201fc346af8c4580ce2991ea8e68d Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Fri, 24 Apr 2020 15:18:59 -0400
Subject: [PATCH] gnu: Add ktsuss.
* gnu/packages/admin.scm (ktsuss): New variable.
---
gnu/packages/admin.scm | 49 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 49 insertions(+)
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 619a419170..80c2e05336 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -52,6 +52,7 @@
(define-module (gnu packages admin)
#:use-module (guix build-system cmake)
#:use-module (guix build-system emacs)
+ #:use-module (guix build-system glib-or-gtk)
#:use-module (guix build-system gnu)
#:use-module (guix build-system meson)
#:use-module (guix build-system perl)
@@ -64,6 +65,7 @@
#:use-module (guix utils)
#:use-module (gnu packages)
#:use-module (gnu packages algebra)
+ #:use-module (gnu packages autogen)
#:use-module (gnu packages autotools)
#:use-module (gnu packages base)
#:use-module (gnu packages bash)
@@ -128,6 +130,53 @@
#:use-module (gnu packages xml)
#:use-module (gnu packages xorg))
+(define-public ktsuss
+ (package
+ (name "ktsuss")
+ (version "2.1")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/nomius/ktsuss.git")
+ (commit version)))
+ (sha256
+ (base32 "0q9931f9hp47v1n8scli4bdg2rkjpf5jf8v7jj2gdn83aia1r2hz"))
+ (file-name (git-file-name name version))))
+ (build-system glib-or-gtk-build-system)
+ (arguments
+ `(#:configure-flags
+ (list
+ "--enable-sudo=yes")
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'patch-sudo-path
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute* "configure.ac"
+ (("sudopath=`which sudo 2>/dev/null`")
+ (string-append "sudopath="
+ (string-append (assoc-ref inputs "sudo")
+ "/bin/sudo"))))
+ #t)))))
+ (native-inputs
+ `(("autoconf" ,autoconf)
+ ("autogen" ,autogen)
+ ("automake" ,automake)
+ ("libtool" ,libtool)
+ ("pkg-config" ,pkg-config)))
+ (inputs
+ `(("glib" ,glib)
+ ("gtk+" ,gtk+-2)
+ ("sudo" ,sudo)))
+ (synopsis "Graphical front end for @command{su}")
+ (description "Ktsuss stands for 'keep the @command{su} simple, stupid',
+and as the name says, is a graphical version (frontend) of @command{su}
+written in C and GTK+ 2. The idea of the project is to remain simple and
+bug free.")
+ (home-page "https://github.com/nomius/ktsuss")
+ (license license:bsd-3)))
+
(define-public aide
(package
(name "aide")
--
2.26.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#40756: gnu: Add ktsuss. (v3)
2020-04-24 19:23 ` [bug#40756] gnu: Add ktsuss. (v3) Raghav Gururajan
@ 2020-04-24 20:12 ` Nicolas Goaziou
0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Goaziou @ 2020-04-24 20:12 UTC (permalink / raw)
To: Raghav Gururajan; +Cc: 40756-done
Hello,
Raghav Gururajan <raghavgururajan@disroot.org> writes:
> Subject: [PATCH] gnu: Add ktsuss.
>
> * gnu/packages/admin.scm (ktsuss): New variable.
Applied. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-24 20:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-21 23:26 [bug#40756] gnu: Add ktsuss Raghav Gururajan
2020-04-23 8:17 ` Nicolas Goaziou
2020-04-24 19:21 ` Raghav Gururajan
2020-04-24 19:23 ` [bug#40756] gnu: Add ktsuss. (v3) Raghav Gururajan
2020-04-24 20:12 ` bug#40756: " Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).