From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:53498) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jS3vf-0003fM-4f for guix-patches@gnu.org; Fri, 24 Apr 2020 15:24:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jS3ve-0007Na-Ac for guix-patches@gnu.org; Fri, 24 Apr 2020 15:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46423) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jS3vd-0007NH-TD for guix-patches@gnu.org; Fri, 24 Apr 2020 15:24:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jS3vd-0005Bn-MD for guix-patches@gnu.org; Fri, 24 Apr 2020 15:24:01 -0400 Subject: [bug#40756] gnu: Add ktsuss. (v3) Resent-Message-ID: Date: Fri, 24 Apr 2020 15:23:02 -0400 From: Raghav Gururajan Message-ID: <20200424152302.608f23c2.raghavgururajan@disroot.org> In-Reply-To: <20200424152131.62ac18f1.raghavgururajan@disroot.org> References: <20200421192622.7d6412e0.raghavgururajan@disroot.org> <871roeliph.fsf@nicolasgoaziou.fr> <20200424152131.62ac18f1.raghavgururajan@disroot.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/Nc_T8fiJr.HOW/E92EvBaQl" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Nicolas Goaziou Cc: 40756@debbugs.gnu.org --MP_/Nc_T8fiJr.HOW/E92EvBaQl Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline On Fri, 24 Apr 2020 15:21:31 -0400 Raghav Gururajan wrote: > Hi Nicolas! > > > > Subject: [PATCH 4/4] gnu: Add ktsuss. > > > > Thank you! > > > > It looks mostly good. I have some comments, tho. > > > > > + (modify-phases %standard-phases > > > + (add-after 'unpack 'patch > > > > Could you provide a more insightful name for the new phase? :) > > > > > + (lambda _ > > > + (substitute* "configure.ac" > > > + (("sudopath=`which sudo 2>/dev/null`") > > > + (string-append "sudopath=" > > > + (string-append (assoc-ref %build-inputs > > > "sudo") > > > + "/bin/sudo")))) > > > > Please use (lambda* (#:key inputs #:allow-other-keys) ...) and `inputs' > > instead of the magical %build-inputs. > > > > > + (synopsis "Graphical front-end for Su") > > > > I would write: > > > > Graphical front end for @command{su} > > > > > + (description "Ktsuss stands for 'keep the su simple, stupid', and as > > > the +name says, is a graphical version (frontend) of su written in C and > > > GTK+ 2. The +idea of the project is to remain simple and bug free.") > > > > What about : > > > > (description > > "Ktsuss stands for ``Keep the @command{su} simple, stupid''. > > It is a graphical version of @command{su} written in C and GTK+ 2, > > with simplicity in mind.") > > > > > + (license > > > + (list > > > + (license:non-copyleft "file://COPYING") > > > + (license:non-copyleft "file://LICENSE"))))) > > > > It looks like the license is `bsd-3'. Do you have any reason to think > > otherwise ? > > > > Could you send an updated patch? > > Thank you for the feedback. Please find the updated patch attached with this > email. > > Regards, > RG. --MP_/Nc_T8fiJr.HOW/E92EvBaQl Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-gnu-Add-ktsuss.patch >From 4a54ba65fbb201fc346af8c4580ce2991ea8e68d Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Fri, 24 Apr 2020 15:18:59 -0400 Subject: [PATCH] gnu: Add ktsuss. * gnu/packages/admin.scm (ktsuss): New variable. --- gnu/packages/admin.scm | 49 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index 619a419170..80c2e05336 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -52,6 +52,7 @@ (define-module (gnu packages admin) #:use-module (guix build-system cmake) #:use-module (guix build-system emacs) + #:use-module (guix build-system glib-or-gtk) #:use-module (guix build-system gnu) #:use-module (guix build-system meson) #:use-module (guix build-system perl) @@ -64,6 +65,7 @@ #:use-module (guix utils) #:use-module (gnu packages) #:use-module (gnu packages algebra) + #:use-module (gnu packages autogen) #:use-module (gnu packages autotools) #:use-module (gnu packages base) #:use-module (gnu packages bash) @@ -128,6 +130,53 @@ #:use-module (gnu packages xml) #:use-module (gnu packages xorg)) +(define-public ktsuss + (package + (name "ktsuss") + (version "2.1") + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/nomius/ktsuss.git") + (commit version))) + (sha256 + (base32 "0q9931f9hp47v1n8scli4bdg2rkjpf5jf8v7jj2gdn83aia1r2hz")) + (file-name (git-file-name name version)))) + (build-system glib-or-gtk-build-system) + (arguments + `(#:configure-flags + (list + "--enable-sudo=yes") + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch-sudo-path + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "configure.ac" + (("sudopath=`which sudo 2>/dev/null`") + (string-append "sudopath=" + (string-append (assoc-ref inputs "sudo") + "/bin/sudo")))) + #t))))) + (native-inputs + `(("autoconf" ,autoconf) + ("autogen" ,autogen) + ("automake" ,automake) + ("libtool" ,libtool) + ("pkg-config" ,pkg-config))) + (inputs + `(("glib" ,glib) + ("gtk+" ,gtk+-2) + ("sudo" ,sudo))) + (synopsis "Graphical front end for @command{su}") + (description "Ktsuss stands for 'keep the @command{su} simple, stupid', +and as the name says, is a graphical version (frontend) of @command{su} +written in C and GTK+ 2. The idea of the project is to remain simple and +bug free.") + (home-page "https://github.com/nomius/ktsuss") + (license license:bsd-3))) + (define-public aide (package (name "aide") -- 2.26.1 --MP_/Nc_T8fiJr.HOW/E92EvBaQl--