From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:53188)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jS3tj-0006p1-GT
 for guix-patches@gnu.org; Fri, 24 Apr 2020 15:22:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jS3ti-0005XE-T3
 for guix-patches@gnu.org; Fri, 24 Apr 2020 15:22:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:46418)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jS3ti-0005WD-Eg
 for guix-patches@gnu.org; Fri, 24 Apr 2020 15:22:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jS3ti-00058f-A7
 for guix-patches@gnu.org; Fri, 24 Apr 2020 15:22:02 -0400
Subject: [bug#40756] gnu: Add ktsuss.
Resent-Message-ID: <handler.40756.B40756.158775611919743@debbugs.gnu.org>
Date: Fri, 24 Apr 2020 15:21:31 -0400
From: Raghav Gururajan <raghavgururajan@disroot.org>
Message-ID: <20200424152131.62ac18f1.raghavgururajan@disroot.org>
In-Reply-To: <871roeliph.fsf@nicolasgoaziou.fr>
References: <20200421192622.7d6412e0.raghavgururajan@disroot.org>
 <871roeliph.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 40756@debbugs.gnu.org

Hi Nicolas!

> > Subject: [PATCH 4/4] gnu: Add ktsuss.  
> 
> Thank you! 
> 
> It looks mostly good. I have some comments, tho.
> 
> > +       (modify-phases %standard-phases
> > +         (add-after 'unpack 'patch  
> 
> Could you provide a more insightful name for the new phase? :)
> 
> > +           (lambda _
> > +             (substitute* "configure.ac"
> > +               (("sudopath=`which sudo 2>/dev/null`")
> > +                (string-append "sudopath="
> > +                               (string-append (assoc-ref %build-inputs
> > "sudo")
> > +                                              "/bin/sudo"))))  
> 
> Please use (lambda* (#:key inputs #:allow-other-keys) ...) and `inputs'
> instead of the magical %build-inputs.
> 
> > +    (synopsis "Graphical front-end for Su")  
> 
> I would write:
> 
>   Graphical front end for @command{su}
> 
> > +    (description "Ktsuss stands for 'keep the su simple, stupid', and as
> > the +name says, is a graphical version (frontend) of su written in C and
> > GTK+ 2.  The +idea of the project is to remain simple and bug free.")  
> 
> What about :
> 
>     (description
>      "Ktsuss stands for ``Keep the @command{su} simple, stupid''.
> It is a graphical version of @command{su} written in C and GTK+ 2,
> with simplicity in mind.")
> 
> > +    (license
> > +     (list
> > +      (license:non-copyleft "file://COPYING")
> > +      (license:non-copyleft "file://LICENSE")))))  
> 
> It looks like the license is `bsd-3'. Do you have any reason to think
> otherwise ?
> 
> Could you send an updated patch?

Thank you for the feedback. Please find the updated patch attached with this
email.

Regards,
RG.