[bug#47269] [PATCH 0/1] Add node-global-gradle-clean

[Maxime Devos <maximedevos@telenet.be>]

[-- Attachment #1: Type: text/plain, Size: 2142 bytes --]

On Sat, 2021-03-20 at 00:51 +0530, Dhruvin Gandhi via Guix-patches via wrote:
> I've recently started using Guix System and it has been my daily driver for a
> month now. Surprisingly, guix already has every package I need. I decided to
> ask my friends about packages they'll need before they can start using Guix.
> 
> I will try to submit patches of those packages in coming months. I am new to
> guix, and am new to contributing code via patches. Let me know if you have any
> corrections/suggestions.

See ‘16.4 Packaging Guidelines’ and ‘16.6 Submitting Patches’ in the manual.

> Dhruvin Gandhi (1):
>   Add node-global-gradle-clean
> 
>  gnu/packages/node-xyz.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)

There's an uniform style for commit messages.  Example for
when adding new packages:

(start snip)
commit 7382b1027a319e505be6cfcadf1f5bd761dadccc
Author: Ricardo Wurmus <rekado@elephly.net>
Date:   Thu Feb 4 23:20:05 2021 +0100

    gnu: Add r-shinyjqui.
    
    * gnu/packages/cran.scm (r-shinyjqui): New variable.

commit 5ae09d7979a0696d862b9555314eab199f7ce576
Author: Ricardo Wurmus <rekado@elephly.net>
Date:   Thu Feb 4 22:41:35 2021 +0100

    gnu: Add r-spelling.
    
    * gnu/packages/cran.scm (r-spelling): New variable.
(end snip)

(More examples in the git history)

When defining a new package, usually a copyright line should
be added at the top of the file.

I prefer referring to the commit directly instead of by tag, as
the commit is required for SWH fallback if the repo disappears.

Is there any particular reason tests are disabled?  Maybe add
a comment "; No test suite." if that's the case.

I'm not a fan of starting package descriptions with "This package is ...",
even though plenty of plenty of packages in gnu/package/node-xyz.scm have
such a description.  A description from gnu/packages/guile-xyz.scm I like:

     "Guile-DSV is a GNU Guile module for working with the
delimiter-separated values (DSV) data format.  Guile-DSV supports the
Unix-style DSV format and RFC 4180 format."

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]