From: Julien Lepiller <julien@lepiller.eu>
To: Dhruvin Gandhi <contact@dhruvin.dev>,
Maxime Devos <maximedevos@telenet.be>,
47269@debbugs.gnu.org
Subject: [bug#47269] [PATCH 0/1] Add node-global-gradle-clean
Date: Sun, 21 Mar 2021 05:33:14 -0400 [thread overview]
Message-ID: <A9675931-6DC6-4CB3-A5D0-332F3B0DFE5B@lepiller.eu> (raw)
In-Reply-To: <302910345.43719.1616316527124@office.mailbox.org>
Le 21 mars 2021 04:48:47 GMT-04:00, Dhruvin Gandhi <contact@dhruvin.dev> a écrit :
>> Dhruvin, could you submit a new patch with Maxime's suggestions?
>
>Yes, I will do that.
>
>> If you have troubles with Rome items don't worry, since It's your
>first patch, we can change a few things for you before pushing :)
>
>I don't know what Rome items are.
They are "some items" after my French autocorrect kicks in… sorry for the confusion!
>
>> Also, could you run (from the guix checkout):
>>
>> ./pre-inst-env guix lint node-global-gradle-clean
>>
>> And fix any error it reports?
>>
>> Thanks a lot!
>
>I built the package for 3 rounds to check if there's something wrong.
>I ran guix lint node-global-gradle-clean before submitting the patch.
>It showed no warnings/corrections. I will do the same before submitting
>subsequent versions of this patch. Thanks for mentioning this :)
Great, thanks!
>
>Regards,
>Dhruvin Gandhi
next prev parent reply other threads:[~2021-03-21 9:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 19:21 [bug#47269] [PATCH 0/1] Add node-global-gradle-clean Dhruvin Gandhi via Guix-patches via
2021-03-19 19:21 ` [bug#47270] [PATCH 1/1] " Dhruvin Gandhi via Guix-patches via
2023-05-29 14:24 ` bug#47270: " Jelle Licht
2021-03-20 8:51 ` [bug#47269] [PATCH 0/1] " Maxime Devos
2021-03-20 10:58 ` Julien Lepiller
2021-03-21 8:48 ` Dhruvin Gandhi via Guix-patches via
2021-03-21 9:33 ` Julien Lepiller [this message]
2021-03-21 9:51 ` zimoun
2021-03-21 8:32 ` Dhruvin Gandhi via Guix-patches via
2021-03-22 12:59 ` [bug#47269] [PATCH 0/1] gnu: " Dhruvin Gandhi via Guix-patches via
2021-03-22 12:59 ` [bug#47269] [PATCH 1/1] " Dhruvin Gandhi via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A9675931-6DC6-4CB3-A5D0-332F3B0DFE5B@lepiller.eu \
--to=julien@lepiller.eu \
--cc=47269@debbugs.gnu.org \
--cc=contact@dhruvin.dev \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).