[bug#47269] [PATCH 0/1] Add node-global-gradle-clean

[Julien Lepiller <julien@lepiller.eu>]

Le 20 mars 2021 04:51:41 GMT-04:00, Maxime Devos <maximedevos@telenet.be> a écrit :
>On Sat, 2021-03-20 at 00:51 +0530, Dhruvin Gandhi via Guix-patches via
>wrote:
>> I've recently started using Guix System and it has been my daily
>driver for a
>> month now. Surprisingly, guix already has every package I need. I
>decided to
>> ask my friends about packages they'll need before they can start
>using Guix.
>> 
>> I will try to submit patches of those packages in coming months. I am
>new to
>> guix, and am new to contributing code via patches. Let me know if you
>have any
>> corrections/suggestions.
>
>I prefer referring to the commit directly instead of by tag, as
>the commit is required for SWH fallback if the repo disappears.

Sorry to contradict, but using a tag is much more readable and works well with Software Heritage. At least, the linter seems to work in that case. Have I missed something?



Dhruvin, could you submit a new patch with Maxime's suggestions? If you have troubles with Rome items don't worry, since It's your first patch, we can change a few things for you before pushing :)

Also, could you run (from the guix checkout):

./pre-inst-env guix lint node-global-gradle-clean

And fix any error it reports?

Thanks a lot!