From: Dhruvin Gandhi via Guix-patches via <guix-patches@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>, 47269@debbugs.gnu.org
Subject: [bug#47269] [PATCH 0/1] Add node-global-gradle-clean
Date: Sun, 21 Mar 2021 14:02:34 +0530 (IST) [thread overview]
Message-ID: <1927774916.43640.1616315554137@office.mailbox.org> (raw)
In-Reply-To: <6ac44e1dc193a3d78351aed9a80e1c651e809ab5.camel@telenet.be>
> See ‘16.4 Packaging Guidelines’ and ‘16.6 Submitting Patches’ in the manual.
Yes, I will go through the guidelines first before submitting
next version of the patch with suggested changes.
> There's an uniform style for commit messages. Example for
> when adding new packages:
> ...
I saw commit messages. I initially thought the committers added
them, as I did not know how the patches are applied. But now that
you have mentioned this, it makes sense, I will use that format
for commit messages.
> When defining a new package, usually a copyright line should
> be added at the top of the file.
Will do that.
> I prefer referring to the commit directly instead of by tag, as
> the commit is required for SWH fallback if the repo disappears.
Okay.
> Is there any particular reason tests are disabled? Maybe add
> a comment "; No test suite." if that's the case.
Yes, there are no tests (as of 1.0.1). I will mention that.
> I'm not a fan of starting package descriptions with "This package is ...",
> even though plenty of plenty of packages in gnu/package/node-xyz.scm have
> such a description. A description from gnu/packages/guile-xyz.scm I like:
>
> "Guile-DSV is a GNU Guile module for working with the
> delimiter-separated values (DSV) data format. Guile-DSV supports the
> Unix-style DSV format and RFC 4180 format."
I borrowed synopsis and description from the global-gradle-clean package
author, and changed them a bit to match existing packages in the node-xyz
module. I agree that they can be more descriptive, and concise. I'll
update them as well.
I have a question. The package may be used by only a few users. I hope that
is okay with guix. Is there a rule defined somewhere, stating what gets in
this guix channel and what should not?
PS: When I submitted this patch, it created another bug 47270. I read about
what a patch series is and read about how to submit them to guix afterwards.
47270 may be closed in favor of 47269. I will follow the way specified in
guidelines.
Thanks Maxime for your suggestions.
Regards,
Dhruvin Gandhi
next prev parent reply other threads:[~2021-03-21 8:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 19:21 [bug#47269] [PATCH 0/1] Add node-global-gradle-clean Dhruvin Gandhi via Guix-patches via
2021-03-19 19:21 ` [bug#47270] [PATCH 1/1] " Dhruvin Gandhi via Guix-patches via
2023-05-29 14:24 ` bug#47270: " Jelle Licht
2021-03-20 8:51 ` [bug#47269] [PATCH 0/1] " Maxime Devos
2021-03-20 10:58 ` Julien Lepiller
2021-03-21 8:48 ` Dhruvin Gandhi via Guix-patches via
2021-03-21 9:33 ` Julien Lepiller
2021-03-21 9:51 ` zimoun
2021-03-21 8:32 ` Dhruvin Gandhi via Guix-patches via [this message]
2021-03-22 12:59 ` [bug#47269] [PATCH 0/1] gnu: " Dhruvin Gandhi via Guix-patches via
2021-03-22 12:59 ` [bug#47269] [PATCH 1/1] " Dhruvin Gandhi via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1927774916.43640.1616315554137@office.mailbox.org \
--to=guix-patches@gnu.org \
--cc=47269@debbugs.gnu.org \
--cc=contact@dhruvin.dev \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).