From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EHAyB8a3VWC6BgAA0tVLHw (envelope-from ) for ; Sat, 20 Mar 2021 08:52:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MLD5Asa3VWA8SQAAbx9fmQ (envelope-from ) for ; Sat, 20 Mar 2021 08:52:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BBF9516744 for ; Sat, 20 Mar 2021 09:52:21 +0100 (CET) Received: from localhost ([::1]:57532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNXLI-0001sH-Tz for larch@yhetil.org; Sat, 20 Mar 2021 04:52:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNXL1-0001rF-2J for guix-patches@gnu.org; Sat, 20 Mar 2021 04:52:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39933) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lNXL0-00067w-Eu for guix-patches@gnu.org; Sat, 20 Mar 2021 04:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lNXL0-0001SU-CL for guix-patches@gnu.org; Sat, 20 Mar 2021 04:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47269] [PATCH 0/1] Add node-global-gradle-clean Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 20 Mar 2021 08:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47269 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Dhruvin Gandhi , 47269@debbugs.gnu.org Received: via spool by 47269-submit@debbugs.gnu.org id=B47269.16162303145591 (code B ref 47269); Sat, 20 Mar 2021 08:52:02 +0000 Received: (at 47269) by debbugs.gnu.org; 20 Mar 2021 08:51:54 +0000 Received: from localhost ([127.0.0.1]:51479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNXKs-0001S7-54 for submit@debbugs.gnu.org; Sat, 20 Mar 2021 04:51:54 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:40652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNXKo-0001Rx-Vl for 47269@debbugs.gnu.org; Sat, 20 Mar 2021 04:51:53 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id iYro2400U0mfAB406Yrovm; Sat, 20 Mar 2021 09:51:49 +0100 Message-ID: <6ac44e1dc193a3d78351aed9a80e1c651e809ab5.camel@telenet.be> From: Maxime Devos Date: Sat, 20 Mar 2021 09:51:41 +0100 In-Reply-To: <20210319192144.17799-1-contact@dhruvin.dev> References: <20210319192144.17799-1-contact@dhruvin.dev> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-QsSyTXOcMrFcABbfW34i" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1616230309; bh=Ea06ulRFUjgfk+suNezWEvX3GfNdDVJfz3anzo9sWm4=; h=Subject:From:To:Date:In-Reply-To:References; b=kV6slwmzQ2udyIyVc9sH9mhfOewIgcFI/X4c2Gd4kL7Z38Z0v7ERgcZs2WtQhURpL EyI6Db7CWxpI+RyoCongbSsgyu9t6tCFZqCn9mSFE3J3/HQtgThK9fPOvG5VEhF0k0 uU4bEjk5YXyLzF3eqwyN72cB2w+/NSjCNoVuZR5ow+ZHVX1obHqcTA1oxUhYAXceuw A5gWLLByNQhED0c9Ip0uUxH1pnSmxiSjIF8/wkKua8qbPO6p8rr5rmvaS0Ir4tdWyU APUYojqzYPZMr8O1XFqZLf33+iG2PIT+qmevWwrLAhZmlGoM9x5nl+xbltnhp9PLNo X09n66tdu7iPA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616230341; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Ea06ulRFUjgfk+suNezWEvX3GfNdDVJfz3anzo9sWm4=; b=SyZTNOSXs8u88hbAyyD/exHVn6jVkvFBDXdv++62ITRy093N4ItLBJ0jbPlcaciM2QVd3M +qCR9iVXUpkV3s1Qe2zFkEDUNZsRWrLa+7i+8A0eFVLDAmbAhBbq20wJmMyoB37wun9t1I KxnbYCt4l1ie8wC2UJvSKtyXkY69zDHJRaoHpwANtVDd2gdmQ1eQnY8spHsLA+T5bhFAv5 V9JM5dF1qGDMX5qAl1W8xBDe4deSePe1rdhb+yv8lVvaGiQUvLGw+LBfXooiw8hog1/RX2 lTgPXcQm6+34GR8peoXkpTGOORZdn4Oc+GCVhdgjSpvqFaFBeDQ1cpdmGBv+Sg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616230341; a=rsa-sha256; cv=none; b=gSHhdwt86gOtBSGIwNFXEAneoq9jIkcDTIpM1aXHHu6W7jLiJ10SfE237356bA93tTiyzX M2ryo0xrq6xT6Lcv9uXhP1u+vjedk0LHK68wLl7Ol0VDE7eOjFgX3R5GYCnF1g1YAoLdTp DkcY65MqPalZzbp5q+/HayiQY2k7GSOejngcQgSjXgqaIYS5nGbD8SRWYZmLdCQ01iO5Wm 6wphEWR2vZyqmWhLrbIUXYRROeDKPNyp9Hk5QMPxlFNgbgu2GRk6iqsE1fXd/8JiUCayjS 8ByYaojstVo9LkBlyoZjftJ51yPcUayk3OeT39gz60A6ZhdQgX316qLFUjHrfQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=kV6slwmz; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=kV6slwmz; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BBF9516744 X-Spam-Score: -3.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: tTH5kVwjHBWC --=-QsSyTXOcMrFcABbfW34i Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2021-03-20 at 00:51 +0530, Dhruvin Gandhi via Guix-patches via wrot= e: > I've recently started using Guix System and it has been my daily driver f= or a > month now. Surprisingly, guix already has every package I need. I decided= to > ask my friends about packages they'll need before they can start using Gu= ix. >=20 > I will try to submit patches of those packages in coming months. I am new= to > guix, and am new to contributing code via patches. Let me know if you hav= e any > corrections/suggestions. See =E2=80=9816.4 Packaging Guidelines=E2=80=99 and =E2=80=9816.6 Submittin= g Patches=E2=80=99 in the manual. > Dhruvin Gandhi (1): > Add node-global-gradle-clean >=20 > gnu/packages/node-xyz.scm | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) There's an uniform style for commit messages. Example for when adding new packages: (start snip) commit 7382b1027a319e505be6cfcadf1f5bd761dadccc Author: Ricardo Wurmus Date: Thu Feb 4 23:20:05 2021 +0100 gnu: Add r-shinyjqui. =20 * gnu/packages/cran.scm (r-shinyjqui): New variable. commit 5ae09d7979a0696d862b9555314eab199f7ce576 Author: Ricardo Wurmus Date: Thu Feb 4 22:41:35 2021 +0100 gnu: Add r-spelling. =20 * gnu/packages/cran.scm (r-spelling): New variable. (end snip) (More examples in the git history) When defining a new package, usually a copyright line should be added at the top of the file. I prefer referring to the commit directly instead of by tag, as the commit is required for SWH fallback if the repo disappears. Is there any particular reason tests are disabled? Maybe add a comment "; No test suite." if that's the case. I'm not a fan of starting package descriptions with "This package is ...", even though plenty of plenty of packages in gnu/package/node-xyz.scm have such a description. A description from gnu/packages/guile-xyz.scm I like: "Guile-DSV is a GNU Guile module for working with the delimiter-separated values (DSV) data format. Guile-DSV supports the Unix-style DSV format and RFC 4180 format." Greetings, Maxime. --=-QsSyTXOcMrFcABbfW34i Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYFW3nRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7siVAP4wF9MCySxbUVov1wjxps6avUqu wbz9BCDDLk6jfu4hrgEAlbYv30gh2RQ7augbM1RwXhXXu6dy5+NWa2iYj8EKjAI= =03uX -----END PGP SIGNATURE----- --=-QsSyTXOcMrFcABbfW34i--