From: Naga Malleswari <nagamalli@riseup.net>
To: 40040@debbugs.gnu.org
Cc: Danny Milosavljevic <dannym@scratchpost.org>
Subject: [bug#40040] Resubmission of patch for Package Description for CRAN Package r-crochet
Date: Thu, 19 Mar 2020 13:43:30 +0530 [thread overview]
Message-ID: <28572a3c-98f8-d9c9-dbbe-eae6e7b55982@riseup.net> (raw)
In-Reply-To: <20200317105014.754f1303@scratchpost.org>
[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]
Hi
Resubmitting v3 of my patch. I really hope i did the changes right.
I am going through documentation and learning the things. For seeking
clarification, Is there any other way i can communicate with you or the
community. I have joined IRC channel as well #guix on freenode.
On 17/03/20 3:20 pm, Danny Milosavljevic wrote:
> Hi,
>
> there's a whitespace error at the bottom of the patch. When I try to apply it
> using "git am" I immediately get a warning message.
>
> Also, the subject you used "gnu: r-crochet: New variable" would mean that
> you add a new variable inside r-chochet, which you don't.
>
> It should be: "gnu: Add r-crochet".
>
> and
>
> "* gnu/packages/cran.scm (r-crochet): New variable.".
>
> Please examine some other commit messages in guix master for a template.
I have done the changes and understood.
> I've invoked guix lint and I get:
>
> gnu/packages/cran.scm:20813:6: r-crochet@2.2.0: use @code or similar ornament instead of quotes
> /home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20814:0: r-crochet@2.2.0: trailing white space on line 20814
> /home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20815:0: r-crochet@2.2.0: trailing white space on line 20815
I am a beginner at this stuff. I am understanding the standards. I have
invoked lint and found no errors.
> Could you fix these problems and submit a new version (v3) of the patch
> (using git send-email --to=40040@debbugs.gnu.org , for example)?
--
Regards
NagaMalli
[-- Attachment #2: 0001-gnu-Add-r-crochet.patch --]
[-- Type: text/x-patch, Size: 1501 bytes --]
From 213ad27a6275d14fe61339ef3adc808f9e8f8b73 Mon Sep 17 00:00:00 2001
From: Naga Malleswari <nagamalli@riseup.net>
Date: Thu, 19 Mar 2020 13:29:05 +0530
Subject: [PATCH] gnu: Add r-crochet.
* gnu/packages/cran.scm (r-crochet): New variable.
---
gnu/packages/cran.scm | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 4c18275eaa..90788ba109 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -20794,3 +20794,25 @@ statistics and p-values of the correlation coefficients.")
scales and utilities, including a spell check function for plot label fields
and an overall emphasis on typography.")
(license license:expat)))
+
+(define-public r-crochet
+ (package
+ (name "r-crochet")
+ (version "2.2.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (cran-uri "crochet" version))
+ (sha256
+ (base32
+ "1cbv79nyycxk6f8ldcsnn2pvgxqlnrj0qs19nhafnq2clxy863k6"))))
+ (build-system r-build-system)
+ (home-page "https://github.com/agrueneberg/crochet")
+ (synopsis "Implementation Helper for Matrix-Like Types")
+ (description
+ "Functions to help implement the extraction / subsetting / indexing
+function @code{[} and replacement function @code{[<-} of custom matrix-like
+types (based on S3, S4, etc.), modeled as closely to the base matrix class
+as possible (with tests to prove it).")
+ (license license:expat)))
+
--
2.20.1
next prev parent reply other threads:[~2020-03-19 8:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 18:16 [bug#40064] Resubmission of patch for Package Description for CRAN Package r-crochet Naga Malleswari
2020-03-14 22:41 ` Tobias Geerinckx-Rice via Guix-patches via
2020-03-15 12:33 ` Naga Malli CH
2020-03-17 9:50 ` [bug#40040] " Danny Milosavljevic
2020-03-19 8:13 ` Naga Malleswari [this message]
2020-03-19 11:38 ` Danny Milosavljevic
2020-03-19 17:35 ` Naga Malleswari
2020-03-19 17:53 ` Danny Milosavljevic
2020-03-19 18:01 ` Naga Malleswari
2020-03-20 17:40 ` Naga Malleswari
2020-03-21 13:18 ` bug#40040: " Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28572a3c-98f8-d9c9-dbbe-eae6e7b55982@riseup.net \
--to=nagamalli@riseup.net \
--cc=40040@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).