From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:42849) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEqJY-00005q-91 for guix-patches@gnu.org; Thu, 19 Mar 2020 04:14:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEqJW-0000WK-Ug for guix-patches@gnu.org; Thu, 19 Mar 2020 04:14:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35735) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jEqJW-0000W9-NW for guix-patches@gnu.org; Thu, 19 Mar 2020 04:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jEqJW-00025n-I1 for guix-patches@gnu.org; Thu, 19 Mar 2020 04:14:02 -0400 Subject: [bug#40040] Resubmission of patch for Package Description for CRAN Package r-crochet Resent-Message-ID: References: <54793c0b-ca82-e80c-1da6-b06ea709b091@riseup.net> <20200317105014.754f1303@scratchpost.org> From: Naga Malleswari Message-ID: <28572a3c-98f8-d9c9-dbbe-eae6e7b55982@riseup.net> Date: Thu, 19 Mar 2020 13:43:30 +0530 MIME-Version: 1.0 In-Reply-To: <20200317105014.754f1303@scratchpost.org> Content-Type: multipart/mixed; boundary="------------553B81F39219096D9CEE3F11" Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 40040@debbugs.gnu.org Cc: Danny Milosavljevic This is a multi-part message in MIME format. --------------553B81F39219096D9CEE3F11 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Hi Resubmitting v3 of my patch. I really hope i did the changes right. I am going through documentation and learning the things. For seeking clarification, Is there any other way i can communicate with you or the community. I have joined IRC channel as well #guix on freenode. On 17/03/20 3:20 pm, Danny Milosavljevic wrote: > Hi, > > there's a whitespace error at the bottom of the patch. When I try to apply it > using "git am" I immediately get a warning message. > > Also, the subject you used "gnu: r-crochet: New variable" would mean that > you add a new variable inside r-chochet, which you don't. > > It should be: "gnu: Add r-crochet". > > and > > "* gnu/packages/cran.scm (r-crochet): New variable.". > > Please examine some other commit messages in guix master for a template. I have done the changes and understood. > I've invoked guix lint and I get: > > gnu/packages/cran.scm:20813:6: r-crochet@2.2.0: use @code or similar ornament instead of quotes > /home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20814:0: r-crochet@2.2.0: trailing white space on line 20814 > /home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20815:0: r-crochet@2.2.0: trailing white space on line 20815 I am a beginner at this stuff. I am understanding the standards. I have invoked lint and found no errors. > Could you fix these problems and submit a new version (v3) of the patch > (using git send-email --to=40040@debbugs.gnu.org , for example)? -- Regards NagaMalli --------------553B81F39219096D9CEE3F11 Content-Type: text/x-patch; charset=UTF-8; name="0001-gnu-Add-r-crochet.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-gnu-Add-r-crochet.patch" >From 213ad27a6275d14fe61339ef3adc808f9e8f8b73 Mon Sep 17 00:00:00 2001 From: Naga Malleswari Date: Thu, 19 Mar 2020 13:29:05 +0530 Subject: [PATCH] gnu: Add r-crochet. * gnu/packages/cran.scm (r-crochet): New variable. --- gnu/packages/cran.scm | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm index 4c18275eaa..90788ba109 100644 --- a/gnu/packages/cran.scm +++ b/gnu/packages/cran.scm @@ -20794,3 +20794,25 @@ statistics and p-values of the correlation coefficients.") scales and utilities, including a spell check function for plot label fields and an overall emphasis on typography.") (license license:expat))) + +(define-public r-crochet + (package + (name "r-crochet") + (version "2.2.0") + (source + (origin + (method url-fetch) + (uri (cran-uri "crochet" version)) + (sha256 + (base32 + "1cbv79nyycxk6f8ldcsnn2pvgxqlnrj0qs19nhafnq2clxy863k6")))) + (build-system r-build-system) + (home-page "https://github.com/agrueneberg/crochet") + (synopsis "Implementation Helper for Matrix-Like Types") + (description + "Functions to help implement the extraction / subsetting / indexing +function @code{[} and replacement function @code{[<-} of custom matrix-like +types (based on S3, S4, etc.), modeled as closely to the base matrix class +as possible (with tests to prove it).") + (license license:expat))) + -- 2.20.1 --------------553B81F39219096D9CEE3F11--