unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Naga Malleswari <nagamalli@riseup.net>
Cc: 40040@debbugs.gnu.org
Subject: [bug#40040] Resubmission of patch for Package Description for CRAN Package r-crochet
Date: Tue, 17 Mar 2020 10:50:14 +0100	[thread overview]
Message-ID: <20200317105014.754f1303@scratchpost.org> (raw)
In-Reply-To: <54793c0b-ca82-e80c-1da6-b06ea709b091@riseup.net>

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

Hi,

there's a whitespace error at the bottom of the patch.  When I try to apply it
using "git am" I immediately get a warning message.

Also, the subject you used "gnu: r-crochet: New variable" would mean that
you add a new variable inside r-chochet, which you don't.

It should be: "gnu: Add r-crochet".

and

"* gnu/packages/cran.scm (r-crochet): New variable.".

Please examine some other commit messages in guix master for a template.

I've invoked guix lint and I get:

gnu/packages/cran.scm:20813:6: r-crochet@2.2.0: use @code or similar ornament instead of quotes
/home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20814:0: r-crochet@2.2.0: trailing white space on line 20814
/home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20815:0: r-crochet@2.2.0: trailing white space on line 20815

Could you fix these problems and submit a new version (v3) of the patch
(using git send-email --to=40040@debbugs.gnu.org , for example)?

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2020-03-17  9:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-14 18:16 [bug#40064] Resubmission of patch for Package Description for CRAN Package r-crochet Naga Malleswari
2020-03-14 22:41 ` Tobias Geerinckx-Rice via Guix-patches via
2020-03-15 12:33   ` Naga Malli CH
2020-03-17  9:50 ` Danny Milosavljevic [this message]
2020-03-19  8:13   ` [bug#40040] " Naga Malleswari
2020-03-19 11:38     ` Danny Milosavljevic
2020-03-19 17:35       ` Naga Malleswari
2020-03-19 17:53         ` Danny Milosavljevic
2020-03-19 18:01           ` Naga Malleswari
2020-03-20 17:40           ` Naga Malleswari
2020-03-21 13:18             ` bug#40040: " Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200317105014.754f1303@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=40040@debbugs.gnu.org \
    --cc=nagamalli@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).