unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Naga Malleswari <nagamalli@riseup.net>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 40040@debbugs.gnu.org
Subject: [bug#40040] Resubmission of patch for Package Description for CRAN Package r-crochet
Date: Thu, 19 Mar 2020 23:05:35 +0530	[thread overview]
Message-ID: <b8fe756b-6dbe-2a50-921b-4d17a2de5ae6@riseup.net> (raw)
In-Reply-To: <20200319123853.46323dcf@scratchpost.org>

Hi

On 19/03/20 5:08 pm, Danny Milosavljevic wrote:
> Hi Naga,
>
> On Thu, 19 Mar 2020 13:43:30 +0530
> Naga Malleswari <nagamalli@riseup.net> wrote:
>
>> Resubmitting v3 of my patch. I really hope i did the changes right.
> There's still an extra newline at the end of your file.
> "git am" still complained.
Understood I will remove it. It dint showup in lint. I will fix that.
>
> Also, we are using automated tools to apply these patches.  For that to work
> right without manual fiddling, please put eventual mail text below the "---"
> and above the "diff" (so it's filtered out by the automated tool).

Actually i dint get the "Eventual mail text" part. All i have is this in
the patch file

---
 gnu/packages/cran.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff

> This time, I had to edit the commit message to remove this conversation
> from the git log.
>
>> I am going through documentation and learning the things. For seeking 
>> clarification, Is there any other way i can communicate with you or the 
>> community. I have joined IRC channel as well #guix on freenode.
> For me, E-Mail is fine.  Some other Guix developers are on IRC in #guix
> on freenode.
>
> Note: It's better to put the version "v3" also in the subject line.
>
> I've checked the license and I don't think that r-crochet is Free Software
> or that the license is expat.  How did you determine the value of the
> license field?

Yes, you are correct. I have downloaded package description through 
guix import cran -r <package>. This resulted expat licence.

But its showing as MIT in the following link.

https://cran.r-project.org/web/packages/crochet/

The authors github page shows a file licence. Does it mean there is no
proper licensing applied for the package? In that case what should we do.


I have tried to check with previous package contributions in cran.scm
and found mismatch to whats available in website, source page to that of
result from guix import cran -r

r-isoband is showing expat in guix import,   MIT in website(
https://cran.r-project.org/web/packages/isoband/index.html) ,  git page
shows a file https://github.com/wilkelab/isoband

r-hrbrthemes is showing expat in guix import,   MIT in website,  git
page shows a file 


 

-- 
Regards
NagaMalli

  reply	other threads:[~2020-03-19 17:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-14 18:16 [bug#40064] Resubmission of patch for Package Description for CRAN Package r-crochet Naga Malleswari
2020-03-14 22:41 ` Tobias Geerinckx-Rice via Guix-patches via
2020-03-15 12:33   ` Naga Malli CH
2020-03-17  9:50 ` [bug#40040] " Danny Milosavljevic
2020-03-19  8:13   ` Naga Malleswari
2020-03-19 11:38     ` Danny Milosavljevic
2020-03-19 17:35       ` Naga Malleswari [this message]
2020-03-19 17:53         ` Danny Milosavljevic
2020-03-19 18:01           ` Naga Malleswari
2020-03-20 17:40           ` Naga Malleswari
2020-03-21 13:18             ` bug#40040: " Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8fe756b-6dbe-2a50-921b-4d17a2de5ae6@riseup.net \
    --to=nagamalli@riseup.net \
    --cc=40040@debbugs.gnu.org \
    --cc=dannym@scratchpost.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).