unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#61753] [PATCH 1/8] gnu: Add emacs-font-lock+.
@ 2023-02-24 14:18 Rostislav Svoboda
  2023-02-24 14:18 ` [bug#61752] [PATCH 2/8] gnu: Add emacs-cfrs Rostislav Svoboda
                   ` (7 more replies)
  0 siblings, 8 replies; 19+ messages in thread
From: Rostislav Svoboda @ 2023-02-24 14:18 UTC (permalink / raw)
  To: 61753; +Cc: Rostislav Svoboda

---
 gnu/packages/emacs-xyz.scm | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bfbf5b1abd..a3103ac3d4 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -122,7 +122,8 @@
 ;;; Copyright © 2023 Simon Streit <simon@netpanic.org>
 ;;; Copyright © 2023 John Kehayias <john.kehayias@protonmail.com>
 ;;; Copyright © 2023 Ivan Vilata-i-Balaguer <ivan@selidor.net>
-;;; Copyright © 2022 Demis Balbach <db@minikn.xyz>
+;;; Copyright © 2023 Demis Balbach <db@minikn.xyz>
+;;; Copyright © 2023 Rostislav Svoboda <Rostislav.Svoboda@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3979,6 +3980,28 @@ (define-public emacs-org-fc
 calculated based on how well you remembered the contents of the card.")
       (license license:gpl3+))))
 
+(define-public emacs-font-lock+
+  (let ((commit "aa1c82d05c9222b09099a0ccd7468e955497940c")
+        (revision "233"))
+    (package
+      (name "emacs-font-lock+")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/emacsmirror/font-lock-plus")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1369r5p6s9c561g5f772lvrpcqxhvyhqd9yk0853hyl03ags9gvs"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/emacsmirror/font-lock-plus")
+      (synopsis "Enhancements to standard library `font-lock.el'")
+      (description
+       "Enhancements to standard library `font-lock.el'")
+      (license license:gpl3+))))
+
 (define-public emacs-font-lock-studio
   (let ((commit "12c35967b31233e06946c70627aa3152dacfe261")
         (revision "1"))
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#61752] [PATCH 2/8] gnu: Add emacs-cfrs.
  2023-02-24 14:18 [bug#61753] [PATCH 1/8] gnu: Add emacs-font-lock+ Rostislav Svoboda
@ 2023-02-24 14:18 ` Rostislav Svoboda
  2023-03-08 15:33   ` bug#61752: " Nicolas Goaziou
  2023-02-24 14:18 ` [bug#61754] [PATCH 3/8] gnu: Add emacs-ac-ispell Rostislav Svoboda
                   ` (6 subsequent siblings)
  7 siblings, 1 reply; 19+ messages in thread
From: Rostislav Svoboda @ 2023-02-24 14:18 UTC (permalink / raw)
  To: 61752; +Cc: Rostislav Svoboda

---
 gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a3103ac3d4..54aad0bf7b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -264,6 +264,34 @@ (define-module (gnu packages emacs-xyz)
 ;;; Emacs hacking.
 ;;;
 
+(define-public emacs-cfrs
+  (package
+    (name "emacs-cfrs")
+    (version "1.6.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Alexander-Miller/cfrs")
+             (commit "f3a21f237b2a54e6b9f8a420a9da42b4f0a63121")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1vf5zm82sx3m1yvq73km8ajapv6rnz41b1jrsif7kh0ijh9vk3qi"))))
+    (build-system emacs-build-system)
+    (inputs (list
+      emacs-s
+      emacs-dash
+      emacs-posframe))
+    (home-page "https://github.com/Alexander-Miller/cfrs")
+    (synopsis "Child Frame Read String")
+    (description
+     "Simple alternative to read-string that allows reading input via a small
+child-frame spawned at the position of the cursor. Its goal is to make the
+string input interface closer to those used in modern GUI programs and to help
+the user with having to switch focus from whatever they are doing currently to
+look at the minibuffer.")
+    (license license:gpl3+)))
+
 (define-public emacs-geiser
   (package
     (name "emacs-geiser")
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#61754] [PATCH 3/8] gnu: Add emacs-ac-ispell.
  2023-02-24 14:18 [bug#61753] [PATCH 1/8] gnu: Add emacs-font-lock+ Rostislav Svoboda
  2023-02-24 14:18 ` [bug#61752] [PATCH 2/8] gnu: Add emacs-cfrs Rostislav Svoboda
@ 2023-02-24 14:18 ` Rostislav Svoboda
  2023-03-08 15:34   ` bug#61754: " Nicolas Goaziou
  2023-02-24 14:18 ` [bug#61755] [PATCH 4/8] gnu: Add emacs-ace-jump-helm-line Rostislav Svoboda
                   ` (5 subsequent siblings)
  7 siblings, 1 reply; 19+ messages in thread
From: Rostislav Svoboda @ 2023-02-24 14:18 UTC (permalink / raw)
  To: 61754; +Cc: Rostislav Svoboda

---
 gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 54aad0bf7b..e71636b2a9 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -264,6 +264,27 @@ (define-module (gnu packages emacs-xyz)
 ;;; Emacs hacking.
 ;;;
 
+(define-public emacs-ac-ispell
+  (package
+    (name "emacs-ac-ispell")
+    (version "0.7")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/emacsorphanage/ac-ispell")
+             (commit "22bace7387e9012002a6a444922f75f9913077b0")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1cq73bdv3lkn8v3nx6aznygqaac9s5i7pvirl8wz9ib31hsgwpbk"))))
+    (build-system emacs-build-system)
+    (inputs (list emacs-auto-complete))
+    (home-page "https://github.com/emacsorphanage/ac-ispell")
+    (synopsis "ispell/aspell completion source for auto-complete")
+    (description
+     "ispell/aspell completion source for auto-complete")
+    (license license:gpl3+)))
+
 (define-public emacs-cfrs
   (package
     (name "emacs-cfrs")
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#61755] [PATCH 4/8] gnu: Add emacs-ace-jump-helm-line.
  2023-02-24 14:18 [bug#61753] [PATCH 1/8] gnu: Add emacs-font-lock+ Rostislav Svoboda
  2023-02-24 14:18 ` [bug#61752] [PATCH 2/8] gnu: Add emacs-cfrs Rostislav Svoboda
  2023-02-24 14:18 ` [bug#61754] [PATCH 3/8] gnu: Add emacs-ac-ispell Rostislav Svoboda
@ 2023-02-24 14:18 ` Rostislav Svoboda
  2023-03-08 15:35   ` bug#61755: " Nicolas Goaziou
  2023-02-24 14:18 ` [bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope Rostislav Svoboda
                   ` (4 subsequent siblings)
  7 siblings, 1 reply; 19+ messages in thread
From: Rostislav Svoboda @ 2023-02-24 14:18 UTC (permalink / raw)
  To: 61755; +Cc: Rostislav Svoboda

---
 gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e71636b2a9..a024ddec6a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -285,6 +285,27 @@ (define-public emacs-ac-ispell
      "ispell/aspell completion source for auto-complete")
     (license license:gpl3+)))
 
+(define-public emacs-ace-jump-helm-line
+  (package
+    (name "emacs-ace-jump-helm-line")
+    (version "0.5.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/cute-jumper/ace-jump-helm-line")
+             (commit "1483055255df3f8ae349f7520f05b1e43ea3ed37")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "191a2g1if1jliikbxkpwmvlp4v1sp541j71xrlymili8ygm0idq5"))))
+    (build-system emacs-build-system)
+    (inputs (list emacs-avy emacs-helm))
+    (home-page "https://github.com/cute-jumper/ace-jump-helm-line")
+    (synopsis "Ace-jump to a candidate in helm window")
+    (description
+     "Ace-jump to a candidate in helm window")
+    (license license:gpl3+)))
+
 (define-public emacs-cfrs
   (package
     (name "emacs-cfrs")
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope.
  2023-02-24 14:18 [bug#61753] [PATCH 1/8] gnu: Add emacs-font-lock+ Rostislav Svoboda
                   ` (2 preceding siblings ...)
  2023-02-24 14:18 ` [bug#61755] [PATCH 4/8] gnu: Add emacs-ace-jump-helm-line Rostislav Svoboda
@ 2023-02-24 14:18 ` Rostislav Svoboda
  2023-03-08 15:42   ` Nicolas Goaziou
  2023-02-24 14:18 ` [bug#61757] [PATCH 6/8] gnu: Add emacs-ac-php Rostislav Svoboda
                   ` (3 subsequent siblings)
  7 siblings, 1 reply; 19+ messages in thread
From: Rostislav Svoboda @ 2023-02-24 14:18 UTC (permalink / raw)
  To: 61756; +Cc: Rostislav Svoboda

---
 gnu/packages/emacs-xyz.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a024ddec6a..b444ab0da0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -36086,6 +36086,26 @@ (define-public emacs-vertico-posframe
 a vertical completion UI.")
     (license license:gpl3+)))
 
+(define-public emacs-xcscope
+  (package
+    (name "emacs-xcscope")
+    (version "1.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/dkogan/xcscope.el")
+             (commit "d228d7593d762e457340f678d14b663ef66d7cee")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0pr85ywp585imjzswm04647nb4iqqvg8jgmbcs5210qmr9kh0z8d"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/dkogan/xcscope.el")
+    (synopsis "cscope interface for (X)Emacs")
+    (description
+     "cscope interface for (X)Emacs")
+    (license license:gpl3+)))
+
 ;;;
 ;;; Avoid adding new packages to the end of this file. To reduce the chances
 ;;; of a merge conflict, place them above by existing packages with similar
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#61757] [PATCH 6/8] gnu: Add emacs-ac-php.
  2023-02-24 14:18 [bug#61753] [PATCH 1/8] gnu: Add emacs-font-lock+ Rostislav Svoboda
                   ` (3 preceding siblings ...)
  2023-02-24 14:18 ` [bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope Rostislav Svoboda
@ 2023-02-24 14:18 ` Rostislav Svoboda
  2023-03-15 23:29   ` bug#61757: " Nicolas Goaziou
  2023-02-24 14:18 ` [bug#61758] [PATCH 7/8] gnu: Add emacs-cider-eval-sexp-fu Rostislav Svoboda
                   ` (2 subsequent siblings)
  7 siblings, 1 reply; 19+ messages in thread
From: Rostislav Svoboda @ 2023-02-24 14:18 UTC (permalink / raw)
  To: 61757; +Cc: Rostislav Svoboda

---
 gnu/packages/emacs-xyz.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b444ab0da0..c5e9b0c792 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -285,6 +285,36 @@ (define-public emacs-ac-ispell
      "ispell/aspell completion source for auto-complete")
     (license license:gpl3+)))
 
+(define-public emacs-ac-php
+  (package
+    (name "emacs-ac-php")
+    (version "2.4.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/xcwen/ac-php")
+             (commit "dc563f4b1efeac8ae75f217532f4c99b4ba417de")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "188hisppjbpia3bmrpsxvkfi8xkirisarnrpvkk3ya4k8lv4z13p"))))
+    (build-system emacs-build-system)
+    (inputs (list
+             emacs-auto-complete
+             emacs-company
+             emacs-helm
+             emacs-dash
+             emacs-php-mode
+             emacs-s
+             emacs-f
+             emacs-popup
+             emacs-xcscope))
+    (home-page "https://github.com/xcwen/ac-php")
+    (synopsis "emacs auto-complete & company-mode for php")
+    (description
+     "emacs auto-complete & company-mode for php")
+    (license license:gpl3+)))
+
 (define-public emacs-ace-jump-helm-line
   (package
     (name "emacs-ace-jump-helm-line")
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#61758] [PATCH 7/8] gnu: Add emacs-cider-eval-sexp-fu.
  2023-02-24 14:18 [bug#61753] [PATCH 1/8] gnu: Add emacs-font-lock+ Rostislav Svoboda
                   ` (4 preceding siblings ...)
  2023-02-24 14:18 ` [bug#61757] [PATCH 6/8] gnu: Add emacs-ac-php Rostislav Svoboda
@ 2023-02-24 14:18 ` Rostislav Svoboda
  2023-03-08 15:36   ` bug#61758: " Nicolas Goaziou
  2023-02-24 14:18 ` [bug#61759] [PATCH 8/8] gnu: Add emacs-afternoon-theme Rostislav Svoboda
  2023-03-08 15:28 ` bug#61753: [PATCH 1/8] gnu: Add emacs-font-lock+ Nicolas Goaziou
  7 siblings, 1 reply; 19+ messages in thread
From: Rostislav Svoboda @ 2023-02-24 14:18 UTC (permalink / raw)
  To: 61758; +Cc: Rostislav Svoboda

---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c5e9b0c792..ab81ea2a43 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -14040,6 +14040,28 @@ (define-public emacs-cider
 CIDER).")
     (license license:gpl3+)))
 
+(define-public emacs-cider-eval-sexp-fu
+  (package
+    (name "emacs-cider-eval-sexp-fu")
+    (version "1.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/clojure-emacs/cider-eval-sexp-fu")
+             (commit "7fd229f1441356866aedba611fd0cf4e89b50921")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "01gky548v3758fyr317lkwsc9aacab6m9d9vk1mrr3qyvmciwd51"))))
+    (build-system emacs-build-system)
+    (inputs (list emacs-eval-sexp-fu-el))
+    (home-page "https://github.com/clojure-emacs/cider-eval-sexp-fu")
+    (synopsis "eval-sexp-fu.el extensions for CIDER")
+    (description
+     "eval-sexp-fu provides tiny improvements to expression evaluation -
+e.g. the expression you've just evaluated would briefly flash and so on.")
+    (license license:gpl3+)))
+
 (define-public emacs-sly
   ;; Update together with sbcl-slynk.
   (let ((commit "4513c382f07a2a2cedb3c046231b69eae2f5e6f0")
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#61759] [PATCH 8/8] gnu: Add emacs-afternoon-theme.
  2023-02-24 14:18 [bug#61753] [PATCH 1/8] gnu: Add emacs-font-lock+ Rostislav Svoboda
                   ` (5 preceding siblings ...)
  2023-02-24 14:18 ` [bug#61758] [PATCH 7/8] gnu: Add emacs-cider-eval-sexp-fu Rostislav Svoboda
@ 2023-02-24 14:18 ` Rostislav Svoboda
  2023-03-08 15:36   ` bug#61759: " Nicolas Goaziou
  2023-03-08 15:28 ` bug#61753: [PATCH 1/8] gnu: Add emacs-font-lock+ Nicolas Goaziou
  7 siblings, 1 reply; 19+ messages in thread
From: Rostislav Svoboda @ 2023-02-24 14:18 UTC (permalink / raw)
  To: 61759; +Cc: Rostislav Svoboda

---
 gnu/packages/emacs-xyz.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ab81ea2a43..fbf8257ffa 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -364,6 +364,26 @@ (define-public emacs-cfrs
 look at the minibuffer.")
     (license license:gpl3+)))
 
+(define-public emacs-afternoon-theme
+  (package
+    (name "emacs-afternoon-theme")
+    (version "0.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "http://github.com/osener/emacs-afternoon-theme")
+             (commit "89b1d778a1f8b385775c122f2bd1c62f0fbf931a")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "19d5d6qs5nwmpf26rsb86ranb5p4236qp7p2b4i88cimcmzspylb"))))
+    (build-system emacs-build-system)
+    (home-page "http://github.com/osener/emacs-afternoon-theme")
+    (synopsis "Dark color theme with a deep blue background")
+    (description
+     "Dark color theme with a deep blue background")
+    (license license:gpl3+)))
+
 (define-public emacs-geiser
   (package
     (name "emacs-geiser")
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 19+ messages in thread

* bug#61753: [PATCH 1/8] gnu: Add emacs-font-lock+.
  2023-02-24 14:18 [bug#61753] [PATCH 1/8] gnu: Add emacs-font-lock+ Rostislav Svoboda
                   ` (6 preceding siblings ...)
  2023-02-24 14:18 ` [bug#61759] [PATCH 8/8] gnu: Add emacs-afternoon-theme Rostislav Svoboda
@ 2023-03-08 15:28 ` Nicolas Goaziou
  7 siblings, 0 replies; 19+ messages in thread
From: Nicolas Goaziou @ 2023-03-08 15:28 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 61753-done

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

> +(define-public emacs-font-lock+

Thank you. I applied your patch with a proper commit message.

> +  (let ((commit "aa1c82d05c9222b09099a0ccd7468e955497940c")
> +        (revision "233"))

Revision is internal to Guix. It does not need to obey versionning
system used by upstream. I set it to 0.

> +    (package
> +      (name "emacs-font-lock+")
> +      (version (git-version "0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/emacsmirror/font-lock-plus")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "1369r5p6s9c561g5f772lvrpcqxhvyhqd9yk0853hyl03ags9gvs"))))
> +      (build-system emacs-build-system)
> +      (home-page "https://github.com/emacsmirror/font-lock-plus")
> +      (synopsis "Enhancements to standard library `font-lock.el'")
> +      (description
> +       "Enhancements to standard library `font-lock.el'")

Descriptions needs to contain only full sentences, so I reworded it.
Also, I replaced `font-lock.el' with Font Lock.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 19+ messages in thread

* bug#61752: [PATCH 2/8] gnu: Add emacs-cfrs.
  2023-02-24 14:18 ` [bug#61752] [PATCH 2/8] gnu: Add emacs-cfrs Rostislav Svoboda
@ 2023-03-08 15:33   ` Nicolas Goaziou
  0 siblings, 0 replies; 19+ messages in thread
From: Nicolas Goaziou @ 2023-03-08 15:33 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 61752-done

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

> ---
> +(define-public emacs-cfrs

Thank you. I applied your patch with a proper commit message.

> +  (package
> +    (name "emacs-cfrs")
> +    (version "1.6.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/Alexander-Miller/cfrs")
> +             (commit "f3a21f237b2a54e6b9f8a420a9da42b4f0a63121")))

We don't put raw commit hashes here. We either use a tag, or let-bind it
to `commit' symbol around the whole package definition. See
emacs-xyz.scm for a truck load of examples.

> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "1vf5zm82sx3m1yvq73km8ajapv6rnz41b1jrsif7kh0ijh9vk3qi"))))
> +    (build-system emacs-build-system)
> +    (inputs (list

Indentation is off here (newline missing before "(list"). Also, Emacs inputs are actually propagated
inputs.

> +      emacs-s
> +      emacs-dash
> +      emacs-posframe))

I re-ordered inputs alphabetically.

> +    (home-page "https://github.com/Alexander-Miller/cfrs")
> +    (synopsis "Child Frame Read String")
> +    (description
> +     "Simple alternative to read-string that allows reading input via a small

I turned this into a full sentence.

> +child-frame spawned at the position of the cursor. Its goal is to make the

Note: Texinfo requires two spaces after full stops.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 19+ messages in thread

* bug#61754: [PATCH 3/8] gnu: Add emacs-ac-ispell.
  2023-02-24 14:18 ` [bug#61754] [PATCH 3/8] gnu: Add emacs-ac-ispell Rostislav Svoboda
@ 2023-03-08 15:34   ` Nicolas Goaziou
  0 siblings, 0 replies; 19+ messages in thread
From: Nicolas Goaziou @ 2023-03-08 15:34 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 61754-done

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

> +(define-public emacs-ac-ispell

Thanks. I applied it with usual changes already explained (let-binding
commit, full sentences in description…).

I also used proper capitalization in description.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 19+ messages in thread

* bug#61755: [PATCH 4/8] gnu: Add emacs-ace-jump-helm-line.
  2023-02-24 14:18 ` [bug#61755] [PATCH 4/8] gnu: Add emacs-ace-jump-helm-line Rostislav Svoboda
@ 2023-03-08 15:35   ` Nicolas Goaziou
  0 siblings, 0 replies; 19+ messages in thread
From: Nicolas Goaziou @ 2023-03-08 15:35 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 61755-done

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

> +(define-public emacs-ace-jump-helm-line

Thanks. I applied it with small tweaks.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 19+ messages in thread

* bug#61758: [PATCH 7/8] gnu: Add emacs-cider-eval-sexp-fu.
  2023-02-24 14:18 ` [bug#61758] [PATCH 7/8] gnu: Add emacs-cider-eval-sexp-fu Rostislav Svoboda
@ 2023-03-08 15:36   ` Nicolas Goaziou
  0 siblings, 0 replies; 19+ messages in thread
From: Nicolas Goaziou @ 2023-03-08 15:36 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 61758-done

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

> +(define-public emacs-cider-eval-sexp-fu

Thank you. Applied with small tweaks.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 19+ messages in thread

* bug#61759: [PATCH 8/8] gnu: Add emacs-afternoon-theme.
  2023-02-24 14:18 ` [bug#61759] [PATCH 8/8] gnu: Add emacs-afternoon-theme Rostislav Svoboda
@ 2023-03-08 15:36   ` Nicolas Goaziou
  0 siblings, 0 replies; 19+ messages in thread
From: Nicolas Goaziou @ 2023-03-08 15:36 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 61759-done

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

> +(define-public emacs-afternoon-theme

Thank you. Applied with small tweaks.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 19+ messages in thread

* [bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope.
  2023-02-24 14:18 ` [bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope Rostislav Svoboda
@ 2023-03-08 15:42   ` Nicolas Goaziou
  2023-03-11 11:59     ` Rostislav Svoboda
  2023-03-11 13:08     ` Rostislav Svoboda
  0 siblings, 2 replies; 19+ messages in thread
From: Nicolas Goaziou @ 2023-03-08 15:42 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 61756

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

> +(define-public emacs-xcscope

Thank you. Some comments follow.

> +  (package

You need to let-bind commit and revision (set to "0" initially) around
here.

> +    (name "emacs-xcscope")
> +    (version "1.0")

Here, you should use

  (git-version "1.0" revision commit)

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/dkogan/xcscope.el")
> +             (commit "d228d7593d762e457340f678d14b663ef66d7cee")))

This should be

  (commit commit)

> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "0pr85ywp585imjzswm04647nb4iqqvg8jgmbcs5210qmr9kh0z8d"))))
> +    (build-system emacs-build-system)

You also need to add `cscope' as an input, and patch "xscope.el" so
`cscope-program' point to the proper binary, using
`emacs-substitute-variables'. See, e.g., emacs-plz package for an
example.

> +    (home-page "https://github.com/dkogan/xcscope.el")
> +    (synopsis "cscope interface for (X)Emacs")

cscope -> Cscope. You can also drop (X) from (X)Emacs.

> +    (description
> +     "cscope interface for (X)Emacs")

This should be a full sentence (with proper capitalization).

> +    (license license:gpl3+)))

License is actually license:gpl2+, per headers in xscope.el file.

>  ;;; Avoid adding new packages to the end of this file. To reduce the chances
>  ;;; of a merge conflict, place them above by existing packages with similar

  ^
  Hmmmmm…

Could you send an updated patch, with another location for the package
definition, and a proper commit message?

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 19+ messages in thread

* [bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope.
  2023-03-08 15:42   ` Nicolas Goaziou
@ 2023-03-11 11:59     ` Rostislav Svoboda
  2023-03-11 13:08     ` Rostislav Svoboda
  1 sibling, 0 replies; 19+ messages in thread
From: Rostislav Svoboda @ 2023-03-11 11:59 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: 61756

Hello Nicolas

> Could you send an updated patch, with another location for the package
> definition, and a proper commit message?

The patch is below. I hope I didn't miss any of your points. (And
thanks for reviewing my patches.)

Regards
Bost


From 95a4714eaa36608f5c3002d769516346b6df3d99 Mon Sep 17 00:00:00 2001
From: Rostislav Svoboda <Rostislav.Svoboda@gmail.com>
Date: Sat, 11 Mar 2023 12:50:08 +0100
Subject: [PATCH] gnu: Add emacs-xcscope.

* gnu/packages/emacs-xyz.scm (emacs-xcscope): New variable.
---
 gnu/packages/emacs-xyz.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 13caf6e882..0c440def40 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -4176,6 +4176,39 @@ (define-public emacs-form-feed
 into mode hooks and is intended to be used that way.")
     (license license:gpl3+)))

+(define-public emacs-xcscope
+  (let ((commit "d228d7593d762e457340f678d14b663ef66d7cee")
+        (revision "1.0"))
+    (package
+      (name "emacs-xcscope")
+      (version (git-version "0.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/dkogan/xcscope.el")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0pr85ywp585imjzswm04647nb4iqqvg8jgmbcs5210qmr9kh0z8d"))))
+      (build-system emacs-build-system)
+      (inputs
+       (list cscope))
+      (arguments
+       (list
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'unpack 'substitute-cscope-path
+              (lambda* (#:key inputs #:allow-other-keys)
+                (emacs-substitute-variables "xcscope.el"
+                  ("cscope-program" (search-input-file inputs
"/bin/cscope"))))))))
+      (home-page "https://github.com/dkogan/xcscope.el")
+      (synopsis "Interface to the source cross-referencing tool Cscope")
+      (description
+       "Xcscope is an Emacs interface to Cscope, the source
cross-referencing tool.
+  See https://cscope.sf.net")
+      (license license:gpl2+))))
+
 (define-public emacs-ggtags
   (package
     (name "emacs-ggtags")
-- 
2.39.2




^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope.
  2023-03-08 15:42   ` Nicolas Goaziou
  2023-03-11 11:59     ` Rostislav Svoboda
@ 2023-03-11 13:08     ` Rostislav Svoboda
  2023-03-15 23:28       ` bug#61756: " Nicolas Goaziou
  1 sibling, 1 reply; 19+ messages in thread
From: Rostislav Svoboda @ 2023-03-11 13:08 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: 61756

Hello,

 I'm resending the patch yet again. See below. I missed that
'(revision "0")' and didn't run `guix lint`. (Sorry, I'm learning)

> You also need to add `cscope' as an input, and patch "xscope.el" so
> `cscope-program' point to the proper binary, using
> `emacs-substitute-variables'. See, e.g., emacs-plz package for an
> example.

`guix style` makes this line too long. I guess I can ignore that, right?

Regards
Bost

From 57e30de01ab56f5917580e43f69ce558187432fb Mon Sep 17 00:00:00 2001
From: Rostislav Svoboda <Rostislav.Svoboda@gmail.com>
Date: Sat, 11 Mar 2023 12:50:08 +0100
Subject: [PATCH 1/3] gnu: Add emacs-xcscope.

* gnu/packages/emacs-xyz.scm (emacs-xcscope): New variable.
---
 gnu/packages/emacs-xyz.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 13caf6e882..509c640b78 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -4176,6 +4176,39 @@ (define-public emacs-form-feed
 into mode hooks and is intended to be used that way.")
     (license license:gpl3+)))

+(define-public emacs-xcscope
+  (let ((commit "d228d7593d762e457340f678d14b663ef66d7cee")
+        (revision "0"))
+    (package
+      (name "emacs-xcscope")
+      (version (git-version "1.5" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/dkogan/xcscope.el")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0pr85ywp585imjzswm04647nb4iqqvg8jgmbcs5210qmr9kh0z8d"))))
+      (build-system emacs-build-system)
+      (inputs (list cscope))
+      (arguments
+       (list
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'unpack 'substitute-cscope-path
+              (lambda* (#:key inputs #:allow-other-keys)
+                (emacs-substitute-variables "xcscope.el"
+                  ("cscope-program" (search-input-file
+                                     inputs "/bin/cscope"))))))))
+      (home-page "https://github.com/dkogan/xcscope.el")
+      (synopsis "Interface to the source cross-referencing tool Cscope")
+      (description
+       "Xcscope is an Emacs interface to Cscope, the source cross-referencing
+tool.  See https://cscope.sf.net")
+      (license license:gpl2+))))
+
 (define-public emacs-ggtags
   (package
     (name "emacs-ggtags")
-- 
2.39.2




^ permalink raw reply related	[flat|nested] 19+ messages in thread

* bug#61756: [PATCH 5/8] gnu: Add emacs-xcscope.
  2023-03-11 13:08     ` Rostislav Svoboda
@ 2023-03-15 23:28       ` Nicolas Goaziou
  0 siblings, 0 replies; 19+ messages in thread
From: Nicolas Goaziou @ 2023-03-15 23:28 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 61756-done

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

>  I'm resending the patch yet again. See below. I missed that
> '(revision "0")' and didn't run `guix lint`. (Sorry, I'm learning)

Applied. Thank you.

> `guix style` makes this line too long. I guess I can ignore that,
> right?

Indeed.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 19+ messages in thread

* bug#61757: [PATCH 6/8] gnu: Add emacs-ac-php.
  2023-02-24 14:18 ` [bug#61757] [PATCH 6/8] gnu: Add emacs-ac-php Rostislav Svoboda
@ 2023-03-15 23:29   ` Nicolas Goaziou
  0 siblings, 0 replies; 19+ messages in thread
From: Nicolas Goaziou @ 2023-03-15 23:29 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 61757-done

Hello,

Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:

> +(define-public emacs-ac-php

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2023-03-15 23:30 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-24 14:18 [bug#61753] [PATCH 1/8] gnu: Add emacs-font-lock+ Rostislav Svoboda
2023-02-24 14:18 ` [bug#61752] [PATCH 2/8] gnu: Add emacs-cfrs Rostislav Svoboda
2023-03-08 15:33   ` bug#61752: " Nicolas Goaziou
2023-02-24 14:18 ` [bug#61754] [PATCH 3/8] gnu: Add emacs-ac-ispell Rostislav Svoboda
2023-03-08 15:34   ` bug#61754: " Nicolas Goaziou
2023-02-24 14:18 ` [bug#61755] [PATCH 4/8] gnu: Add emacs-ace-jump-helm-line Rostislav Svoboda
2023-03-08 15:35   ` bug#61755: " Nicolas Goaziou
2023-02-24 14:18 ` [bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope Rostislav Svoboda
2023-03-08 15:42   ` Nicolas Goaziou
2023-03-11 11:59     ` Rostislav Svoboda
2023-03-11 13:08     ` Rostislav Svoboda
2023-03-15 23:28       ` bug#61756: " Nicolas Goaziou
2023-02-24 14:18 ` [bug#61757] [PATCH 6/8] gnu: Add emacs-ac-php Rostislav Svoboda
2023-03-15 23:29   ` bug#61757: " Nicolas Goaziou
2023-02-24 14:18 ` [bug#61758] [PATCH 7/8] gnu: Add emacs-cider-eval-sexp-fu Rostislav Svoboda
2023-03-08 15:36   ` bug#61758: " Nicolas Goaziou
2023-02-24 14:18 ` [bug#61759] [PATCH 8/8] gnu: Add emacs-afternoon-theme Rostislav Svoboda
2023-03-08 15:36   ` bug#61759: " Nicolas Goaziou
2023-03-08 15:28 ` bug#61753: [PATCH 1/8] gnu: Add emacs-font-lock+ Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).