From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Rostislav Svoboda <rostislav.svoboda@gmail.com>
Cc: 61756@debbugs.gnu.org
Subject: [bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope.
Date: Wed, 08 Mar 2023 16:42:53 +0100 [thread overview]
Message-ID: <87wn3r6ygy.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20230224141819.12675-5-Rostislav.Svoboda@gmail.com> (Rostislav Svoboda's message of "Fri, 24 Feb 2023 15:18:16 +0100")
Hello,
Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:
> +(define-public emacs-xcscope
Thank you. Some comments follow.
> + (package
You need to let-bind commit and revision (set to "0" initially) around
here.
> + (name "emacs-xcscope")
> + (version "1.0")
Here, you should use
(git-version "1.0" revision commit)
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/dkogan/xcscope.el")
> + (commit "d228d7593d762e457340f678d14b663ef66d7cee")))
This should be
(commit commit)
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "0pr85ywp585imjzswm04647nb4iqqvg8jgmbcs5210qmr9kh0z8d"))))
> + (build-system emacs-build-system)
You also need to add `cscope' as an input, and patch "xscope.el" so
`cscope-program' point to the proper binary, using
`emacs-substitute-variables'. See, e.g., emacs-plz package for an
example.
> + (home-page "https://github.com/dkogan/xcscope.el")
> + (synopsis "cscope interface for (X)Emacs")
cscope -> Cscope. You can also drop (X) from (X)Emacs.
> + (description
> + "cscope interface for (X)Emacs")
This should be a full sentence (with proper capitalization).
> + (license license:gpl3+)))
License is actually license:gpl2+, per headers in xscope.el file.
> ;;; Avoid adding new packages to the end of this file. To reduce the chances
> ;;; of a merge conflict, place them above by existing packages with similar
^
Hmmmmm…
Could you send an updated patch, with another location for the package
definition, and a proper commit message?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2023-03-08 15:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 14:18 [bug#61753] [PATCH 1/8] gnu: Add emacs-font-lock+ Rostislav Svoboda
2023-02-24 14:18 ` [bug#61752] [PATCH 2/8] gnu: Add emacs-cfrs Rostislav Svoboda
2023-03-08 15:33 ` bug#61752: " Nicolas Goaziou
2023-02-24 14:18 ` [bug#61754] [PATCH 3/8] gnu: Add emacs-ac-ispell Rostislav Svoboda
2023-03-08 15:34 ` bug#61754: " Nicolas Goaziou
2023-02-24 14:18 ` [bug#61755] [PATCH 4/8] gnu: Add emacs-ace-jump-helm-line Rostislav Svoboda
2023-03-08 15:35 ` bug#61755: " Nicolas Goaziou
2023-02-24 14:18 ` [bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope Rostislav Svoboda
2023-03-08 15:42 ` Nicolas Goaziou [this message]
2023-03-11 11:59 ` Rostislav Svoboda
2023-03-11 13:08 ` Rostislav Svoboda
2023-03-15 23:28 ` bug#61756: " Nicolas Goaziou
2023-02-24 14:18 ` [bug#61757] [PATCH 6/8] gnu: Add emacs-ac-php Rostislav Svoboda
2023-03-15 23:29 ` bug#61757: " Nicolas Goaziou
2023-02-24 14:18 ` [bug#61758] [PATCH 7/8] gnu: Add emacs-cider-eval-sexp-fu Rostislav Svoboda
2023-03-08 15:36 ` bug#61758: " Nicolas Goaziou
2023-02-24 14:18 ` [bug#61759] [PATCH 8/8] gnu: Add emacs-afternoon-theme Rostislav Svoboda
2023-03-08 15:36 ` bug#61759: " Nicolas Goaziou
2023-03-08 15:28 ` bug#61753: [PATCH 1/8] gnu: Add emacs-font-lock+ Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn3r6ygy.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=61756@debbugs.gnu.org \
--cc=rostislav.svoboda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).