From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Rostislav Svoboda <rostislav.svoboda@gmail.com>
Cc: 61752-done@debbugs.gnu.org
Subject: bug#61752: [PATCH 2/8] gnu: Add emacs-cfrs.
Date: Wed, 08 Mar 2023 16:33:06 +0100 [thread overview]
Message-ID: <87ilfb8dhp.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20230224141819.12675-2-Rostislav.Svoboda@gmail.com> (Rostislav Svoboda's message of "Fri, 24 Feb 2023 15:18:13 +0100")
Hello,
Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:
> ---
> +(define-public emacs-cfrs
Thank you. I applied your patch with a proper commit message.
> + (package
> + (name "emacs-cfrs")
> + (version "1.6.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/Alexander-Miller/cfrs")
> + (commit "f3a21f237b2a54e6b9f8a420a9da42b4f0a63121")))
We don't put raw commit hashes here. We either use a tag, or let-bind it
to `commit' symbol around the whole package definition. See
emacs-xyz.scm for a truck load of examples.
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "1vf5zm82sx3m1yvq73km8ajapv6rnz41b1jrsif7kh0ijh9vk3qi"))))
> + (build-system emacs-build-system)
> + (inputs (list
Indentation is off here (newline missing before "(list"). Also, Emacs inputs are actually propagated
inputs.
> + emacs-s
> + emacs-dash
> + emacs-posframe))
I re-ordered inputs alphabetically.
> + (home-page "https://github.com/Alexander-Miller/cfrs")
> + (synopsis "Child Frame Read String")
> + (description
> + "Simple alternative to read-string that allows reading input via a small
I turned this into a full sentence.
> +child-frame spawned at the position of the cursor. Its goal is to make the
Note: Texinfo requires two spaces after full stops.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2023-03-08 15:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 14:18 [bug#61753] [PATCH 1/8] gnu: Add emacs-font-lock+ Rostislav Svoboda
2023-02-24 14:18 ` [bug#61752] [PATCH 2/8] gnu: Add emacs-cfrs Rostislav Svoboda
2023-03-08 15:33 ` Nicolas Goaziou [this message]
2023-02-24 14:18 ` [bug#61754] [PATCH 3/8] gnu: Add emacs-ac-ispell Rostislav Svoboda
2023-03-08 15:34 ` bug#61754: " Nicolas Goaziou
2023-02-24 14:18 ` [bug#61755] [PATCH 4/8] gnu: Add emacs-ace-jump-helm-line Rostislav Svoboda
2023-03-08 15:35 ` bug#61755: " Nicolas Goaziou
2023-02-24 14:18 ` [bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope Rostislav Svoboda
2023-03-08 15:42 ` Nicolas Goaziou
2023-03-11 11:59 ` Rostislav Svoboda
2023-03-11 13:08 ` Rostislav Svoboda
2023-03-15 23:28 ` bug#61756: " Nicolas Goaziou
2023-02-24 14:18 ` [bug#61757] [PATCH 6/8] gnu: Add emacs-ac-php Rostislav Svoboda
2023-03-15 23:29 ` bug#61757: " Nicolas Goaziou
2023-02-24 14:18 ` [bug#61758] [PATCH 7/8] gnu: Add emacs-cider-eval-sexp-fu Rostislav Svoboda
2023-03-08 15:36 ` bug#61758: " Nicolas Goaziou
2023-02-24 14:18 ` [bug#61759] [PATCH 8/8] gnu: Add emacs-afternoon-theme Rostislav Svoboda
2023-03-08 15:36 ` bug#61759: " Nicolas Goaziou
2023-03-08 15:28 ` bug#61753: [PATCH 1/8] gnu: Add emacs-font-lock+ Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilfb8dhp.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=61752-done@debbugs.gnu.org \
--cc=rostislav.svoboda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).