From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id qI4FMkatCGS9IgAASxT56A (envelope-from ) for ; Wed, 08 Mar 2023 16:44:06 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id IJgbMUatCGS/RQEAG6o9tA (envelope-from ) for ; Wed, 08 Mar 2023 16:44:06 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8D74845F9A for ; Wed, 8 Mar 2023 16:44:06 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678290246; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=o2wJF9L31+vFssQ9X+xW61w7rA4pOPnEyeevm82uPTA=; b=MqR51quyOBukaxM7lCA90xiG9I7nZz3lR73wjQSNcg8VeQedNMQ+ZvfMqjOo9oeX+9Cn1q joBXUXlsufd0YlOkn/8fxrvXo+pTD7IQB0Sum5YaHGUfPTKa1gyM+zlV7H3EAZT5DX5u5+ n0tCRxFcBGJLpkAb3pglfRJ6kDN2pSqz60J88K2XvKpKizfwl4OrGWGXK7zicgDCapNhSp y+CyN4x69peBs/RXvwlQ+vWDCV9Tcn2UFa4Gw1hkw1lIVWPYlM3P2XR1/QsFS8H8xPb0Nt LgpmKM/P+X8PrhrYTBDlZ73Y1/JGBnj/1qaVVhBLlffOrR394mO5wOxq5/Wa+Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678290246; a=rsa-sha256; cv=none; b=fQA2jwFWzNJFgKKicKGSUbj4GPAkW3uQ3/HVNqRiYlbeUdVI2VPXzlvHsbZlqFtSSLvF9d BdgdlLmqZ0GJQlmQsB8HQyK+K1e1SKsJt/1RChdkmw+pbtr2DZsRThPWAwD/Mr8nRa43Tu TXAKSNxYGQQwo5kqPtOD+szvFumZNkQXDhaCePRnMPT/50xi7/3rIEVq7XhqqHot0Zs8eH rn+R9ZMDapfCLgvvi28/HaSiFqVXkdV5NAVoeltVKZ9BhEF2HWlRTY0t5qBmQ6gKu4ZOsz nP6Um2x8fjY3shZ2UWk+5wLhyshyQ/E5aXBWSP5MRd3IJbsMn6ULthL81oS2og== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZvxT-0008Nk-SA; Wed, 08 Mar 2023 10:44:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZvxS-0008Nc-BT for guix-patches@gnu.org; Wed, 08 Mar 2023 10:44:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZvxS-00062m-2j for guix-patches@gnu.org; Wed, 08 Mar 2023 10:44:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZvxR-00080l-Um for guix-patches@gnu.org; Wed, 08 Mar 2023 10:44:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 08 Mar 2023 15:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61756 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Rostislav Svoboda Cc: 61756@debbugs.gnu.org Received: via spool by 61756-submit@debbugs.gnu.org id=B61756.167829019130715 (code B ref 61756); Wed, 08 Mar 2023 15:44:01 +0000 Received: (at 61756) by debbugs.gnu.org; 8 Mar 2023 15:43:11 +0000 Received: from localhost ([127.0.0.1]:49992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZvwd-0007zK-2C for submit@debbugs.gnu.org; Wed, 08 Mar 2023 10:43:11 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:49497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZvwb-0007z6-M8 for 61756@debbugs.gnu.org; Wed, 08 Mar 2023 10:43:10 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 535F1100004; Wed, 8 Mar 2023 15:42:59 +0000 (UTC) From: Nicolas Goaziou References: <20230224141819.12675-1-Rostislav.Svoboda@gmail.com> <20230224141819.12675-5-Rostislav.Svoboda@gmail.com> Date: Wed, 08 Mar 2023 16:42:53 +0100 In-Reply-To: <20230224141819.12675-5-Rostislav.Svoboda@gmail.com> (Rostislav Svoboda's message of "Fri, 24 Feb 2023 15:18:16 +0100") Message-ID: <87wn3r6ygy.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Scanner: scn0.migadu.com X-Migadu-Queue-Id: 8D74845F9A X-Spam-Score: -3.60 X-Migadu-Spam-Score: -3.60 List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: o8hyLmtFTL9A Hello, Rostislav Svoboda writes: > +(define-public emacs-xcscope Thank you. Some comments follow. > + (package You need to let-bind commit and revision (set to "0" initially) around here. > + (name "emacs-xcscope") > + (version "1.0") Here, you should use (git-version "1.0" revision commit) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/dkogan/xcscope.el") > + (commit "d228d7593d762e457340f678d14b663ef66d7cee"))) This should be (commit commit) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "0pr85ywp585imjzswm04647nb4iqqvg8jgmbcs5210qmr9kh0z8d"))= )) > + (build-system emacs-build-system) You also need to add `cscope' as an input, and patch "xscope.el" so `cscope-program' point to the proper binary, using `emacs-substitute-variables'. See, e.g., emacs-plz package for an example. > + (home-page "https://github.com/dkogan/xcscope.el") > + (synopsis "cscope interface for (X)Emacs") cscope -> Cscope. You can also drop (X) from (X)Emacs. > + (description > + "cscope interface for (X)Emacs") This should be a full sentence (with proper capitalization). > + (license license:gpl3+))) License is actually license:gpl2+, per headers in xscope.el file. > ;;; Avoid adding new packages to the end of this file. To reduce the cha= nces > ;;; of a merge conflict, place them above by existing packages with simi= lar ^ Hmmmmm=E2=80=A6 Could you send an updated patch, with another location for the package definition, and a proper commit message? Regards, --=20 Nicolas Goaziou