* [bug#41671] [PATCH] gnu: Add emacs-glsl-mode
@ 2020-06-02 19:41 Fredrik Salomonsson
2020-06-02 20:04 ` Nicolas Goaziou
2020-06-02 21:02 ` Fredrik Salomonsson
0 siblings, 2 replies; 5+ messages in thread
From: Fredrik Salomonsson @ 2020-06-02 19:41 UTC (permalink / raw)
To: 41671; +Cc: Fredrik Salomonsson
* gnu/packages/emacs-xyz.scm (emacs-glsl-mode): New variable
---
gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5f0a0184f9..94fd5cb1c8 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -22693,6 +22693,34 @@ sense in the @samp{To} and @samp{Cc} headers). When in the message body, this
executes a different function (default: @code{indent-relative}).")
(license license:gpl2+))))
+(define-public emacs-glsl-mode
+ ;; No tag, version grabbed from source .el file.
+ (let ((commit "b07112016436d9634cd4ef747f9af6b01366d136")
+ (revision "0"))
+ (package
+ (name "emacs-glsl-mode")
+ (version (git-version "2.4" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/jimhourihan/glsl-mode")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s"))))
+ (build-system emacs-build-system)
+ (home-page
+ "https://github.com/jimhourihan/glsl-mode")
+ (synopsis
+ "Major mode for Open GLSL shader files")
+ (description
+ "Major mode for editing OpenGLSL grammar files, usually files ending with
+`.vert', `.frag', `.glsl', `.geom'. Is is based on c-mode plus some
+features and pre-specified fontifications.")
+ (license license:gpl3+))))
+
(define-public emacs-gnus-harvest
(let ((commit "feda071a87b799bd5d23cacde3ee71f0b166e75d")
(revision "0"))
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [bug#41671] [PATCH] gnu: Add emacs-glsl-mode
2020-06-02 19:41 [bug#41671] [PATCH] gnu: Add emacs-glsl-mode Fredrik Salomonsson
@ 2020-06-02 20:04 ` Nicolas Goaziou
2020-06-02 21:08 ` Fredrik Salomonsson
2020-06-02 21:02 ` Fredrik Salomonsson
1 sibling, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2020-06-02 20:04 UTC (permalink / raw)
To: Fredrik Salomonsson; +Cc: 41671
Hello,
Fredrik Salomonsson <plattfot@gmail.com> writes:
> * gnu/packages/emacs-xyz.scm (emacs-glsl-mode): New variable
Thank you. Some comments follow.
Nitpick: you need full stops at the end of each sentence in the commit
message.
> + (sha256
> + (base32
> + "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s"))))
Nitpick: could you move the hash on the same line as `base32'?
> + (build-system emacs-build-system)
> + (home-page
> + "https://github.com/jimhourihan/glsl-mode")
Nitpick: could you move the URL on the same line as `home-page'?
> + (synopsis
> + "Major mode for Open GLSL shader files")
Nitpick: … guess what… ;)
> + (description
> + "Major mode for editing OpenGLSL grammar files, usually files ending with
> +`.vert', `.frag', `.glsl', `.geom'.
This should be a complete sentence, e.g.,
The library provides a major mode…
Note that Texinfo syntax for file extensions is @file, so the rest of
the sentence ought to be:
files ending with @file{.vert}, @file{.frag}…
> Is is based on c-mode plus some
Typo and nitpick: "It is based on C mode"
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread* [bug#41671] [PATCH] gnu: Add emacs-glsl-mode
2020-06-02 20:04 ` Nicolas Goaziou
@ 2020-06-02 21:08 ` Fredrik Salomonsson
0 siblings, 0 replies; 5+ messages in thread
From: Fredrik Salomonsson @ 2020-06-02 21:08 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 41671
[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]
Hi Nicolas,
Den tis 2 juni 2020 kl 13:04 skrev Nicolas Goaziou <mail@nicolasgoaziou.fr>:
> Nitpick: you need full stops at the end of each sentence in the commit
> message.
>
> > + (sha256
> > + (base32
> > + "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s"))))
>
> Nitpick: could you move the hash on the same line as `base32'?
>
> > + (build-system emacs-build-system)
> > + (home-page
> > + "https://github.com/jimhourihan/glsl-mode")
>
> Nitpick: could you move the URL on the same line as `home-page'?
>
> > + (synopsis
> > + "Major mode for Open GLSL shader files")
>
> Nitpick: … guess what… ;)
>
> > + (description
> > + "Major mode for editing OpenGLSL grammar files, usually files
> ending with
> > +`.vert', `.frag', `.glsl', `.geom'.
>
> This should be a complete sentence, e.g.,
>
> The library provides a major mode…
>
> Note that Texinfo syntax for file extensions is @file, so the rest of
> the sentence ought to be:
>
> files ending with @file{.vert}, @file{.frag}…
>
> > Is is based on c-mode plus some
>
> Typo and nitpick: "It is based on C mode"
>
> Could you send an updated patch?
>
Thank you for the speedy response. I sent in a new patch, which should fix
all the things mentioned above.
Let me know if it ended up in the right place. I'm pretty new with the git
send-email workflow.
--
s/Fred[re]+i[ck]+/Fredrik/g
[-- Attachment #2: Type: text/html, Size: 2278 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#41671] [PATCH] gnu: Add emacs-glsl-mode.
2020-06-02 19:41 [bug#41671] [PATCH] gnu: Add emacs-glsl-mode Fredrik Salomonsson
2020-06-02 20:04 ` Nicolas Goaziou
@ 2020-06-02 21:02 ` Fredrik Salomonsson
2020-06-04 12:59 ` bug#41671: " Nicolas Goaziou
1 sibling, 1 reply; 5+ messages in thread
From: Fredrik Salomonsson @ 2020-06-02 21:02 UTC (permalink / raw)
To: 41671; +Cc: Fredrik Salomonsson
* gnu/packages/emacs-xyz.scm (emacs-glsl-mode): New variable.
---
gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5f0a0184f9..2701081b9c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -22693,6 +22693,32 @@ sense in the @samp{To} and @samp{Cc} headers). When in the message body, this
executes a different function (default: @code{indent-relative}).")
(license license:gpl2+))))
+(define-public emacs-glsl-mode
+ ;; No tag, version grabbed from source .el file.
+ (let ((commit "b07112016436d9634cd4ef747f9af6b01366d136")
+ (revision "0"))
+ (package
+ (name "emacs-glsl-mode")
+ (version (git-version "2.4" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/jimhourihan/glsl-mode")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/jimhourihan/glsl-mode")
+ (synopsis "Major mode for Open GLSL shader files")
+ (description
+ "This package provides a major mode for editing OpenGLSL grammar files,
+usually files ending with @file{.vert}, @file{.frag}, @file{.glsl} or
+@file{.geom}. It is based on C mode plus some features and pre-specified
+fontifications.")
+ (license license:gpl3+))))
+
(define-public emacs-gnus-harvest
(let ((commit "feda071a87b799bd5d23cacde3ee71f0b166e75d")
(revision "0"))
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-06-04 13:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02 19:41 [bug#41671] [PATCH] gnu: Add emacs-glsl-mode Fredrik Salomonsson
2020-06-02 20:04 ` Nicolas Goaziou
2020-06-02 21:08 ` Fredrik Salomonsson
2020-06-02 21:02 ` Fredrik Salomonsson
2020-06-04 12:59 ` bug#41671: " Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).