From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yA1EDkmx1l7SYAAA0tVLHw (envelope-from ) for ; Tue, 02 Jun 2020 20:06:33 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UM8/Ckmx1l7BewAA1q6Kng (envelope-from ) for ; Tue, 02 Jun 2020 20:06:33 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C7E99940145 for ; Tue, 2 Jun 2020 20:06:32 +0000 (UTC) Received: from localhost ([::1]:34412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgDB9-0002Tp-Gr for larch@yhetil.org; Tue, 02 Jun 2020 16:06:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgD9i-0000Ws-7s for guix-patches@gnu.org; Tue, 02 Jun 2020 16:05:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57727) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgD9h-00049l-R9 for guix-patches@gnu.org; Tue, 02 Jun 2020 16:05:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jgD9h-0002ea-KU for guix-patches@gnu.org; Tue, 02 Jun 2020 16:05:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41671] [PATCH] gnu: Add emacs-glsl-mode Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 02 Jun 2020 20:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41671 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Fredrik Salomonsson Cc: 41671@debbugs.gnu.org Received: via spool by 41671-submit@debbugs.gnu.org id=B41671.159112825010140 (code B ref 41671); Tue, 02 Jun 2020 20:05:01 +0000 Received: (at 41671) by debbugs.gnu.org; 2 Jun 2020 20:04:10 +0000 Received: from localhost ([127.0.0.1]:41040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgD8s-0002dT-GD for submit@debbugs.gnu.org; Tue, 02 Jun 2020 16:04:10 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:52755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgD8q-0002dD-3e for 41671@debbugs.gnu.org; Tue, 02 Jun 2020 16:04:09 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 4F7A1240006; Tue, 2 Jun 2020 20:04:01 +0000 (UTC) From: Nicolas Goaziou References: <20200602194137.30412-1-plattfot@gmail.com> Date: Tue, 02 Jun 2020 22:04:00 +0200 In-Reply-To: <20200602194137.30412-1-plattfot@gmail.com> (Fredrik Salomonsson's message of "Tue, 2 Jun 2020 12:41:37 -0700") Message-ID: <878sh5dykv.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: yiWDqUJfwCXI Hello, Fredrik Salomonsson writes: > * gnu/packages/emacs-xyz.scm (emacs-glsl-mode): New variable Thank you. Some comments follow. Nitpick: you need full stops at the end of each sentence in the commit message. > + (sha256 > + (base32 > + "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s")))) Nitpick: could you move the hash on the same line as `base32'? > + (build-system emacs-build-system) > + (home-page > + "https://github.com/jimhourihan/glsl-mode") Nitpick: could you move the URL on the same line as `home-page'? > + (synopsis > + "Major mode for Open GLSL shader files") Nitpick: =E2=80=A6 guess what=E2=80=A6 ;) > + (description > + "Major mode for editing OpenGLSL grammar files, usually files end= ing with > +`.vert', `.frag', `.glsl', `.geom'. This should be a complete sentence, e.g., The library provides a major mode=E2=80=A6 Note that Texinfo syntax for file extensions is @file, so the rest of the sentence ought to be: files ending with @file{.vert}, @file{.frag}=E2=80=A6 > Is is based on c-mode plus some Typo and nitpick: "It is based on C mode" Could you send an updated patch? Regards, --=20 Nicolas Goaziou