From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Fredrik Salomonsson <plattfot@gmail.com>
Cc: 41671@debbugs.gnu.org
Subject: [bug#41671] [PATCH] gnu: Add emacs-glsl-mode
Date: Tue, 02 Jun 2020 22:04:00 +0200 [thread overview]
Message-ID: <878sh5dykv.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20200602194137.30412-1-plattfot@gmail.com> (Fredrik Salomonsson's message of "Tue, 2 Jun 2020 12:41:37 -0700")
Hello,
Fredrik Salomonsson <plattfot@gmail.com> writes:
> * gnu/packages/emacs-xyz.scm (emacs-glsl-mode): New variable
Thank you. Some comments follow.
Nitpick: you need full stops at the end of each sentence in the commit
message.
> + (sha256
> + (base32
> + "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s"))))
Nitpick: could you move the hash on the same line as `base32'?
> + (build-system emacs-build-system)
> + (home-page
> + "https://github.com/jimhourihan/glsl-mode")
Nitpick: could you move the URL on the same line as `home-page'?
> + (synopsis
> + "Major mode for Open GLSL shader files")
Nitpick: … guess what… ;)
> + (description
> + "Major mode for editing OpenGLSL grammar files, usually files ending with
> +`.vert', `.frag', `.glsl', `.geom'.
This should be a complete sentence, e.g.,
The library provides a major mode…
Note that Texinfo syntax for file extensions is @file, so the rest of
the sentence ought to be:
files ending with @file{.vert}, @file{.frag}…
> Is is based on c-mode plus some
Typo and nitpick: "It is based on C mode"
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-06-02 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 19:41 [bug#41671] [PATCH] gnu: Add emacs-glsl-mode Fredrik Salomonsson
2020-06-02 20:04 ` Nicolas Goaziou [this message]
2020-06-02 21:08 ` Fredrik Salomonsson
2020-06-02 21:02 ` Fredrik Salomonsson
2020-06-04 12:59 ` bug#41671: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sh5dykv.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=41671@debbugs.gnu.org \
--cc=plattfot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).