From: Fredrik Salomonsson <plattfot@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 41671@debbugs.gnu.org
Subject: [bug#41671] [PATCH] gnu: Add emacs-glsl-mode
Date: Tue, 2 Jun 2020 14:08:33 -0700 [thread overview]
Message-ID: <CABZcOASQamWoC++p1gQJ7FnbpqTojHomptObZmf=j3GYFiiQ3w@mail.gmail.com> (raw)
In-Reply-To: <878sh5dykv.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]
Hi Nicolas,
Den tis 2 juni 2020 kl 13:04 skrev Nicolas Goaziou <mail@nicolasgoaziou.fr>:
> Nitpick: you need full stops at the end of each sentence in the commit
> message.
>
> > + (sha256
> > + (base32
> > + "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s"))))
>
> Nitpick: could you move the hash on the same line as `base32'?
>
> > + (build-system emacs-build-system)
> > + (home-page
> > + "https://github.com/jimhourihan/glsl-mode")
>
> Nitpick: could you move the URL on the same line as `home-page'?
>
> > + (synopsis
> > + "Major mode for Open GLSL shader files")
>
> Nitpick: … guess what… ;)
>
> > + (description
> > + "Major mode for editing OpenGLSL grammar files, usually files
> ending with
> > +`.vert', `.frag', `.glsl', `.geom'.
>
> This should be a complete sentence, e.g.,
>
> The library provides a major mode…
>
> Note that Texinfo syntax for file extensions is @file, so the rest of
> the sentence ought to be:
>
> files ending with @file{.vert}, @file{.frag}…
>
> > Is is based on c-mode plus some
>
> Typo and nitpick: "It is based on C mode"
>
> Could you send an updated patch?
>
Thank you for the speedy response. I sent in a new patch, which should fix
all the things mentioned above.
Let me know if it ended up in the right place. I'm pretty new with the git
send-email workflow.
--
s/Fred[re]+i[ck]+/Fredrik/g
[-- Attachment #2: Type: text/html, Size: 2278 bytes --]
next prev parent reply other threads:[~2020-06-02 21:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 19:41 [bug#41671] [PATCH] gnu: Add emacs-glsl-mode Fredrik Salomonsson
2020-06-02 20:04 ` Nicolas Goaziou
2020-06-02 21:08 ` Fredrik Salomonsson [this message]
2020-06-02 21:02 ` Fredrik Salomonsson
2020-06-04 12:59 ` bug#41671: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABZcOASQamWoC++p1gQJ7FnbpqTojHomptObZmf=j3GYFiiQ3w@mail.gmail.com' \
--to=plattfot@gmail.com \
--cc=41671@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).