From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:56956) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jE8sJ-0005oi-PF for guix-patches@gnu.org; Tue, 17 Mar 2020 05:51:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jE8sI-0004rP-KF for guix-patches@gnu.org; Tue, 17 Mar 2020 05:51:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60454) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jE8sI-0004qV-GJ for guix-patches@gnu.org; Tue, 17 Mar 2020 05:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jE8sI-0007BJ-Ep for guix-patches@gnu.org; Tue, 17 Mar 2020 05:51:02 -0400 Subject: [bug#40040] Resubmission of patch for Package Description for CRAN Package r-crochet Resent-Message-ID: Date: Tue, 17 Mar 2020 10:50:14 +0100 From: Danny Milosavljevic Message-ID: <20200317105014.754f1303@scratchpost.org> In-Reply-To: <54793c0b-ca82-e80c-1da6-b06ea709b091@riseup.net> References: <54793c0b-ca82-e80c-1da6-b06ea709b091@riseup.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Mv.SXon0XZh4ZPlzi.gtQaQ"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Naga Malleswari Cc: 40040@debbugs.gnu.org --Sig_/Mv.SXon0XZh4ZPlzi.gtQaQ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, there's a whitespace error at the bottom of the patch. When I try to apply= it using "git am" I immediately get a warning message. Also, the subject you used "gnu: r-crochet: New variable" would mean that you add a new variable inside r-chochet, which you don't. It should be: "gnu: Add r-crochet". and "* gnu/packages/cran.scm (r-crochet): New variable.". Please examine some other commit messages in guix master for a template. I've invoked guix lint and I get: gnu/packages/cran.scm:20813:6: r-crochet@2.2.0: use @code or similar orname= nt instead of quotes /home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20814:0: r-crochet@2.2.0= : trailing white space on line 20814 /home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20815:0: r-crochet@2.2.0= : trailing white space on line 20815 Could you fix these problems and submit a new version (v3) of the patch (using git send-email --to=3D40040@debbugs.gnu.org , for example)? --Sig_/Mv.SXon0XZh4ZPlzi.gtQaQ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl5wnVYACgkQ5xo1VCww uqVfkwf+Prq22RQBkTBLOz4A7uU6O/U6DQr3n1yLokchlYceYcJfNinF8ikNlB/g yppQF9ttZNZSnL2W/hxMGbyxHYcFAgmW5ROUMDTI1OS6D/uwSMG3kZB925J7DlSt Rv6w23juNSJiwE6QSpb71FN0QZqwv6Lt0oKFUGqY3++PMT9pr0li8VzdD7dgQ8UT 2wOH2sJPcDpAbA6/PG6BvKzsu1XLHazeTBDQ/la7tm1y9M7pr+xlbJndM5Ynchuu neQ5JzjJOsXp/qiRl7MFOCTmWZApoLI/qIEoESdO9V7L6nRT96EbnSUfUZDnlMqC 7GXGuHw82Ex+blsbEj7TMcGDniEmDA== =vkFd -----END PGP SIGNATURE----- --Sig_/Mv.SXon0XZh4ZPlzi.gtQaQ--