[bug#39989] [PATCH 0/0] Thunar: fix launching applications

[bug#39989] [PATCH 0/0] Thunar: fix launching applications

[Jan Wielkiewicz]

This patch fixes launching applications in Thunar by making
gio-launch-desktop visible to it.

Jan Wielkiewicz

[bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix launching programs.

[Jan Wielkiewicz]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 1618 bytes --]

---
 gnu/packages/xfce.scm | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 3aacfb0c7c..592b825812 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -11,6 +11,7 @@
 ;;; Copyright © 2019 Pkill -9 <pkill9@runbox.com>
 ;;; Copyright © 2019 L  p R n  d n <guix@lprndn.info>
 ;;; Copyright © 2019 Ingo Ruhnke <grumbel@gmail.com>
+;;; Copyright © 2020 Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -660,6 +661,7 @@ like appearance, display, keyboard and mouse settings.")
        ("intltool" ,intltool)))
     (inputs
      `(("exo" ,exo)
+       ("glib:bin" ,glib "bin")
        ("libexif" ,libexif)
        ("libgudev" ,libgudev)
        ("libnotify" ,libnotify)
@@ -667,6 +669,17 @@ like appearance, display, keyboard and mouse settings.")
        ("pcre" ,pcre)
        ("xfce4-panel" ,xfce4-panel)
        ("startup-notification" ,startup-notification)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'wrap-program
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out"))
+                   (glib-bin (assoc-ref inputs "glib:bin")))
+               (wrap-program (string-append out "/bin/thunar")
+                 `("PATH" ":" prefix (,(string-append glib-bin
+                                                      "/bin")))))
+             #t)))))
     (home-page "https://www.xfce.org/")
     (synopsis "Xfce file manager")
     (description
-- 
2.25.1

[bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix launching programs.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

Hi,

I'm all for fixing this problem, but it would be great to add a comment on
which executables thunar tries to find in glib:bin.

I've checked glib:bin and it has:

gapplication
gdbus
gdbus-codegen
gio
gio-querymodules
glib-compile-resources
glib-compile-schemas
glib-genmarshal
glib-gettextize
glib-mkenums
gobject-query
gresource
gsettings
gtester
gtester-report

A lot of those make no sense for thunar to use anyway.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix launching programs.

[Jan]

On Mon, 9 Mar 2020 18:11:08 +0100
Danny Milosavljevic <dannym@scratchpost.org> wrote:

> Hi,
> 
> I'm all for fixing this problem, but it would be great to add a
> comment on which executables thunar tries to find in glib:bin.
Should I close the issue, add a commit and reopen the issue, or is
there a more clever way of doing so?

> I've checked glib:bin and it has:
> 
> gapplication
> gdbus
> gdbus-codegen
> gio
> gio-querymodules
> glib-compile-resources
> glib-compile-schemas
> glib-genmarshal
> glib-gettextize
> glib-mkenums
> gobject-query
> gresource
> gsettings
> gtester
> gtester-report
> 
> A lot of those make no sense for thunar to use anyway.

AFAIK it only needs gio-launch-desktop, and seems there's no way to
pick just one binary, is it?
Would changing this:
`("PATH" ":" prefix (,(string-append glib-bin
			"/bin")))))
to
`("PATH" ":" prefix (,(string-append glib-bin
			"/bin/gio-launch-desktop")))))
do the job? 

The macro (or whatever it is) was undocumented in the manual and
explanation in the source code was low level so it is possible I
misunderstood how it works.
I'll try the former.


Jan Wielkiewicz

[bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix launching programs.

[Diego Nicola Barbato]

Hi,

Jan <tona_kosmicznego_smiecia@interia.pl> writes:

> On Mon, 9 Mar 2020 18:11:08 +0100
> Danny Milosavljevic <dannym@scratchpost.org> wrote:
>
>> Hi,
>> 
>> I'm all for fixing this problem, but it would be great to add a
>> comment on which executables thunar tries to find in glib:bin.
> Should I close the issue, add a commit and reopen the issue, or is
> there a more clever way of doing so?
>
>> I've checked glib:bin and it has:
>> 
>> gapplication
>> gdbus
>> gdbus-codegen
>> gio
>> gio-querymodules
>> glib-compile-resources
>> glib-compile-schemas
>> glib-genmarshal
>> glib-gettextize
>> glib-mkenums
>> gobject-query
>> gresource
>> gsettings
>> gtester
>> gtester-report
>> 
>> A lot of those make no sense for thunar to use anyway.
>
> AFAIK it only needs gio-launch-desktop, and seems there's no way to
> pick just one binary, is it?
> Would changing this:
> `("PATH" ":" prefix (,(string-append glib-bin
> 			"/bin")))))
> to
> `("PATH" ":" prefix (,(string-append glib-bin
> 			"/bin/gio-launch-desktop")))))
> do the job? 
>
> The macro (or whatever it is) was undocumented in the manual and
> explanation in the source code was low level so it is possible I
> misunderstood how it works.
> I'll try the former.

I would like to point out — in case you don't already know — that the
issue addressed in this patch is not specific to thunar.  It also shows
up in MATE (https://debbugs.gnu.org/38135) and is caused by glib itself
looking for gio-launch-desktop in $PATH.  More importantly, it has
already been fixed on in commit 0bcc1b14fc3e2382406b97577c56e2292b96b8d4
on core-updates (which is why the aforementioned bug has been closed).

Regards,

Diego

[bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix launching programs.

[Jan]

On Mon, 09 Mar 2020 22:43:13 +0100
Diego Nicola Barbato <dnbarbato@posteo.de> wrote:

> I would like to point out — in case you don't already know — that the
> issue addressed in this patch is not specific to thunar.  It also
> shows up in MATE (https://debbugs.gnu.org/38135) and is caused by
> glib itself looking for gio-launch-desktop in $PATH.  More
> importantly, it has already been fixed on in commit
> 0bcc1b14fc3e2382406b97577c56e2292b96b8d4 on core-updates (which is
> why the aforementioned bug has been closed).
> 
> Regards,
> 
> Diego

This explains why both Mate and Xfce were broken, I kept this in my
mind as one possibility, but the long time it took to fix it made me
think it's not.
Thanks for the information! 
At least I didn't completely waste my time, because I learned something
about wrappers :)


Jan Wielkiewicz

bug#39989: Closing the issue

[Jan]

I'm closing the issue, because it has been solved already.


Jan Wielkiewicz