From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:44953) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBQBz-0006dX-M8 for guix-patches@gnu.org; Mon, 09 Mar 2020 17:44:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBQBy-0006s5-Is for guix-patches@gnu.org; Mon, 09 Mar 2020 17:44:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45570) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jBQBu-0006r5-Fw for guix-patches@gnu.org; Mon, 09 Mar 2020 17:44:06 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jBQBu-0000uv-EH for guix-patches@gnu.org; Mon, 09 Mar 2020 17:44:02 -0400 Subject: [bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix launching programs. Resent-Message-ID: From: Diego Nicola Barbato References: <20200308231200.73b90f30@interia.pl> <20200308222319.2401-1-tona_kosmicznego_smiecia@interia.pl> <20200309181108.1650204a@scratchpost.org> <20200309210804.47a9aa11@kompiuter> Date: Mon, 09 Mar 2020 22:43:13 +0100 In-Reply-To: <20200309210804.47a9aa11@kompiuter> (Jan's message of "Mon, 9 Mar 2020 21:08:04 +0100") Message-ID: <87zhcpciha.fsf@GlaDOS.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Jan Cc: Danny Milosavljevic , 39989@debbugs.gnu.org Hi, Jan writes: > On Mon, 9 Mar 2020 18:11:08 +0100 > Danny Milosavljevic wrote: > >> Hi, >>=20 >> I'm all for fixing this problem, but it would be great to add a >> comment on which executables thunar tries to find in glib:bin. > Should I close the issue, add a commit and reopen the issue, or is > there a more clever way of doing so? > >> I've checked glib:bin and it has: >>=20 >> gapplication >> gdbus >> gdbus-codegen >> gio >> gio-querymodules >> glib-compile-resources >> glib-compile-schemas >> glib-genmarshal >> glib-gettextize >> glib-mkenums >> gobject-query >> gresource >> gsettings >> gtester >> gtester-report >>=20 >> A lot of those make no sense for thunar to use anyway. > > AFAIK it only needs gio-launch-desktop, and seems there's no way to > pick just one binary, is it? > Would changing this: > `("PATH" ":" prefix (,(string-append glib-bin > "/bin"))))) > to > `("PATH" ":" prefix (,(string-append glib-bin > "/bin/gio-launch-desktop"))))) > do the job?=20 > > The macro (or whatever it is) was undocumented in the manual and > explanation in the source code was low level so it is possible I > misunderstood how it works. > I'll try the former. I would like to point out =E2=80=94 in case you don't already know =E2=80= =94 that the issue addressed in this patch is not specific to thunar. It also shows up in MATE (https://debbugs.gnu.org/38135) and is caused by glib itself looking for gio-launch-desktop in $PATH. More importantly, it has already been fixed on in commit 0bcc1b14fc3e2382406b97577c56e2292b96b8d4 on core-updates (which is why the aforementioned bug has been closed). Regards, Diego