* [bug#39989] [PATCH 0/0] Thunar: fix launching applications @ 2020-03-08 22:12 Jan Wielkiewicz 2020-03-08 22:23 ` [bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix launching programs Jan Wielkiewicz 2020-03-09 22:43 ` bug#39989: Closing the issue Jan 0 siblings, 2 replies; 7+ messages in thread From: Jan Wielkiewicz @ 2020-03-08 22:12 UTC (permalink / raw) To: 39989 This patch fixes launching applications in Thunar by making gio-launch-desktop visible to it. Jan Wielkiewicz ^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix launching programs. 2020-03-08 22:12 [bug#39989] [PATCH 0/0] Thunar: fix launching applications Jan Wielkiewicz @ 2020-03-08 22:23 ` Jan Wielkiewicz 2020-03-09 17:11 ` Danny Milosavljevic 2020-03-09 22:43 ` bug#39989: Closing the issue Jan 1 sibling, 1 reply; 7+ messages in thread From: Jan Wielkiewicz @ 2020-03-08 22:23 UTC (permalink / raw) To: 39989; +Cc: Jan Wielkiewicz [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset=y, Size: 1618 bytes --] --- gnu/packages/xfce.scm | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm index 3aacfb0c7c..592b825812 100644 --- a/gnu/packages/xfce.scm +++ b/gnu/packages/xfce.scm @@ -11,6 +11,7 @@ ;;; Copyright © 2019 Pkill -9 <pkill9@runbox.com> ;;; Copyright © 2019 L p R n d n <guix@lprndn.info> ;;; Copyright © 2019 Ingo Ruhnke <grumbel@gmail.com> +;;; Copyright © 2020 Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl> ;;; ;;; This file is part of GNU Guix. ;;; @@ -660,6 +661,7 @@ like appearance, display, keyboard and mouse settings.") ("intltool" ,intltool))) (inputs `(("exo" ,exo) + ("glib:bin" ,glib "bin") ("libexif" ,libexif) ("libgudev" ,libgudev) ("libnotify" ,libnotify) @@ -667,6 +669,17 @@ like appearance, display, keyboard and mouse settings.") ("pcre" ,pcre) ("xfce4-panel" ,xfce4-panel) ("startup-notification" ,startup-notification))) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out")) + (glib-bin (assoc-ref inputs "glib:bin"))) + (wrap-program (string-append out "/bin/thunar") + `("PATH" ":" prefix (,(string-append glib-bin + "/bin"))))) + #t))))) (home-page "https://www.xfce.org/") (synopsis "Xfce file manager") (description -- 2.25.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix launching programs. 2020-03-08 22:23 ` [bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix launching programs Jan Wielkiewicz @ 2020-03-09 17:11 ` Danny Milosavljevic 2020-03-09 20:08 ` Jan 0 siblings, 1 reply; 7+ messages in thread From: Danny Milosavljevic @ 2020-03-09 17:11 UTC (permalink / raw) To: Jan Wielkiewicz; +Cc: 39989 [-- Attachment #1: Type: text/plain, Size: 448 bytes --] Hi, I'm all for fixing this problem, but it would be great to add a comment on which executables thunar tries to find in glib:bin. I've checked glib:bin and it has: gapplication gdbus gdbus-codegen gio gio-querymodules glib-compile-resources glib-compile-schemas glib-genmarshal glib-gettextize glib-mkenums gobject-query gresource gsettings gtester gtester-report A lot of those make no sense for thunar to use anyway. [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix launching programs. 2020-03-09 17:11 ` Danny Milosavljevic @ 2020-03-09 20:08 ` Jan 2020-03-09 21:43 ` Diego Nicola Barbato 0 siblings, 1 reply; 7+ messages in thread From: Jan @ 2020-03-09 20:08 UTC (permalink / raw) To: Danny Milosavljevic; +Cc: 39989 On Mon, 9 Mar 2020 18:11:08 +0100 Danny Milosavljevic <dannym@scratchpost.org> wrote: > Hi, > > I'm all for fixing this problem, but it would be great to add a > comment on which executables thunar tries to find in glib:bin. Should I close the issue, add a commit and reopen the issue, or is there a more clever way of doing so? > I've checked glib:bin and it has: > > gapplication > gdbus > gdbus-codegen > gio > gio-querymodules > glib-compile-resources > glib-compile-schemas > glib-genmarshal > glib-gettextize > glib-mkenums > gobject-query > gresource > gsettings > gtester > gtester-report > > A lot of those make no sense for thunar to use anyway. AFAIK it only needs gio-launch-desktop, and seems there's no way to pick just one binary, is it? Would changing this: `("PATH" ":" prefix (,(string-append glib-bin "/bin"))))) to `("PATH" ":" prefix (,(string-append glib-bin "/bin/gio-launch-desktop"))))) do the job? The macro (or whatever it is) was undocumented in the manual and explanation in the source code was low level so it is possible I misunderstood how it works. I'll try the former. Jan Wielkiewicz ^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix launching programs. 2020-03-09 20:08 ` Jan @ 2020-03-09 21:43 ` Diego Nicola Barbato 2020-03-09 22:36 ` Jan 0 siblings, 1 reply; 7+ messages in thread From: Diego Nicola Barbato @ 2020-03-09 21:43 UTC (permalink / raw) To: Jan; +Cc: Danny Milosavljevic, 39989 Hi, Jan <tona_kosmicznego_smiecia@interia.pl> writes: > On Mon, 9 Mar 2020 18:11:08 +0100 > Danny Milosavljevic <dannym@scratchpost.org> wrote: > >> Hi, >> >> I'm all for fixing this problem, but it would be great to add a >> comment on which executables thunar tries to find in glib:bin. > Should I close the issue, add a commit and reopen the issue, or is > there a more clever way of doing so? > >> I've checked glib:bin and it has: >> >> gapplication >> gdbus >> gdbus-codegen >> gio >> gio-querymodules >> glib-compile-resources >> glib-compile-schemas >> glib-genmarshal >> glib-gettextize >> glib-mkenums >> gobject-query >> gresource >> gsettings >> gtester >> gtester-report >> >> A lot of those make no sense for thunar to use anyway. > > AFAIK it only needs gio-launch-desktop, and seems there's no way to > pick just one binary, is it? > Would changing this: > `("PATH" ":" prefix (,(string-append glib-bin > "/bin"))))) > to > `("PATH" ":" prefix (,(string-append glib-bin > "/bin/gio-launch-desktop"))))) > do the job? > > The macro (or whatever it is) was undocumented in the manual and > explanation in the source code was low level so it is possible I > misunderstood how it works. > I'll try the former. I would like to point out — in case you don't already know — that the issue addressed in this patch is not specific to thunar. It also shows up in MATE (https://debbugs.gnu.org/38135) and is caused by glib itself looking for gio-launch-desktop in $PATH. More importantly, it has already been fixed on in commit 0bcc1b14fc3e2382406b97577c56e2292b96b8d4 on core-updates (which is why the aforementioned bug has been closed). Regards, Diego ^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix launching programs. 2020-03-09 21:43 ` Diego Nicola Barbato @ 2020-03-09 22:36 ` Jan 0 siblings, 0 replies; 7+ messages in thread From: Jan @ 2020-03-09 22:36 UTC (permalink / raw) To: Diego Nicola Barbato; +Cc: Danny Milosavljevic, 39989 On Mon, 09 Mar 2020 22:43:13 +0100 Diego Nicola Barbato <dnbarbato@posteo.de> wrote: > I would like to point out — in case you don't already know — that the > issue addressed in this patch is not specific to thunar. It also > shows up in MATE (https://debbugs.gnu.org/38135) and is caused by > glib itself looking for gio-launch-desktop in $PATH. More > importantly, it has already been fixed on in commit > 0bcc1b14fc3e2382406b97577c56e2292b96b8d4 on core-updates (which is > why the aforementioned bug has been closed). > > Regards, > > Diego This explains why both Mate and Xfce were broken, I kept this in my mind as one possibility, but the long time it took to fix it made me think it's not. Thanks for the information! At least I didn't completely waste my time, because I learned something about wrappers :) Jan Wielkiewicz ^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#39989: Closing the issue 2020-03-08 22:12 [bug#39989] [PATCH 0/0] Thunar: fix launching applications Jan Wielkiewicz 2020-03-08 22:23 ` [bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix launching programs Jan Wielkiewicz @ 2020-03-09 22:43 ` Jan 1 sibling, 0 replies; 7+ messages in thread From: Jan @ 2020-03-09 22:43 UTC (permalink / raw) To: 39989-done I'm closing the issue, because it has been solved already. Jan Wielkiewicz ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-03-09 22:44 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-08 22:12 [bug#39989] [PATCH 0/0] Thunar: fix launching applications Jan Wielkiewicz 2020-03-08 22:23 ` [bug#39989] [PATCH] gnu: thunar: Wrap with glib:bin to fix launching programs Jan Wielkiewicz 2020-03-09 17:11 ` Danny Milosavljevic 2020-03-09 20:08 ` Jan 2020-03-09 21:43 ` Diego Nicola Barbato 2020-03-09 22:36 ` Jan 2020-03-09 22:43 ` bug#39989: Closing the issue Jan
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).