* [bug#29445] [PATCH] gnu: Add roguebox-adventures.
@ 2017-11-25 21:09 Kei Kebreau
2017-11-26 23:13 ` Leo Famulari
0 siblings, 1 reply; 5+ messages in thread
From: Kei Kebreau @ 2017-11-25 21:09 UTC (permalink / raw)
To: 29445; +Cc: Kei Kebreau
From: Kei Kebreau <kei@openmailbox.org>
* gnu/packages/games.scm (roguebox-adventures): New variable.
---
gnu/packages/games.scm | 84 ++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 84 insertions(+)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index b1ba28a62..5b1558c6f 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -580,6 +580,90 @@ utilizing the art assets from the @code{SuperTux} project.")
license:gpl2+
license:gpl3+))))
+(define-public roguebox-adventures
+ (let ((commit "19a2c340b34d5b4e7cc89118c7aedc058babbd93")
+ (revision "1"))
+ (package
+ (name "roguebox-adventures")
+ (version (string-append "2.1.2." revision "." (string-take commit 7)))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://git.postactiv.com/themightyglider/RogueBoxAdventures")
+ (commit commit)))
+ (sha256
+ (base32
+ "0afmg8fjdcs3sqdp5rc7irgr7riil8jwysfjn1imfxslf1wcx5ah"))))
+ (build-system python-build-system)
+ (arguments
+ '(#:tests? #f ; no check target
+ #:phases
+ (modify-phases %standard-phases
+ ;; no setup.py script
+ (replace 'build
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (data (string-append
+ out "/share/games/roguebox-adventures")))
+ ;; Use the correct data directory.
+ (substitute* '("main.py" "LIB/getch.py" "LIB/getch_gcwz.py")
+ (("basic_path + os\\.sep + 'DATA'")
+ (string-append "'" data "'"))
+ (("^basic_path.*$")
+ (string-append "basic_path ='" data "'\n")))
+ (substitute* "LIB/gra_files.py"
+ (("basic_path = b_path\\.replace\\('/LIB',''\\)")
+ (string-append "basic_path ='" data "'\n")))
+
+ ;; The game must save in the user's home directory because
+ ;; the store is read-only.
+ (substitute* "main.py"
+ (("home_save = False") "home_save = True")
+ (("'icon_small.png'")
+ (string-append "'" data "/icon_small.png'"))))
+ #t))
+ (replace 'install
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin"))
+ (data (string-append
+ out "/share/games/roguebox-adventures"))
+ (doc (string-append out "/share/doc")))
+ (mkdir-p bin)
+ (mkdir-p doc)
+
+ (copy-file "main.py"
+ (string-append bin "/roguebox-adventures"))
+ (chmod (string-append bin "/roguebox-adventures") #o555)
+
+ (for-each (lambda (file)
+ (copy-recursively file
+ (string-append data "/" file)))
+ '("AUDIO" "FONT" "GRAPHIC" "LIB" "LICENSE"
+ "icon_big.png" "icon_small.png"))
+
+ (copy-file "DOC" (string-append doc "/roguebox-adventures"))
+
+ (wrap-program (string-append bin "/roguebox-adventures")
+ `("PYTHONPATH" ":" prefix (,(string-append data "/LIB")))))
+ #t)))))
+ (inputs
+ `(("python-pygame" ,python-pygame)
+ ("python-tmx" ,python-tmx)))
+ (home-page "https://rogueboxadventures.tuxfamily.org")
+ (synopsis "A classical roguelike/sandbox game")
+ (description
+ "RogueBox Adventures is a graphical roguelike with strong influences
+from sandbox games like Minecraft or Terraria. The main idea of RogueBox
+Adventures is to offer the player a kind of roguelike toy-world. This world
+can be explored and changed freely.")
+ ;; The GPL3+ is for code, the rest are for art.
+ (license (list license:cc0
+ license:cc-by3.0
+ license:gpl3+
+ license:silofl1.1)))))
+
(define-public xshogi
(package
(name "xshogi")
--
2.15.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#29445] [PATCH] gnu: Add roguebox-adventures.
2017-11-25 21:09 [bug#29445] [PATCH] gnu: Add roguebox-adventures Kei Kebreau
@ 2017-11-26 23:13 ` Leo Famulari
2017-11-28 0:12 ` Kei Kebreau
0 siblings, 1 reply; 5+ messages in thread
From: Leo Famulari @ 2017-11-26 23:13 UTC (permalink / raw)
To: Kei Kebreau; +Cc: Kei Kebreau, 29445
[-- Attachment #1: Type: text/plain, Size: 1696 bytes --]
On Sat, Nov 25, 2017 at 04:09:28PM -0500, Kei Kebreau wrote:
Thanks! Overall LGTM, but I have some nitpicks...
> + (package
> + (name "roguebox-adventures")
> + (version (string-append "2.1.2." revision "." (string-take commit 7)))
How about (version (git-version "2.1.2" revision commit)) ?
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://git.postactiv.com/themightyglider/RogueBoxAdventures")
> + (commit commit)))
And similarly, (file-name (git-file-name name version))
> + (replace 'build
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (data (string-append
^
There are too many spaces here --| and also in the install phase.
> + (mkdir-p bin)
> + (mkdir-p doc)
> +
> + (copy-file "main.py"
> + (string-append bin "/roguebox-adventures"))
> + (chmod (string-append bin "/roguebox-adventures") #o555)
> +
> + (for-each (lambda (file)
> + (copy-recursively file
> + (string-append data "/" file)))
> + '("AUDIO" "FONT" "GRAPHIC" "LIB" "LICENSE"
> + "icon_big.png" "icon_small.png"))
> +
> + (copy-file "DOC" (string-append doc "/roguebox-adventures"))
And we could simplify a bit by using install-file instead of mkdir-p and
copy-file.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#29445] [PATCH] gnu: Add roguebox-adventures.
2017-11-26 23:13 ` Leo Famulari
@ 2017-11-28 0:12 ` Kei Kebreau
2017-11-28 2:17 ` Leo Famulari
0 siblings, 1 reply; 5+ messages in thread
From: Kei Kebreau @ 2017-11-28 0:12 UTC (permalink / raw)
To: Leo Famulari; +Cc: 29445
[-- Attachment #1: Type: text/plain, Size: 1828 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Sat, Nov 25, 2017 at 04:09:28PM -0500, Kei Kebreau wrote:
>
> Thanks! Overall LGTM, but I have some nitpicks...
>
>> + (package
>> + (name "roguebox-adventures")
>> + (version (string-append "2.1.2." revision "." (string-take commit
>> 7)))
>
> How about (version (git-version "2.1.2" revision commit)) ?
>
>> + (source
>> + (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url
>> "https://git.postactiv.com/themightyglider/RogueBoxAdventures")
>> + (commit commit)))
>
> And similarly, (file-name (git-file-name name version))
>
>> + (replace 'build
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (let* ((out (assoc-ref outputs "out"))
>> + (data (string-append
> ^
> There are too many spaces here --| and also in the install phase.
>
>> + (mkdir-p bin)
>> + (mkdir-p doc)
>> +
>> + (copy-file "main.py"
>> + (string-append bin "/roguebox-adventures"))
>> + (chmod (string-append bin "/roguebox-adventures") #o555)
>> +
>> + (for-each (lambda (file)
>> + (copy-recursively file
>> + (string-append data "/" file)))
>> + '("AUDIO" "FONT" "GRAPHIC" "LIB" "LICENSE"
>> + "icon_big.png" "icon_small.png"))
>> +
>> + (copy-file "DOC" (string-append doc "/roguebox-adventures"))
>
> And we could simplify a bit by using install-file instead of mkdir-p and
> copy-file.
Is there a way to rename the file when using install-file? It's a bit
weird to have to run "main.py" to launch the game.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#29445] [PATCH] gnu: Add roguebox-adventures.
2017-11-28 0:12 ` Kei Kebreau
@ 2017-11-28 2:17 ` Leo Famulari
2017-11-28 14:55 ` bug#29445: " Kei Kebreau
0 siblings, 1 reply; 5+ messages in thread
From: Leo Famulari @ 2017-11-28 2:17 UTC (permalink / raw)
To: Kei Kebreau; +Cc: 29445
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
On Mon, Nov 27, 2017 at 07:12:54PM -0500, Kei Kebreau wrote:
> Leo Famulari <leo@famulari.name> writes:
> > On Sat, Nov 25, 2017 at 04:09:28PM -0500, Kei Kebreau wrote:
> >> + (copy-file "main.py"
> >> + (string-append bin "/roguebox-adventures"))
> >
> > And we could simplify a bit by using install-file instead of mkdir-p and
> > copy-file.
>
> Is there a way to rename the file when using install-file? It's a bit
> weird to have to run "main.py" to launch the game.
Oh, I missed that we were renaming things here. No, install-file doesn't
let you rename the file, so mkdir-p and copy-file are the way to go.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#29445: [PATCH] gnu: Add roguebox-adventures.
2017-11-28 2:17 ` Leo Famulari
@ 2017-11-28 14:55 ` Kei Kebreau
0 siblings, 0 replies; 5+ messages in thread
From: Kei Kebreau @ 2017-11-28 14:55 UTC (permalink / raw)
To: Leo Famulari; +Cc: 29445-done
[-- Attachment #1: Type: text/plain, Size: 775 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Mon, Nov 27, 2017 at 07:12:54PM -0500, Kei Kebreau wrote:
>> Leo Famulari <leo@famulari.name> writes:
>> > On Sat, Nov 25, 2017 at 04:09:28PM -0500, Kei Kebreau wrote:
>> >> + (copy-file "main.py"
>> >> + (string-append bin "/roguebox-adventures"))
>> >
>> > And we could simplify a bit by using install-file instead of mkdir-p and
>> > copy-file.
>>
>> Is there a way to rename the file when using install-file? It's a bit
>> weird to have to run "main.py" to launch the game.
>
> Oh, I missed that we were renaming things here. No, install-file doesn't
> let you rename the file, so mkdir-p and copy-file are the way to go.
Alright, thank you for the review!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-28 14:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-25 21:09 [bug#29445] [PATCH] gnu: Add roguebox-adventures Kei Kebreau
2017-11-26 23:13 ` Leo Famulari
2017-11-28 0:12 ` Kei Kebreau
2017-11-28 2:17 ` Leo Famulari
2017-11-28 14:55 ` bug#29445: " Kei Kebreau
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).