From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJ67i-00039n-FR for guix-patches@gnu.org; Sun, 26 Nov 2017 18:14:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJ67e-0008NJ-D8 for guix-patches@gnu.org; Sun, 26 Nov 2017 18:14:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:51079) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJ67d-0008N8-W8 for guix-patches@gnu.org; Sun, 26 Nov 2017 18:14:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eJ67d-0000VV-Hi for guix-patches@gnu.org; Sun, 26 Nov 2017 18:14:01 -0500 Subject: [bug#29445] [PATCH] gnu: Add roguebox-adventures. Resent-Message-ID: Date: Sun, 26 Nov 2017 18:13:16 -0500 From: Leo Famulari Message-ID: <20171126231316.GA22939@jasmine.lan> References: <20171125210928.24879-1-kkebreau@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="n8g4imXOkfNTN/H1" Content-Disposition: inline In-Reply-To: <20171125210928.24879-1-kkebreau@posteo.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Kei Kebreau Cc: Kei Kebreau , 29445@debbugs.gnu.org --n8g4imXOkfNTN/H1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Nov 25, 2017 at 04:09:28PM -0500, Kei Kebreau wrote: Thanks! Overall LGTM, but I have some nitpicks... > + (package > + (name "roguebox-adventures") > + (version (string-append "2.1.2." revision "." (string-take commit 7))) How about (version (git-version "2.1.2" revision commit)) ? > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://git.postactiv.com/themightyglider/RogueBoxAdventures") > + (commit commit))) And similarly, (file-name (git-file-name name version)) > + (replace 'build > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (data (string-append ^ There are too many spaces here --| and also in the install phase. > + (mkdir-p bin) > + (mkdir-p doc) > + > + (copy-file "main.py" > + (string-append bin "/roguebox-adventures")) > + (chmod (string-append bin "/roguebox-adventures") #o555) > + > + (for-each (lambda (file) > + (copy-recursively file > + (string-append data "/" file))) > + '("AUDIO" "FONT" "GRAPHIC" "LIB" "LICENSE" > + "icon_big.png" "icon_small.png")) > + > + (copy-file "DOC" (string-append doc "/roguebox-adventures")) And we could simplify a bit by using install-file instead of mkdir-p and copy-file. --n8g4imXOkfNTN/H1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlobSosACgkQJkb6MLrK fwiUXhAA6i5jS3qy1GB2XEX8AmSyS54HFcTydjq0k9ghJ8z6/SO0a1F6cbIlgsKv mYBKVepb2X9U9j3cl+gVr5hNc7pPNnGNwjtNFAO5wT+Wdv/CntFVJm9Ekid/arzW TGrX1Zy+akXZTA8Go2zyO/C71bUWzwfLimtRqDhIpK97vwXpFlQpRmmkAbWiLhjA /D1B/fj4r3HK1YA2FRS6ZKulDKR7fQF75NPDy+zKqMvY6/35fHh2h0/z+H2xKhXU BeapeuoYNHAvj2tDUkb509CeNSIsizzQFmdzDJCRZEIntkW9EvfuoBg8FRrsRI1G M290la7ddY7+groKbIv2FAYj8mZFz81NlGktbjPzvMs6YVbv49xUooFXN4LEsUWL ibudELRXGKsYOiWo62ljN7L0b1WveKiJSUfxAjDsfdTfAxJZVT5KJWUJC03p4ON/ 4wsPRdsOKysVS9pW2ENWljieUNXsORdfpfcxXP8FuXh0v0CmWEirON6tpGOcTRwg 8nBcCjycJR6axvBdmyA+mwj1xUe+397H1YnHfRovbp5BrU6Bi5IPAVUm/3T6OEyH iapvBn6v2zzVehVkSBrH7Zo0fF6HzSIlqsOI7HxU98+ktTTSQMr7Z1Zd8Sb3hc+P CqxAG1+0D16tR4fto0+z02NjaRCY7pZ5hMCp8R0VA/ENXGogEJA= =TNPp -----END PGP SIGNATURE----- --n8g4imXOkfNTN/H1--