From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJUyN-0001if-0L for guix-patches@gnu.org; Mon, 27 Nov 2017 20:46:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJUyI-00015m-87 for guix-patches@gnu.org; Mon, 27 Nov 2017 20:46:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:52796) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJUyI-00015a-0O for guix-patches@gnu.org; Mon, 27 Nov 2017 20:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eJUyH-0007VF-Q2 for guix-patches@gnu.org; Mon, 27 Nov 2017 20:46:01 -0500 Subject: [bug#29445] [PATCH] gnu: Add roguebox-adventures. In-Reply-To: <20171125210928.24879-1-kkebreau@posteo.net> Resent-Message-ID: From: Kei Kebreau Date: Mon, 27 Nov 2017 19:12:54 -0500 References: <20171125210928.24879-1-kkebreau@posteo.net> <20171126231316.GA22939@jasmine.lan> Message-ID: <87zi7741nf.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 29445@debbugs.gnu.org --=-=-= Content-Type: text/plain Leo Famulari writes: > On Sat, Nov 25, 2017 at 04:09:28PM -0500, Kei Kebreau wrote: > > Thanks! Overall LGTM, but I have some nitpicks... > >> + (package >> + (name "roguebox-adventures") >> + (version (string-append "2.1.2." revision "." (string-take commit >> 7))) > > How about (version (git-version "2.1.2" revision commit)) ? > >> + (source >> + (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url >> "https://git.postactiv.com/themightyglider/RogueBoxAdventures") >> + (commit commit))) > > And similarly, (file-name (git-file-name name version)) > >> + (replace 'build >> + (lambda* (#:key outputs #:allow-other-keys) >> + (let* ((out (assoc-ref outputs "out")) >> + (data (string-append > ^ > There are too many spaces here --| and also in the install phase. > >> + (mkdir-p bin) >> + (mkdir-p doc) >> + >> + (copy-file "main.py" >> + (string-append bin "/roguebox-adventures")) >> + (chmod (string-append bin "/roguebox-adventures") #o555) >> + >> + (for-each (lambda (file) >> + (copy-recursively file >> + (string-append data "/" file))) >> + '("AUDIO" "FONT" "GRAPHIC" "LIB" "LICENSE" >> + "icon_big.png" "icon_small.png")) >> + >> + (copy-file "DOC" (string-append doc "/roguebox-adventures")) > > And we could simplify a bit by using install-file instead of mkdir-p and > copy-file. Is there a way to rename the file when using install-file? It's a bit weird to have to run "main.py" to launch the game. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlocv6UACgkQ5qXuPBlG eg0hqhAAhA3xcDmJM1wiQWDDX3wgeqiC8mxSnAfn/BN9nrez0B/VbsPO2VubAdTT UN9epHTBvFTAmRHjYnSjWjVf3yVMl0vKnCELPti6vMDmOHCY15GVJeME3t9/v8Wo bc8tPHBm/sfou9LtkM+03Q7TZ4Eri0EeWif9lQA7sDKXEriE46sy3vwAIwOK1YgF ogd2NDEe2viSG8Zh4BUKF70JkgCtXmkBusr5igmPP5UwvE1ePnsToWaox9sicZkW 0PUdV9MVtNizDKBY7QZONFC5NHgtQrTwJDNhBNWrpaxiurqOabdpYenUUyrPsMeM QixxzgqQn0UIebgWE/UACpbMnlYKsKevSbxFOAqZBj4iAXwG2adbHah6KlAv4btP tCH9MWscYGrMOCDrBJ7Ve8IloNGF5QpwEtXJYBhLZgDGHoCxYPOCnScAQSDb8dbb pjkadGf1kaXWfWXZVTpqA/DtzdCKuk8rvV2jriKGpVEGgzGyPvuCa1zXTarH/++M cr3Mq2YcfCrE3kOYH50eBNpTXSoWqwth0dpPfOJNMFiDuv/eWmu2XrnQJW9hAhWh tu5lquoXiCX5o600lhFHNwxS3+iLEmyEgzoWx6P1KlTQ3WT4Z2oeJo9uTY7uD8EO GyusWo3fhzixmGzGoW/Qq6FZ1r5TFOW3xJvykfMITdNmHRM+pNA= =leoC -----END PGP SIGNATURE----- --=-=-=--