From: Kei Kebreau <kkebreau@posteo.net>
To: Leo Famulari <leo@famulari.name>
Cc: 29445@debbugs.gnu.org
Subject: [bug#29445] [PATCH] gnu: Add roguebox-adventures.
Date: Mon, 27 Nov 2017 19:12:54 -0500 [thread overview]
Message-ID: <87zi7741nf.fsf@posteo.net> (raw)
In-Reply-To: <20171125210928.24879-1-kkebreau@posteo.net>
[-- Attachment #1: Type: text/plain, Size: 1828 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Sat, Nov 25, 2017 at 04:09:28PM -0500, Kei Kebreau wrote:
>
> Thanks! Overall LGTM, but I have some nitpicks...
>
>> + (package
>> + (name "roguebox-adventures")
>> + (version (string-append "2.1.2." revision "." (string-take commit
>> 7)))
>
> How about (version (git-version "2.1.2" revision commit)) ?
>
>> + (source
>> + (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url
>> "https://git.postactiv.com/themightyglider/RogueBoxAdventures")
>> + (commit commit)))
>
> And similarly, (file-name (git-file-name name version))
>
>> + (replace 'build
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (let* ((out (assoc-ref outputs "out"))
>> + (data (string-append
> ^
> There are too many spaces here --| and also in the install phase.
>
>> + (mkdir-p bin)
>> + (mkdir-p doc)
>> +
>> + (copy-file "main.py"
>> + (string-append bin "/roguebox-adventures"))
>> + (chmod (string-append bin "/roguebox-adventures") #o555)
>> +
>> + (for-each (lambda (file)
>> + (copy-recursively file
>> + (string-append data "/" file)))
>> + '("AUDIO" "FONT" "GRAPHIC" "LIB" "LICENSE"
>> + "icon_big.png" "icon_small.png"))
>> +
>> + (copy-file "DOC" (string-append doc "/roguebox-adventures"))
>
> And we could simplify a bit by using install-file instead of mkdir-p and
> copy-file.
Is there a way to rename the file when using install-file? It's a bit
weird to have to run "main.py" to launch the game.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-11-28 1:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-25 21:09 [bug#29445] [PATCH] gnu: Add roguebox-adventures Kei Kebreau
2017-11-26 23:13 ` Leo Famulari
2017-11-28 0:12 ` Kei Kebreau [this message]
2017-11-28 2:17 ` Leo Famulari
2017-11-28 14:55 ` bug#29445: " Kei Kebreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi7741nf.fsf@posteo.net \
--to=kkebreau@posteo.net \
--cc=29445@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).