From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MxwaMMUEV2B7YAAA0tVLHw (envelope-from ) for ; Sun, 21 Mar 2021 08:33:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4LaIK8UEV2COWQAAbx9fmQ (envelope-from ) for ; Sun, 21 Mar 2021 08:33:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7628F24230 for ; Sun, 21 Mar 2021 09:33:09 +0100 (CET) Received: from localhost ([::1]:45138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNtWG-0004ux-LO for larch@yhetil.org; Sun, 21 Mar 2021 04:33:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNtWA-0004uo-3T for guix-patches@gnu.org; Sun, 21 Mar 2021 04:33:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lNtW9-0006Iz-Rt for guix-patches@gnu.org; Sun, 21 Mar 2021 04:33:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lNtW9-0008HA-Nq for guix-patches@gnu.org; Sun, 21 Mar 2021 04:33:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47269] [PATCH 0/1] Add node-global-gradle-clean Resent-From: Dhruvin Gandhi Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 21 Mar 2021 08:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47269 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 47269@debbugs.gnu.org Received: via spool by 47269-submit@debbugs.gnu.org id=B47269.161631556731791 (code B ref 47269); Sun, 21 Mar 2021 08:33:01 +0000 Received: (at 47269) by debbugs.gnu.org; 21 Mar 2021 08:32:47 +0000 Received: from localhost ([127.0.0.1]:53508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNtVv-0008Gh-Gd for submit@debbugs.gnu.org; Sun, 21 Mar 2021 04:32:47 -0400 Received: from mout-p-101.mailbox.org ([80.241.56.151]:31764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNtVs-0008GS-EZ for 47269@debbugs.gnu.org; Sun, 21 Mar 2021 04:32:45 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4F39qV12Z5zQjmS; Sun, 21 Mar 2021 09:32:38 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dhruvin.dev; s=MBO0001; t=1616315556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eHalQ6w19oEAyUx+M0RlY2d7iX/brVeEvTer5TFMh1w=; b=FfUs4HX8EJ6bDR3m2J37zftdG3ZoZtwD3i32dhxCAV7n0NT/I0wWSoal1Rw18t4Bpw6Zq7 4evSNF4FhlQLVvTlZifhgmivYh7GijS0PtvhP5NIV589kK6tQlF9Q7MJuSYl8fTbzRLDWo 7RPeTA1ddjHflkiUkDhSP17IpGedA6GAO6+GsJ4bwEfDwGIPM5oaF8R2IPsFW/WkRljZtD F7auzswbByG3NDSWOAAc5YtEFQRyZipQQ8aTFSIQIOwEi/N6qGVv9pYXUv/wA9XEBHrZV1 7h/vXEjrDKDtZViU6/Z3yYZBLftAw3qZwILK362sPd1M9xePBM60UR8hEpNUpw== Received: from smtp1.mailbox.org ([80.241.60.240]) by gerste.heinlein-support.de (gerste.heinlein-support.de [91.198.250.173]) (amavisd-new, port 10030) with ESMTP id YZi2NpcF_cCK; Sun, 21 Mar 2021 09:32:34 +0100 (CET) Date: Sun, 21 Mar 2021 14:02:34 +0530 (IST) Message-ID: <1927774916.43640.1616315554137@office.mailbox.org> In-Reply-To: <6ac44e1dc193a3d78351aed9a80e1c651e809ab5.camel@telenet.be> References: <20210319192144.17799-1-contact@dhruvin.dev> <6ac44e1dc193a3d78351aed9a80e1c651e809ab5.camel@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-MBO-SPAM-Probability: X-Rspamd-Score: -3.80 / 15.00 / 15.00 X-Rspamd-Queue-Id: E50DC15F8 X-Rspamd-UID: 8b5a37 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Dhruvin Gandhi X-ACL-Warn: , Dhruvin Gandhi via Guix-patches From: Dhruvin Gandhi via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616315589; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=eHalQ6w19oEAyUx+M0RlY2d7iX/brVeEvTer5TFMh1w=; b=uEV+kGjsf+k2tDiXPtzm6fYUsOkyhkdPLYLDjw9Xoib9EUO/SOidao3OTqvwvWl+iaW4ba 0vbX5bMuvSmdve3VMZq/49bRmnUrHMNeM5oYgx+KJAgSQQPplymY4K3lvA2MN8ACSEYcI2 HAH387HipqR8WthcaSTUnajxZ4cmXSORJTzH0zBadjK6FMsEyhTTU97Fr/jvCUxRVsw8mD mEGI2fu24uNmt7HfTEDqNu3/3qorxqx9i+7qRqY6iA2sZUgQLMoRi9J/Js3THc9sSDdmGA C4gQGqbcWMXdr4apUZ01dq4vfZ3QwUx1F3Z9uPuOo3VsJjbSQa5PKjP10e4rpQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616315589; a=rsa-sha256; cv=none; b=SJf1cQZtbPIFHjMylQLCWjz3t5m898P7tJHVrqjasCVEBwFtEbmWHU40rdVLtxTwcYjzL/ zBwTJp0uwGIuYtW5Wi4MffH2S43Y5pJkxoOEvmH4otNktV4Ctes5CfF687DzFmhRGJuhI+ tLd1OLc82HT+8tfNjKO2sqjVuo43eJHQ5lBvLB9v6fI+p7yvC8l7vOZz7isT0zQ3/ngZTz 1mn2Q5+5CKcH6k67hHYko0iGj7TjXyphaeQeqcLH/KmMfwU7tbO2+KRUUMg72S3ggftj4+ pNgQAoGRa3hV/gbq2Mq19IXvrci/AuIY2VLNkVUfDDz7LoBQ14MlEHsquIcPWw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dhruvin.dev header.s=MBO0001 header.b=FfUs4HX8; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dhruvin.dev header.s=MBO0001 header.b=FfUs4HX8; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 7628F24230 X-Spam-Score: -2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: sDvl4+kmOY2T > See =E2=80=9816.4 Packaging Guidelines=E2=80=99 and =E2=80=9816.6 Submitt= ing Patches=E2=80=99 in the manual. Yes, I will go through the guidelines first before submitting next version of the patch with suggested changes. > There's an uniform style for commit messages. Example for > when adding new packages: > ... I saw commit messages. I initially thought the committers added them, as I did not know how the patches are applied. But now that you have mentioned this, it makes sense, I will use that format for commit messages. > When defining a new package, usually a copyright line should > be added at the top of the file. Will do that. > I prefer referring to the commit directly instead of by tag, as > the commit is required for SWH fallback if the repo disappears. Okay. > Is there any particular reason tests are disabled? Maybe add > a comment "; No test suite." if that's the case. Yes, there are no tests (as of 1.0.1). I will mention that. > I'm not a fan of starting package descriptions with "This package is ..."= , > even though plenty of plenty of packages in gnu/package/node-xyz.scm have > such a description. A description from gnu/packages/guile-xyz.scm I like= : >=20 > "Guile-DSV is a GNU Guile module for working with the > delimiter-separated values (DSV) data format. Guile-DSV supports the > Unix-style DSV format and RFC 4180 format." I borrowed synopsis and description from the global-gradle-clean package author, and changed them a bit to match existing packages in the node-xyz module. I agree that they can be more descriptive, and concise. I'll update them as well. I have a question. The package may be used by only a few users. I hope that is okay with guix. Is there a rule defined somewhere, stating what gets in this guix channel and what should not? PS: When I submitted this patch, it created another bug 47270. I read about what a patch series is and read about how to submit them to guix afterwards= . 47270 may be closed in favor of 47269. I will follow the way specified in guidelines. Thanks Maxime for your suggestions. Regards, Dhruvin Gandhi