* [PATCH 02/19] gnu: Add r-lazyeval.
@ 2015-09-13 16:45 Vicente Vera
2015-09-14 10:43 ` Ricardo Wurmus
0 siblings, 1 reply; 6+ messages in thread
From: Vicente Vera @ 2015-09-13 16:45 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 1 bytes --]
[-- Attachment #2: 0002-gnu-Add-r-lazyeval.patch --]
[-- Type: text/x-patch, Size: 1373 bytes --]
From 7996c78eca1549a69cad643730ecc5c2750b53f3 Mon Sep 17 00:00:00 2001
From: Vicente Vera Parra <vicentemvp@gmail.com>
Date: Sun, 13 Sep 2015 13:05:48 -0300
Subject: [PATCH 02/19] gnu: Add r-lazyeval.
* gnu/packages/statistics.scm (r-lazyeval): New variable.
---
gnu/packages/statistics.scm | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 9063496..004ecef 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -518,3 +518,20 @@ declare the pre and post conditions that you code should satisfy,
while also producing friendly error messages so that your users know
what they've done wrong.")
(license license:gpl3+)))
+
+(define-public r-lazyeval
+ (package
+ (name "r-lazyeval")
+ (version "0.1.10")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://cran/src/contrib/lazyeval_"
+ version ".tar.gz"))
+ (sha256
+ (base32 "02qfpn2fmy78vx4jxr7g7rhqzcm1kcivfwai7lbh0vvpawia0qwh"))))
+ (build-system r-build-system)
+ (home-page "https://github.com/hadley/lazyeval")
+ (synopsis "Lazy (Non-Standard) Evaluation")
+ (description
+ "A disciplined approach to non-standard evaluation.")
+ (license license:gpl3+)))
--
2.5.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 02/19] gnu: Add r-lazyeval.
2015-09-13 16:45 [PATCH 02/19] gnu: Add r-lazyeval Vicente Vera
@ 2015-09-14 10:43 ` Ricardo Wurmus
2015-09-14 19:34 ` Vicente Vera
0 siblings, 1 reply; 6+ messages in thread
From: Ricardo Wurmus @ 2015-09-14 10:43 UTC (permalink / raw)
To: Vicente Vera; +Cc: guix-devel
Hi Vicente,
> * gnu/packages/statistics.scm (r-lazyeval): New variable.
[...]
> + (home-page "https://github.com/hadley/lazyeval")
> + (synopsis "Lazy (Non-Standard) Evaluation")
> + (description
> + "A disciplined approach to non-standard evaluation.")
For the synopsis, please use lower-case characters and make a reference
to R, if possible.
The description should be a little more explicit and should be a
complete sentence. I do not know what an “approach” is in the context
of an R package ;)
~~ Ricardo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 02/19] gnu: Add r-lazyeval.
2015-09-14 10:43 ` Ricardo Wurmus
@ 2015-09-14 19:34 ` Vicente Vera
2015-09-15 14:42 ` Ricardo Wurmus
0 siblings, 1 reply; 6+ messages in thread
From: Vicente Vera @ 2015-09-14 19:34 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
Hello Ricardo, thank you for your replies.
Actually, nearly every synopsis and description in these patches are
taken verbatim from CRAN.
I'm not familiar enough with this package to amend the description
provided by the author, so I replaced it with the one offered in the
package's GitHub repository.
Upper-case characters corrected.
New patch attached.
2015-09-14 7:43 GMT-03:00 Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>:
> Hi Vicente,
>
>> * gnu/packages/statistics.scm (r-lazyeval): New variable.
>
> [...]
>
>> + (home-page "https://github.com/hadley/lazyeval")
>> + (synopsis "Lazy (Non-Standard) Evaluation")
>> + (description
>> + "A disciplined approach to non-standard evaluation.")
>
> For the synopsis, please use lower-case characters and make a reference
> to R, if possible.
>
> The description should be a little more explicit and should be a
> complete sentence. I do not know what an “approach” is in the context
> of an R package ;)
>
> ~~ Ricardo
[-- Attachment #2: 0002-gnu-Add-r-lazyeval.patch --]
[-- Type: text/x-patch, Size: 1405 bytes --]
From ebe1fc562203a8b884daae5c438820510002b642 Mon Sep 17 00:00:00 2001
From: Vicente Vera Parra <vicentemvp@gmail.com>
Date: Mon, 14 Sep 2015 13:28:38 -0300
Subject: [PATCH 02/12] gnu: Add r-lazyeval.
* gnu/packages/statistics.scm (r-lazyeval): New variable.
---
gnu/packages/statistics.scm | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 0c60382..5137b1b 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -519,4 +519,21 @@ the pre and post conditions that your code should satisfy, while also
producing friendly error messages so that your users know what they've done
wrong.")
(license license:gpl3+)))
+
+(define-public r-lazyeval
+ (package
+ (name "r-lazyeval")
+ (version "0.1.10")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://cran/src/contrib/lazyeval_"
+ version ".tar.gz"))
+ (sha256
+ (base32 "02qfpn2fmy78vx4jxr7g7rhqzcm1kcivfwai7lbh0vvpawia0qwh"))))
+ (build-system r-build-system)
+ (home-page "https://github.com/hadley/lazyeval")
+ (synopsis "Lazy (non-standard) evaluation in R")
+ (description
+ "This package provides the tools necessary to do non-standard
+evaluation (NSE) in R.")
+ (license license:gpl3+)))
--
2.5.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 02/19] gnu: Add r-lazyeval.
2015-09-14 19:34 ` Vicente Vera
@ 2015-09-15 14:42 ` Ricardo Wurmus
2015-09-15 15:31 ` Vicente Vera
0 siblings, 1 reply; 6+ messages in thread
From: Ricardo Wurmus @ 2015-09-15 14:42 UTC (permalink / raw)
To: Vicente Vera; +Cc: guix-devel
Hi Vicente,
> Actually, nearly every synopsis and description in these patches are
> taken verbatim from CRAN.
That’s what I thought. When I prepared my initial patches for R modules
to test the CRAN importer I found that I needed to edit both synopsis
and description for every package. The quality of descriptions is
certainly better than for the average CPAN package, but it still
requires editing to fit in with the rest of the Guix packages.
> I'm not familiar enough with this package to amend the description
> provided by the author, so I replaced it with the one offered in the
> package's GitHub repository.
That’s okay.
> Upper-case characters corrected.
>
> New patch attached.
Thank you!
I think it’s okay, except maybe for the slightly overlong line
containing the hash. Unless there are objections I’d like to push this
tonight (after dropping the hash to its own line).
~~ Ricardo
PS: I’m wrapping up a project at a bioinfo hackathon and your patches
were very helpful as I had trouble installing dplyr via R. Your patches
made this much simpler, so thank you very much!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 02/19] gnu: Add r-lazyeval.
2015-09-15 14:42 ` Ricardo Wurmus
@ 2015-09-15 15:31 ` Vicente Vera
2015-09-15 17:33 ` Vicente Vera
0 siblings, 1 reply; 6+ messages in thread
From: Vicente Vera @ 2015-09-15 15:31 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel
Hi,
Glad to hear the patches helped!
I've been fixing most of the issues (sentences with double spaces,
long lines) in all the patches. If you don't mind the extra time, I'll
attach the corrected patches in the next hours.
2015-09-15 11:42 GMT-03:00 Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>:
> Hi Vicente,
>
>> Actually, nearly every synopsis and description in these patches are
>> taken verbatim from CRAN.
>
> That’s what I thought. When I prepared my initial patches for R modules
> to test the CRAN importer I found that I needed to edit both synopsis
> and description for every package. The quality of descriptions is
> certainly better than for the average CPAN package, but it still
> requires editing to fit in with the rest of the Guix packages.
>
>> I'm not familiar enough with this package to amend the description
>> provided by the author, so I replaced it with the one offered in the
>> package's GitHub repository.
>
> That’s okay.
>
>> Upper-case characters corrected.
>>
>> New patch attached.
>
> Thank you!
>
> I think it’s okay, except maybe for the slightly overlong line
> containing the hash. Unless there are objections I’d like to push this
> tonight (after dropping the hash to its own line).
>
> ~~ Ricardo
>
>
> PS: I’m wrapping up a project at a bioinfo hackathon and your patches
> were very helpful as I had trouble installing dplyr via R. Your patches
> made this much simpler, so thank you very much!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 02/19] gnu: Add r-lazyeval.
2015-09-15 15:31 ` Vicente Vera
@ 2015-09-15 17:33 ` Vicente Vera
0 siblings, 0 replies; 6+ messages in thread
From: Vicente Vera @ 2015-09-15 17:33 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 1641 bytes --]
Updated patch attached.
2015-09-15 12:31 GMT-03:00 Vicente Vera <vicentemvp@gmail.com>:
> Hi,
>
> Glad to hear the patches helped!
>
> I've been fixing most of the issues (sentences with double spaces,
> long lines) in all the patches. If you don't mind the extra time, I'll
> attach the corrected patches in the next hours.
>
> 2015-09-15 11:42 GMT-03:00 Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>:
>> Hi Vicente,
>>
>>> Actually, nearly every synopsis and description in these patches are
>>> taken verbatim from CRAN.
>>
>> That’s what I thought. When I prepared my initial patches for R modules
>> to test the CRAN importer I found that I needed to edit both synopsis
>> and description for every package. The quality of descriptions is
>> certainly better than for the average CPAN package, but it still
>> requires editing to fit in with the rest of the Guix packages.
>>
>>> I'm not familiar enough with this package to amend the description
>>> provided by the author, so I replaced it with the one offered in the
>>> package's GitHub repository.
>>
>> That’s okay.
>>
>>> Upper-case characters corrected.
>>>
>>> New patch attached.
>>
>> Thank you!
>>
>> I think it’s okay, except maybe for the slightly overlong line
>> containing the hash. Unless there are objections I’d like to push this
>> tonight (after dropping the hash to its own line).
>>
>> ~~ Ricardo
>>
>>
>> PS: I’m wrapping up a project at a bioinfo hackathon and your patches
>> were very helpful as I had trouble installing dplyr via R. Your patches
>> made this much simpler, so thank you very much!
[-- Attachment #2: 0002-gnu-Add-r-lazyeval.patch --]
[-- Type: text/x-patch, Size: 1438 bytes --]
From 48eee622561eaef9e941191b8e01f16f05643ea7 Mon Sep 17 00:00:00 2001
From: Vicente Vera Parra <vicentemvp@gmail.com>
Date: Tue, 15 Sep 2015 14:12:32 -0300
Subject: [PATCH 02/19] gnu: Add r-lazyeval.
* gnu/packages/statistics.scm (r-lazyeval): New variable.
---
gnu/packages/statistics.scm | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 9a73a82..22d8290 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -522,3 +522,24 @@ the pre and post conditions that your code should satisfy, while also
producing friendly error messages so that your users know what they've done
wrong.")
(license license:gpl3+)))
+
+(define-public r-lazyeval
+ (package
+ (name "r-lazyeval")
+ (version "0.1.10")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://cran/src/contrib/lazyeval_"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "02qfpn2fmy78vx4jxr7g7rhqzcm1kcivfwai7lbh0vvpawia0qwh"))))
+ (build-system r-build-system)
+ (home-page
+ "https://github.com/hadley/lazyeval")
+ (synopsis
+ "Lazy (non-standard) evaluation in R")
+ (description
+ "This package provides the tools necessary to do non-standard
+evaluation (NSE) in R.")
+ (license license:gpl3+)))
--
2.5.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-15 17:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-13 16:45 [PATCH 02/19] gnu: Add r-lazyeval Vicente Vera
2015-09-14 10:43 ` Ricardo Wurmus
2015-09-14 19:34 ` Vicente Vera
2015-09-15 14:42 ` Ricardo Wurmus
2015-09-15 15:31 ` Vicente Vera
2015-09-15 17:33 ` Vicente Vera
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).