From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vicente Vera Subject: Re: [PATCH 02/19] gnu: Add r-lazyeval. Date: Tue, 15 Sep 2015 12:31:31 -0300 Message-ID: References: <87io7d8en7.fsf@mdc-berlin.de> <87y4g77nhh.fsf@mdc-berlin.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbsCn-00007m-I6 for guix-devel@gnu.org; Tue, 15 Sep 2015 11:31:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbsCi-0003Yg-To for guix-devel@gnu.org; Tue, 15 Sep 2015 11:31:37 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:33436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbsCi-0003YX-QF for guix-devel@gnu.org; Tue, 15 Sep 2015 11:31:32 -0400 Received: by oixx17 with SMTP id x17so97504921oix.0 for ; Tue, 15 Sep 2015 08:31:31 -0700 (PDT) In-Reply-To: <87y4g77nhh.fsf@mdc-berlin.de> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org Hi, Glad to hear the patches helped! I've been fixing most of the issues (sentences with double spaces, long lines) in all the patches. If you don't mind the extra time, I'll attach the corrected patches in the next hours. 2015-09-15 11:42 GMT-03:00 Ricardo Wurmus : > Hi Vicente, > >> Actually, nearly every synopsis and description in these patches are >> taken verbatim from CRAN. > > That=E2=80=99s what I thought. When I prepared my initial patches for R = modules > to test the CRAN importer I found that I needed to edit both synopsis > and description for every package. The quality of descriptions is > certainly better than for the average CPAN package, but it still > requires editing to fit in with the rest of the Guix packages. > >> I'm not familiar enough with this package to amend the description >> provided by the author, so I replaced it with the one offered in the >> package's GitHub repository. > > That=E2=80=99s okay. > >> Upper-case characters corrected. >> >> New patch attached. > > Thank you! > > I think it=E2=80=99s okay, except maybe for the slightly overlong line > containing the hash. Unless there are objections I=E2=80=99d like to pus= h this > tonight (after dropping the hash to its own line). > > ~~ Ricardo > > > PS: I=E2=80=99m wrapping up a project at a bioinfo hackathon and your pat= ches > were very helpful as I had trouble installing dplyr via R. Your patches > made this much simpler, so thank you very much!